espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-24 20:28:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

remove pointless assignment

Browse Source 
Presumably this was supposed to be regname[sizeof (regname) - 1] but was typoed
to regname[sizeof (rename) - 1].  However that should be unnecessary because
sprintf should null terminate.  As is this assignment is invalid ISO C because
rename refers to the function rename (), and sizeof on functions is undefined.
In GNU C C the size of functions is 1 so the expression is the same as
regname[0].  The following call to sprintf () clearly will over right that, so
the statement either has no effect or is invalid.  Given that it seems safe to
just remove it.  While we are there correct the size of regname, and switch
from snprintf to sprintf since we know the exact length of the result.

gas/ChangeLog:

2016-04-15  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>

	* config/tc-mips.c (md_begin): Remove useless assignment.
This commit is contained in:
Trevor Saunders
2016-04-13 05:03:22 -04:00
parent 58484447ed
commit 92fce9bd7a
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gas/ChangeLog
View File

@ -1,3 +1,7 @@
2016-04-15 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
* config/tc-mips.c (md_begin): Remove useless assignment.
2016-04-15 H.J. Lu <hongjiu.lu@intel.com> 2016-04-15 H.J. Lu <hongjiu.lu@intel.com>
* Makefile.in: Regenerated with automake 1.11.6. * Makefile.in: Regenerated with automake 1.11.6.

9
gas/config/tc-mips.c
View File

@ -3601,21 +3601,20 @@ md_begin (void)
for (i = 0; i < 32; i++) for (i = 0; i < 32; i++)
{ {
char regname[7]; char regname[6];
/* R5900 VU0 floating-point register. */ /* R5900 VU0 floating-point register. */
regname[sizeof (rename) - 1] = 0; sprintf (regname, "$vf%d", i);
snprintf (regname, sizeof (regname) - 1, "$vf%d", i);
symbol_table_insert (symbol_new (regname, reg_section, symbol_table_insert (symbol_new (regname, reg_section,
RTYPE_VF | i, &zero_address_frag)); RTYPE_VF | i, &zero_address_frag));
/* R5900 VU0 integer register. */ /* R5900 VU0 integer register. */
snprintf (regname, sizeof (regname) - 1, "$vi%d", i); sprintf (regname, "$vi%d", i);
symbol_table_insert (symbol_new (regname, reg_section, symbol_table_insert (symbol_new (regname, reg_section,
RTYPE_VI | i, &zero_address_frag)); RTYPE_VI | i, &zero_address_frag));
/* MSA register. */ /* MSA register. */
snprintf (regname, sizeof (regname) - 1, "$w%d", i); sprintf (regname, "$w%d", i);
symbol_table_insert (symbol_new (regname, reg_section, symbol_table_insert (symbol_new (regname, reg_section,
RTYPE_MSA | i, &zero_address_frag)); RTYPE_MSA | i, &zero_address_frag));
} }