espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-06 06:45:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Simplify compile_module cleanup

Browse Source 
This simplifies compile_module cleanup by removing the need to
explicitly free anything.  struct setup_sections_data is also cleaned
up a bit.

gdb/ChangeLog
2020-09-23  Tom Tromey  <tom@tromey.com>

	* compile/compile-object-run.c (do_module_cleanup)
	<~do_module_cleanup> :Remove.
	(do_module_cleanup): Update.
	* compile/compile-object-load.h (struct munmap_list): Add move
	assignment operator.
	<source_file>: Now a std::string.
	<munmap_list>: Rename.  No longer a pointer.
	* compile/compile-object-load.c (struct setup_sections_data): Add
	constructor.
	<setup_one_section>: Declare.
	<munmap_list>: Move earlier.
	<m_bfd>: New member.
	<m_last_size, m_last_section_first, m_last_prot,
	m_last_max_alignment>: Rename, add initializers where needed.
	(setup_sections_data::setup_one_section): Rename from
	setup_sections.  Update.
	(compile_object_load): Update.  Don't use bfd_map_over_sections.
This commit is contained in:
Tom Tromey
2020-09-23 09:32:54 -06:00
parent e616f60a6b
commit 92677124d9
4 changed files with 88 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/compile/compile-object-run.c
View File

@ -38,12 +38,6 @@ struct do_module_cleanup
{
}
~do_module_cleanup ()
{
delete module->munmap_list_head;
xfree (module->source_file);
}
DISABLE_COPY_AND_ASSIGN (do_module_cleanup);
/* Boolean to set true upon a call of do_module_cleanup.
@ -102,7 +96,7 @@ do_module_cleanup (void *arg, int registers_valid)
}
/* Delete the .c file. */
unlink (data->module->source_file);
unlink (data->module->source_file.c_str ());
/* Delete the .o file. */
unlink (objfile_name_s.c_str ());