espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-20 09:58:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix seg-fault running strip on a corrupt binary.

Browse Source 
PR binutils/20930
	* objcopy.c (mark_symbols_used_in_relocations): Check for a null
	symbol pointer pointer before attempting to mark the symbol as
	kept.
This commit is contained in:
Nick Clifton
2016-12-06 16:26:42 +00:00
parent 92744f0580
commit 8b929e420a
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
binutils/ChangeLog
View File

@ -1,3 +1,10 @@
2016-12-06 Nick Clifton <nickc@redhat.com>
PR binutils/20930
* objcopy.c (mark_symbols_used_in_relocations): Check for a null
symbol pointer pointer before attempting to mark the symbol as
kept.
2016-12-05 Jose E. Marchesi <jose.marchesi@oracle.com> 2016-12-05 Jose E. Marchesi <jose.marchesi@oracle.com>
* MAINTAINERS: Add myself as maintainer for the SPARC targets. * MAINTAINERS: Add myself as maintainer for the SPARC targets.

3
binutils/objcopy.c
View File

@ -3551,8 +3551,9 @@ mark_symbols_used_in_relocations (bfd *ibfd, sec_ptr isection, void *symbolsarg)
special bfd section symbols, then mark it with BSF_KEEP. */ special bfd section symbols, then mark it with BSF_KEEP. */
for (i = 0; i < relcount; i++) for (i = 0; i < relcount; i++)
{ {
/* See PR 20923 for a reproducer for the NULL test. */ /* See PRs 20923 and 20930 for reproducers for the NULL tests. */
if (relpp[i]->sym_ptr_ptr != NULL if (relpp[i]->sym_ptr_ptr != NULL
&& * relpp[i]->sym_ptr_ptr != NULL
&& *relpp[i]->sym_ptr_ptr != bfd_com_section_ptr->symbol && *relpp[i]->sym_ptr_ptr != bfd_com_section_ptr->symbol
&& *relpp[i]->sym_ptr_ptr != bfd_abs_section_ptr->symbol && *relpp[i]->sym_ptr_ptr != bfd_abs_section_ptr->symbol
&& *relpp[i]->sym_ptr_ptr != bfd_und_section_ptr->symbol) && *relpp[i]->sym_ptr_ptr != bfd_und_section_ptr->symbol)