mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-06-21 02:24:17 +08:00
Remove remaining cleanup from gdb/breakpoint.c
In v3: remove the "have BKPT_CHAIN already discarded" comment too. The remaining null cleanup in breakpoint.c does not seem to protect anything, so remove it. gdb/ChangeLog: 2019-01-23 Tom Tromey <tom@tromey.com> Pedro Alves <palves@redhat.com> * breakpoint.c (create_breakpoint): Remove cleanup.
This commit is contained in:
@ -1,3 +1,8 @@
|
|||||||
|
2019-01-23 Tom Tromey <tom@tromey.com>
|
||||||
|
Pedro Alves <palves@redhat.com>
|
||||||
|
|
||||||
|
* breakpoint.c (create_breakpoint): Remove cleanup.
|
||||||
|
|
||||||
2019-01-23 Tom Tromey <tom@tromey.com>
|
2019-01-23 Tom Tromey <tom@tromey.com>
|
||||||
Andrew Burgess <andrew.burgess@embecosm.com>
|
Andrew Burgess <andrew.burgess@embecosm.com>
|
||||||
Pedro Alves <palves@redhat.com>
|
Pedro Alves <palves@redhat.com>
|
||||||
|
@ -9230,7 +9230,6 @@ create_breakpoint (struct gdbarch *gdbarch,
|
|||||||
unsigned flags)
|
unsigned flags)
|
||||||
{
|
{
|
||||||
struct linespec_result canonical;
|
struct linespec_result canonical;
|
||||||
struct cleanup *bkpt_chain = NULL;
|
|
||||||
int pending = 0;
|
int pending = 0;
|
||||||
int task = 0;
|
int task = 0;
|
||||||
int prev_bkpt_count = breakpoint_count;
|
int prev_bkpt_count = breakpoint_count;
|
||||||
@ -9280,12 +9279,6 @@ create_breakpoint (struct gdbarch *gdbarch,
|
|||||||
if (!pending && canonical.lsals.empty ())
|
if (!pending && canonical.lsals.empty ())
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
/* ----------------------------- SNIP -----------------------------
|
|
||||||
Anything added to the cleanup chain beyond this point is assumed
|
|
||||||
to be part of a breakpoint. If the breakpoint create succeeds
|
|
||||||
then the memory is not reclaimed. */
|
|
||||||
bkpt_chain = make_cleanup (null_cleanup, 0);
|
|
||||||
|
|
||||||
/* Resolve all line numbers to PC's and verify that the addresses
|
/* Resolve all line numbers to PC's and verify that the addresses
|
||||||
are ok for the target. */
|
are ok for the target. */
|
||||||
if (!pending)
|
if (!pending)
|
||||||
@ -9384,11 +9377,6 @@ create_breakpoint (struct gdbarch *gdbarch,
|
|||||||
prev_breakpoint_count = prev_bkpt_count;
|
prev_breakpoint_count = prev_bkpt_count;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* That's it. Discard the cleanups for data inserted into the
|
|
||||||
breakpoint. */
|
|
||||||
discard_cleanups (bkpt_chain);
|
|
||||||
|
|
||||||
/* error call may happen here - have BKPT_CHAIN already discarded. */
|
|
||||||
update_global_location_list (UGLL_MAY_INSERT);
|
update_global_location_list (UGLL_MAY_INSERT);
|
||||||
|
|
||||||
return 1;
|
return 1;
|
||||||
|
Reference in New Issue
Block a user