espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-25 04:49:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

[AArch64][SVE 10/32] Move range check out of parse_aarch64_imm_float

Browse Source 
Since some SVE constants are no longer explicitly tied to the 8-bit
FP immediate format, it seems better to move the range checks out of
parse_aarch64_imm_float and into the callers.

gas/
	* config/tc-aarch64.c (parse_aarch64_imm_float): Remove range check.
	(parse_operands): Check the range of 8-bit FP immediates here instead.
This commit is contained in:
Richard Sandiford
2016-09-21 16:49:15 +01:00
parent 6a9deabec4
commit 874d7e6ef9
2 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gas/ChangeLog
View File

@ -1,3 +1,8 @@
2016-09-21 Richard Sandiford <richard.sandiford@arm.com>
* config/tc-aarch64.c (parse_aarch64_imm_float): Remove range check.
(parse_operands): Check the range of 8-bit FP immediates here instead.
2016-09-21 Richard Sandiford <richard.sandiford@arm.com> 2016-09-21 Richard Sandiford <richard.sandiford@arm.com>
* config/tc-aarch64.c (parse_aarch64_imm_float): Report a specific * config/tc-aarch64.c (parse_aarch64_imm_float): Report a specific

14
gas/config/tc-aarch64.c
View File

@ -2148,7 +2148,8 @@ can_convert_double_to_float (uint64_t imm, uint32_t *fpword)
hexadecimal representation is involved). REG_TYPE says which register hexadecimal representation is involved). REG_TYPE says which register
names should be treated as registers rather than as symbolic immediates. names should be treated as registers rather than as symbolic immediates.
N.B. 0.0 is accepted by this function. */ This routine accepts any IEEE float; it is up to the callers to reject
invalid ones. */
static bfd_boolean static bfd_boolean
parse_aarch64_imm_float (char **ccp, int *immed, bfd_boolean dp_p, parse_aarch64_imm_float (char **ccp, int *immed, bfd_boolean dp_p,
@ -2224,12 +2225,9 @@ parse_aarch64_imm_float (char **ccp, int *immed, bfd_boolean dp_p,
} }
} }
if (aarch64_imm_float_p (fpword) || fpword == 0) *immed = fpword;
{ *ccp = str;
*immed = fpword; return TRUE;
*ccp = str;
return TRUE;
}
invalid_fp: invalid_fp:
set_fatal_syntax_error (_("invalid floating-point constant")); set_fatal_syntax_error (_("invalid floating-point constant"));
@ -5296,7 +5294,7 @@ parse_operands (char *str, const aarch64_opcode *opcode)
= (aarch64_get_qualifier_esize (inst.base.operands[0].qualifier) = (aarch64_get_qualifier_esize (inst.base.operands[0].qualifier)
== 8); == 8);
if (!parse_aarch64_imm_float (&str, &qfloat, dp_p, imm_reg_type) if (!parse_aarch64_imm_float (&str, &qfloat, dp_p, imm_reg_type)
|| qfloat == 0) || !aarch64_imm_float_p (qfloat))
{ {
if (!error_p ()) if (!error_p ())
set_fatal_syntax_error (_("invalid floating-point" set_fatal_syntax_error (_("invalid floating-point"