* config/tc-ppc.c (ppc_pe_comm): Set bfd_com_section segment.

* config/tc-alpha.c (s_alpha_comm): Likewise.  Also, remove
	redundant check.
	* read.c (s_lsym): Remove non-BFD assembler sym handling.
This commit is contained in:
Alan Modra
2005-11-16 01:49:48 +00:00
parent 525852f863
commit 86ebace269
4 changed files with 11 additions and 11 deletions

View File

@ -1,3 +1,10 @@
2005-11-16 Alan Modra <amodra@bigpond.net.au>
* config/tc-ppc.c (ppc_pe_comm): Set bfd_com_section segment.
* config/tc-alpha.c (s_alpha_comm): Likewise. Also, remove
redundant check.
* read.c (s_lsym): Remove non-BFD assembler sym handling.
2005-11-16 Alan Modra <amodra@bigpond.net.au> 2005-11-16 Alan Modra <amodra@bigpond.net.au>
* read.c (s_comm_internal): Set bfd_com_section segment. * read.c (s_comm_internal): Set bfd_com_section segment.

View File

@ -3331,10 +3331,10 @@ s_alpha_comm (int ignore ATTRIBUTE_UNUSED)
subseg_set (new_seg, 0); subseg_set (new_seg, 0);
p = frag_more (temp); p = frag_more (temp);
new_seg->flags |= SEC_IS_COMMON; new_seg->flags |= SEC_IS_COMMON;
if (! S_IS_DEFINED (symbolP)) S_SET_SEGMENT (symbolP, new_seg);
S_SET_SEGMENT (symbolP, new_seg);
#else #else
S_SET_VALUE (symbolP, (valueT) temp); S_SET_VALUE (symbolP, (valueT) temp);
S_SET_SEGMENT (symbolP, bfd_com_section_ptr);
#endif #endif
S_SET_EXTERNAL (symbolP); S_SET_EXTERNAL (symbolP);
} }

View File

@ -4416,6 +4416,7 @@ ppc_pe_comm (lcomm)
{ {
S_SET_VALUE (symbolP, (valueT) temp); S_SET_VALUE (symbolP, (valueT) temp);
S_SET_EXTERNAL (symbolP); S_SET_EXTERNAL (symbolP);
S_SET_SEGMENT (symbolP, bfd_com_section_ptr);
} }
demand_empty_rest_of_line (); demand_empty_rest_of_line ();

View File

@ -2235,15 +2235,7 @@ s_lsym (int ignore ATTRIBUTE_UNUSED)
*p = 0; *p = 0;
symbolP = symbol_find_or_make (name); symbolP = symbol_find_or_make (name);
/* FIXME-SOON I pulled a (&& symbolP->sy_other == 0 && if (S_GET_SEGMENT (symbolP) == undefined_section)
symbolP->sy_desc == 0) out of this test because coff doesn't have
those fields, and I can't see when they'd ever be tripped. I
don't think I understand why they were here so I may have
introduced a bug. As recently as 1.37 didn't have this test
anyway. xoxorich. */
if (S_GET_SEGMENT (symbolP) == undefined_section
&& S_GET_VALUE (symbolP) == 0)
{ {
/* The name might be an undefined .global symbol; be sure to /* The name might be an undefined .global symbol; be sure to
keep the "external" bit. */ keep the "external" bit. */