espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-19 17:18:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix PR python/20129 - use of non-existing variable

Browse Source 
PR python/20129 concerns the error message one gets from a command
like "disable frame-filter global NoSuchFilter".  Currently this
throws a second, unexpected, exception due to the use of a
non-existing variable named "name".

This patch adds regression tests and fixes a couple of spots to use
the correct variable name.

Built and regtested on x86-64 Fedora 23.

2016-06-29  Tom Tromey  <tom@tromey.com>

	PR python/20129:
	* python/lib/gdb/command/frame_filters.py (_do_enable_frame_filter)
	(SetFrameFilterPriority._set_filter_priority): Use "frame_filter",
	not "name".

2016-06-29  Tom Tromey  <tom@tromey.com>

	PR python/20129:
	* gdb.python/py-framefilter.exp: Add tests for setting priority
	and disabling of non-existent frame filter.
This commit is contained in:
Tom Tromey
2016-06-06 11:21:15 -06:00
parent 9d78f827e0
commit 803b47e5d4
4 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/testsuite/gdb.python/py-framefilter.exp
View File

@ -108,6 +108,9 @@ gdb_test "show frame-filter priority global Elider" \
gdb_test "info frame-filter" \
".*1000.*Yes.*Elider.*100.*Yes.*Reverse.*10.*.*No.*Object.*1.*" \
"info frame filter after setting priority"
gdb_test "set frame-filter priority global NoSuchFilter 900" \
"frame-filter 'NoSuchFilter' not found." \
"set priority of a non-existing filter"
# Test enable/disable
gdb_test "info frame-filter" \
@ -123,6 +126,9 @@ gdb_test_no_output "enable frame-filter global Elider" \
gdb_test "info frame-filter" \
".*1000.*Yes.*Elider.*100.*Yes.*Reverse.*10.*.*No.*Object.*1.*" \
"info frame filter after reenabling frame filter"
gdb_test "disable frame-filter global NoSuchFilter" \
"frame-filter 'NoSuchFilter' not found." \
"disable a non-existing filter"
# Test no-filters
gdb_test "bt no-filters" \