espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-25 04:49:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Enable software single stepping for while-stepping actions in GDBServer

Browse Source 
This patch enables software single stepping if the targets support it,
to do while-stepping actions.

No regressions, tested on ubuntu 14.04 ARMv7 and x86.
With gdbserver-{native,extended} / { -marm -mthumb }

gdb/gdbserver/ChangeLog:

	* linux-low.c (single_step): New function.
	(linux_resume_one_lwp_throw): Call single_step.
	(start_step_over): Likewise.
This commit is contained in:
Antoine Tremblay
2015-12-18 11:33:59 -05:00
parent d9311bfaf5
commit 7fe5e27e9d
2 changed files with 37 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,9 @@
2015-12-18 Antoine Tremblay <antoine.tremblay@ericsson.com>
* linux-low.c (single_step): New function.
(linux_resume_one_lwp_throw): Call single_step.
(start_step_over): Likewise.
2015-12-18 Antoine Tremblay <antoine.tremblay@ericsson.com> 2015-12-18 Antoine Tremblay <antoine.tremblay@ericsson.com>
* Makefile.in (SFILES): Append arch/arm-linux.c, * Makefile.in (SFILES): Append arch/arm-linux.c,

48
gdb/gdbserver/linux-low.c
View File

@ -3980,6 +3980,33 @@ install_software_single_step_breakpoints (struct lwp_info *lwp)
do_cleanups (old_chain); do_cleanups (old_chain);
} }
/* Single step via hardware or software single step.
Return 1 if hardware single stepping, 0 if software single stepping
or can't single step. */
static int
single_step (struct lwp_info* lwp)
{
int step = 0;
if (can_hardware_single_step ())
{
step = 1;
}
else if (can_software_single_step ())
{
install_software_single_step_breakpoints (lwp);
step = 0;
}
else
{
if (debug_threads)
debug_printf ("stepping is not implemented on this target");
}
return step;
}
/* Resume execution of LWP. If STEP is nonzero, single-step it. If /* Resume execution of LWP. If STEP is nonzero, single-step it. If
SIGNAL is nonzero, give it that signal. */ SIGNAL is nonzero, give it that signal. */
@ -4127,13 +4154,13 @@ linux_resume_one_lwp_throw (struct lwp_info *lwp,
address, continue, and carry on catching this while-stepping address, continue, and carry on catching this while-stepping
action only when that breakpoint is hit. A future action only when that breakpoint is hit. A future
enhancement. */ enhancement. */
if (thread->while_stepping != NULL if (thread->while_stepping != NULL)
&& can_hardware_single_step ())
{ {
if (debug_threads) if (debug_threads)
debug_printf ("lwp %ld has a while-stepping action -> forcing step.\n", debug_printf ("lwp %ld has a while-stepping action -> forcing step.\n",
lwpid_of (thread)); lwpid_of (thread));
step = 1;
step = single_step (lwp);
} }
if (proc->tdesc != NULL && the_low_target.get_pc != NULL) if (proc->tdesc != NULL && the_low_target.get_pc != NULL)
@ -4539,20 +4566,7 @@ start_step_over (struct lwp_info *lwp)
uninsert_breakpoints_at (pc); uninsert_breakpoints_at (pc);
uninsert_fast_tracepoint_jumps_at (pc); uninsert_fast_tracepoint_jumps_at (pc);
if (can_hardware_single_step ()) step = single_step (lwp);
{
step = 1;
}
else if (can_software_single_step ())
{
install_software_single_step_breakpoints (lwp);
step = 0;
}
else
{
internal_error (__FILE__, __LINE__,
"stepping is not implemented on this target");
}
current_thread = saved_thread; current_thread = saved_thread;