espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-19 09:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

[AArch64] Make gdbserver register set selection dynamic

Browse Source 
The current register set selection mechanism for AArch64 is static, based
on a pre-populated array of register sets.

This means that we might potentially probe register sets that are not
available. This is OK if the kernel errors out during ptrace, but probing the
tag_ctl register, for example, does not result in a ptrace error if the kernel
supports the tagged address ABI but not MTE (PR 28355).

Making the register set selection dynamic, based on feature checks, solves
this and simplifies the code a bit. It allows us to list all of the register
sets only once, and pick and choose based on HWCAP/HWCAP2 or other properties.

I plan to backport this fix to GDB 11 as well.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28355
This commit is contained in:
Luis Machado
2021-10-29 14:54:36 -03:00
parent 5fff6115fe
commit 7fd8546853
2 changed files with 125 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
gdb/arch/aarch64.h
View File

@ -22,6 +22,15 @@
#include "gdbsupport/tdesc.h"
/* Holds information on what architectural features are available. This is
used to select register sets. */
struct aarch64_features
{
bool sve = false;
bool pauth = false;
bool mte = false;
};
/* Create the aarch64 target description. A non zero VQ value indicates both
the presence of SVE and the Vector Quotient - the number of 128bit chunks in
an SVE Z register. HAS_PAUTH_P indicates the presence of the PAUTH