mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-06-19 00:59:15 +08:00
Move value_true to value.h
I noticed that value_true is declared in language.h and defined in language.c. However, as part of the value API, I think it would be better in one of those files. And, because it is very short, I changed it to be an inline function in value.h. I've also removed a comment from the implementation, on the basis that it seems obsolete -- if the change it suggests was needed, it probably would have been done by now; and if it is needed in the future, odds are it would be done differently anyway. Finally, this patch also changes value_true and value_logical_not to return a bool, and updates some uses.
This commit is contained in:
@ -387,23 +387,6 @@ language_info ()
|
||||
show_language_command (NULL, 1, NULL, NULL);
|
||||
}
|
||||
|
||||
|
||||
/* This page contains functions that return info about
|
||||
(struct value) values used in GDB. */
|
||||
|
||||
/* Returns non-zero if the value VAL represents a true value. */
|
||||
int
|
||||
value_true (struct value *val)
|
||||
{
|
||||
/* It is possible that we should have some sort of error if a non-boolean
|
||||
value is used in this context. Possibly dependent on some kind of
|
||||
"boolean-checking" option like range checking. But it should probably
|
||||
not depend on the language except insofar as is necessary to identify
|
||||
a "boolean" value (i.e. in C using a float, pointer, etc., as a boolean
|
||||
should be an error, probably). */
|
||||
return !value_logical_not (val);
|
||||
}
|
||||
|
||||
/* This page contains functions for the printing out of
|
||||
error messages that occur during type- and range-
|
||||
checking. */
|
||||
|
Reference in New Issue
Block a user