espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-28 07:08:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Uniquefy gdb.threads/attach-into-signal.exp

Browse Source 
Hi,

While examining BuildBot's logs, I noticed:

  <https://sourceware.org/ml/gdb-testers/2015-q3/msg03767.html>

gdb.threads/attach-into-signal.exp has two nested loops and don't use
unique messages.  This commit fixes that.  Pushed under the obvious
rule.

gdb/testsuite/ChangeLog:
2015-07-29  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.threads/attach-into-signal.exp (corefunc): Use
	with_test_prefix on nested loops, uniquefying the test messages.
This commit is contained in:
Sergio Durigan Junior
2015-07-29 11:10:49 -04:00
parent dac804dfa6
commit 7da5b897c9
2 changed files with 73 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2015-07-29 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.threads/attach-into-signal.exp (corefunc): Use
with_test_prefix on nested loops, uniquefying the test messages.
2015-07-29 Sergio Durigan Junior <sergiodj@redhat.com> 2015-07-29 Sergio Durigan Junior <sergiodj@redhat.com>
* gdb.python/py-objfile.exp: Fix typo that snuck in from my last * gdb.python/py-objfile.exp: Fix typo that snuck in from my last

6
gdb/testsuite/gdb.threads/attach-into-signal.exp
View File

@ -60,8 +60,10 @@ proc corefunc { threadtype executable } {
set attempt 1 set attempt 1
set passes 1 set passes 1
while { $passes < 3 && $attempt <= $attempts } { while { $passes < 3 && $attempt <= $attempts } {
with_test_prefix "attempt $attempt" {
set stoppedtry 0 set stoppedtry 0
while { $stoppedtry < 10 } { while { $stoppedtry < 10 } {
with_test_prefix "stoppedtry $stoppedtry" {
if [catch {open /proc/${testpid}/status r} fileid] { if [catch {open /proc/${testpid}/status r} fileid] {
set stoppedtry 10 set stoppedtry 10
break break
@ -78,6 +80,7 @@ proc corefunc { threadtype executable } {
sleep 1 sleep 1
set stoppedtry [expr $stoppedtry + 1] set stoppedtry [expr $stoppedtry + 1]
} }
}
if { $stoppedtry >= 10 } { if { $stoppedtry >= 10 } {
verbose -log $line2 verbose -log $line2
set test "process is still running on the attempt # $attempt of $attempts" set test "process is still running on the attempt # $attempt of $attempts"
@ -130,6 +133,8 @@ proc corefunc { threadtype executable } {
gdb_test "detach" "Detaching from.*" "" gdb_test "detach" "Detaching from.*" ""
} }
}
if {$passes < 3} { if {$passes < 3} {
if {$attempt > $attempts} { if {$attempt > $attempts} {
unresolved $test unresolved $test
@ -139,7 +144,6 @@ proc corefunc { threadtype executable } {
} }
# Exit and detach the process. # Exit and detach the process.
gdb_exit gdb_exit
# Make sure we don't leave a process around to confuse the # Make sure we don't leave a process around to confuse the