espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-26 22:07:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

alpha-coff: large memory allocation

Browse Source 
* coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Provide an upper
	limit to decompressed element size.
This commit is contained in:
Alan Modra
2020-03-02 10:15:36 +10:30
parent 26f60d5939
commit 7d4b2d2d29
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/ChangeLog
View File

@ -1,3 +1,8 @@
2020-03-02 Alan Modra <amodra@gmail.com>
* coff-alpha.c (alpha_ecoff_get_elt_at_filepos): Provide an upper
limit to decompressed element size.
2020-03-02 Alan Modra <amodra@gmail.com> 2020-03-02 Alan Modra <amodra@gmail.com>
* vms-lib.c (vms_traverse_index): Add recur_count param and * vms-lib.c (vms_traverse_index): Add recur_count param and

9
bfd/coff-alpha.c
View File

@ -2050,6 +2050,7 @@ alpha_ecoff_get_elt_at_filepos (bfd *archive, file_ptr filepos)
bfd_size_type size; bfd_size_type size;
bfd_byte *buf, *p; bfd_byte *buf, *p;
struct bfd_in_memory *bim; struct bfd_in_memory *bim;
ufile_ptr filesize;
buf = NULL; buf = NULL;
nbfd = _bfd_get_elt_at_filepos (archive, filepos); nbfd = _bfd_get_elt_at_filepos (archive, filepos);
@ -2083,6 +2084,14 @@ alpha_ecoff_get_elt_at_filepos (bfd *archive, file_ptr filepos)
goto error_return; goto error_return;
size = H_GET_64 (nbfd, ab); size = H_GET_64 (nbfd, ab);
/* The decompression algorithm will at most expand by eight times. */
filesize = bfd_get_file_size (archive);
if (filesize != 0 && size / 8 > filesize)
{
bfd_set_error (bfd_error_malformed_archive);
goto error_return;
}
if (size != 0) if (size != 0)
{ {
bfd_size_type left; bfd_size_type left;