espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-23 11:39:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove tui_clear_source_windows_detail

Browse Source 
The calls to tui_clear_source_windows_detail in tui_add_win_to_layout
aren't needed, because (after the resize unification) resizing will
update the window contents.  Removing these calls lets us remove
several other things as well.

gdb/ChangeLog
2019-09-20  Tom Tromey  <tom@tromey.com>

	* tui/tui-data.h (tui_clear_source_windows_detail): Don't
	declare.
	* tui/tui-layout.c (tui_add_win_to_layout): Don't call
	tui_clear_source_windows_detail.
	* tui/tui-winsource.h (struct tui_source_window_base)
	<clear_detail>: Don't declare.
	* tui/tui-winsource.c (tui_source_window_base::clear_detail):
	Remove.
	* tui/tui-data.c (tui_clear_source_windows_detail): Remove.
This commit is contained in:
Tom Tromey
2019-07-19 12:59:35 -06:00
parent d420769627
commit 78d5933a43
6 changed files with 12 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gdb/ChangeLog
View File

@ -1,3 +1,15 @@
2019-09-20 Tom Tromey <tom@tromey.com>
* tui/tui-data.h (tui_clear_source_windows_detail): Don't
declare.
* tui/tui-layout.c (tui_add_win_to_layout): Don't call
tui_clear_source_windows_detail.
* tui/tui-winsource.h (struct tui_source_window_base)
<clear_detail>: Don't declare.
* tui/tui-winsource.c (tui_source_window_base::clear_detail):
Remove.
* tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2019-09-20 Tom Tromey <tromey@adacore.com>
PR ada/24919:

9
gdb/tui/tui-data.c
View File

@ -87,15 +87,6 @@ tui_set_win_with_focus (struct tui_win_info *win_info)
}
/* Clear the pertinent detail in the source windows. */
void
tui_clear_source_windows_detail ()
{
for (tui_source_window_base *win : tui_source_windows ())
win->clear_detail ();
}
/* Accessor for the term_height. */
int
tui_term_height (void)

1
gdb/tui/tui-data.h
View File

@ -295,7 +295,6 @@ extern void tui_set_term_height_to (int);
extern int tui_term_width (void);
extern void tui_set_term_width_to (int);
extern struct tui_locator_window *tui_locator_win_info_ptr (void);
extern void tui_clear_source_windows_detail (void);
extern struct tui_win_info *tui_win_with_focus (void);
extern void tui_set_win_with_focus (struct tui_win_info *);
extern int tui_win_resized (void);

2
gdb/tui/tui-layout.c
View File

@ -207,7 +207,6 @@ tui_add_win_to_layout (enum tui_win_type type)
&& cur_layout != SRC_DISASSEM_COMMAND
&& cur_layout != SRC_DATA_COMMAND)
{
tui_clear_source_windows_detail ();
if (cur_layout == DISASSEM_DATA_COMMAND)
show_layout (SRC_DATA_COMMAND);
else
@ -219,7 +218,6 @@ tui_add_win_to_layout (enum tui_win_type type)
&& cur_layout != SRC_DISASSEM_COMMAND
&& cur_layout != DISASSEM_DATA_COMMAND)
{
tui_clear_source_windows_detail ();
if (cur_layout == SRC_DATA_COMMAND)
show_layout (DISASSEM_DATA_COMMAND);
else

11
gdb/tui/tui-winsource.c
View File

@ -253,17 +253,6 @@ tui_source_window_base::show_source_content ()
refresh_window ();
}
/* See tui-data.h. */
void
tui_source_window_base::clear_detail ()
{
gdbarch = NULL;
start_line_or_addr.loa = LOA_ADDRESS;
start_line_or_addr.u.addr = 0;
horizontal_offset = 0;
}
tui_source_window_base::tui_source_window_base (enum tui_win_type type)
: tui_win_info (type)
{

2
gdb/tui/tui-winsource.h
View File

@ -101,8 +101,6 @@ protected:
public:
void clear_detail ();
/* Refill the source window's source cache and update it. If this
is a disassembly window, then just update it. */
void refill ();