espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-06 06:45:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove iterate_over_inferiors

Browse Source 
The last caller of iterate_over_inferiors is darwin-nat.c.  This patch
removes the calls from this file, and then remove
iterate_over_inferiors.

In general I think "external iteration" is to be preferred in gdb, the
main benefit being that the code is easier to read.

I rebuilt this on Darwin.  I seem to only have access to Darwin
systems where gdb does not yet work :-(, so I can't run the test
suite.

gdb/ChangeLog
2020-04-23  Tom Tromey  <tom@tromey.com>

	* inferior.h (iterate_over_inferiors): Don't declare.
	* inferior.c (iterate_over_inferiors): Remove.
	* darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
	Remove.
	(darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
	use iterate_over_inferiors.
	(darwin_resume_inferior_it)
	(struct resume_inferior_threads_param)
	(darwin_resume_inferior_threads_it): Remove.
	(darwin_nat_target::resume): Don't use iterate_over_inferiors.

Change-Id: Ib2fdf2c98e40f13156ff869ed3173d5f1fdae7ea
This commit is contained in:
Tom Tromey
2020-04-23 06:26:31 -06:00
committed by Tom Tromey
parent 2745674244
commit 740480b88a
4 changed files with 32 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gdb/inferior.h
View File

@ -589,20 +589,6 @@ extern struct inferior *find_inferior_id (int num);
extern struct inferior *
find_inferior_for_program_space (struct program_space *pspace);
/* Inferior iterator function.
Calls a callback function once for each inferior, so long as the
callback function returns false. If the callback function returns
true, the iteration will end and the current inferior will be
returned. This can be useful for implementing a search for a
inferior with arbitrary attributes, or for applying some operation
to every inferior.
It is safe to delete the iterated inferior from the callback. */
extern struct inferior *iterate_over_inferiors (int (*) (struct inferior *,
void *),
void *);
/* Returns true if the inferior list is not empty. */
extern int have_inferiors (void);