espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-06 14:49:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Filtered output cleanup in expression dumping

Browse Source 
Most of the expression-dumping code uses filtered output, but a few
functions did not.  This patch cleans up these instance.

Note that this won't cause any behavior change, because the only calls
to dump_prefix_expression pass in gdb_stdlog.  However, in the long
run it's easier to audit the code if the number of uses of _unfiltered
is reduced.
This commit is contained in:
Tom Tromey
2021-12-30 12:34:15 -07:00
parent 50f5d5c34d
commit 729a211143
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
gdb/expprint.c
View File

@ -138,9 +138,9 @@ dump_for_expression (struct ui_file *stream, int depth,
{ {
fprintf_filtered (stream, _("%*sType flags: "), depth, ""); fprintf_filtered (stream, _("%*sType flags: "), depth, "");
if (flags & TYPE_INSTANCE_FLAG_CONST) if (flags & TYPE_INSTANCE_FLAG_CONST)
fputs_unfiltered ("const ", stream); fputs_filtered ("const ", stream);
if (flags & TYPE_INSTANCE_FLAG_VOLATILE) if (flags & TYPE_INSTANCE_FLAG_VOLATILE)
fputs_unfiltered ("volatile", stream); fputs_filtered ("volatile", stream);
fprintf_filtered (stream, "\n"); fprintf_filtered (stream, "\n");
} }
@ -152,24 +152,24 @@ dump_for_expression (struct ui_file *stream, int depth,
switch (flags & ~C_CHAR) switch (flags & ~C_CHAR)
{ {
case C_WIDE_STRING: case C_WIDE_STRING:
fputs_unfiltered (_("wide "), stream); fputs_filtered (_("wide "), stream);
break; break;
case C_STRING_16: case C_STRING_16:
fputs_unfiltered (_("u16 "), stream); fputs_filtered (_("u16 "), stream);
break; break;
case C_STRING_32: case C_STRING_32:
fputs_unfiltered (_("u32 "), stream); fputs_filtered (_("u32 "), stream);
break; break;
default: default:
fputs_unfiltered (_("ordinary "), stream); fputs_filtered (_("ordinary "), stream);
break; break;
} }
if ((flags & C_CHAR) != 0) if ((flags & C_CHAR) != 0)
fputs_unfiltered (_("char"), stream); fputs_filtered (_("char"), stream);
else else
fputs_unfiltered (_("string"), stream); fputs_filtered (_("string"), stream);
fputs_unfiltered ("\n", stream); fputs_filtered ("\n", stream);
} }
void void
@ -178,13 +178,13 @@ dump_for_expression (struct ui_file *stream, int depth,
{ {
fprintf_filtered (stream, _("%*sRange:"), depth, ""); fprintf_filtered (stream, _("%*sRange:"), depth, "");
if ((flags & RANGE_LOW_BOUND_DEFAULT) != 0) if ((flags & RANGE_LOW_BOUND_DEFAULT) != 0)
fputs_unfiltered (_("low-default "), stream); fputs_filtered (_("low-default "), stream);
if ((flags & RANGE_HIGH_BOUND_DEFAULT) != 0) if ((flags & RANGE_HIGH_BOUND_DEFAULT) != 0)
fputs_unfiltered (_("high-default "), stream); fputs_filtered (_("high-default "), stream);
if ((flags & RANGE_HIGH_BOUND_EXCLUSIVE) != 0) if ((flags & RANGE_HIGH_BOUND_EXCLUSIVE) != 0)
fputs_unfiltered (_("high-exclusive "), stream); fputs_filtered (_("high-exclusive "), stream);
if ((flags & RANGE_HAS_STRIDE) != 0) if ((flags & RANGE_HAS_STRIDE) != 0)
fputs_unfiltered (_("has-stride"), stream); fputs_filtered (_("has-stride"), stream);
fprintf_filtered (stream, "\n"); fprintf_filtered (stream, "\n");
} }