espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-26 07:19:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Allow the use of SOURCE_DATE_EPOCH in the timestamps for members of static archives.

Browse Source 
(For some reason this commit was not applied at the time that the patch was approved).
This commit is contained in:
Nick Clifton
2023-09-26 14:07:23 +01:00
parent 0128542673
commit 6f56739807
7 changed files with 331 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
binutils/ar.c
View File

@ -807,7 +807,7 @@ main (int argc, char **argv)
fatal (_("`u' is only meaningful with the `r' option."));
if (newer_only && deterministic > 0)
fatal (_("`u' is not meaningful with the `D' option."));
non_fatal (_("`u' is not meaningful with the `D' option - replacement will always happen."));
if (newer_only && deterministic < 0 && DEFAULT_AR_DETERMINISTIC)
non_fatal (_("\
@ -1482,6 +1482,7 @@ replace_members (bfd *arch, char **files_to_move, bool quick)
&& current->arelt_data != NULL)
{
bool replaced;
if (newer_only)
{
struct stat fsbuf, asbuf;
@ -1492,12 +1493,33 @@ replace_members (bfd *arch, char **files_to_move, bool quick)
bfd_fatal (*files_to_move);
goto next_file;
}
if (bfd_stat_arch_elt (current, &asbuf) != 0)
/* xgettext:c-format */
fatal (_("internal stat error on %s"),
bfd_get_filename (current));
if (fsbuf.st_mtime <= asbuf.st_mtime)
/* A note about deterministic timestamps: In an
archive created in a determistic manner the
individual elements will either have a timestamp
of 0 or SOURCE_DATE_EPOCH, depending upon the
method used. This will be the value retrieved
by bfd_stat_arch_elt().
The timestamp in fsbuf.st_mtime however will
definitely be greater than 0, and it is unlikely
to be less than SOURCE_DATE_EPOCH. (FIXME:
should we test for this case case and issue an
error message ?)
So in either case fsbuf.st_mtime > asbuf.st_time
and hence the incoming file will replace the
current file. Which is what should be expected to
happen. Deterministic archives have no real sense
of the time/date when their elements were created,
and so any updates to the archive should always
result in replaced files. */
goto next_file;
}