espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-28 23:39:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

2010-09-27 Tejas Belagod <tejas.belagod@arm.com>

Browse Source 
* gas/config/tc-arm.c (do_neon_ldr_str): Deprecate ARM-mode PC-relative
	VSTR, issue an error in THUMB mode.
	* opcodes/arm_dis.c (print_insn_coprocessor): Apply off-by-alignment
	correction to unaligned PCs while printing comment.
	* gas/testsuite/gas/arm/vldr.s: New test for pc-relative VLDR disassembly comment.
	* gas/testsuite/gas/arm/vldr.d: Likewise.
	* gas/testsuite/gas/arm/vstr-bad.s: New test for PC-relative VSTR.
	* gas/testsuite/gas/arm/vstr-thumb-bad.l: Likewise.
	* gas/testsuite/gas/arm/vstr-thumb-bad.d: Likewise.
	* gas/testsuite/gas/arm/vstr-arm-bad.l: Likewise.
	* gas/testsuite/gas/arm/vstr-arm-bad.d: Likewise.
This commit is contained in:
Matthew Gretton-Dann
2010-09-27 09:47:05 +00:00
parent a7cb5251cf
commit 6844b2c2db
12 changed files with 89 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gas/ChangeLog
View File

@ -1,3 +1,8 @@
2010-09-27 Tejas Belagod <tejas.belagod@arm.com>
* config/tc-arm.c (do_neon_ldr_str): Deprecate ARM-mode PC-relative
VSTR, issue an error in THUMB mode.
2010-09-23 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
* config/tc-arm.c (arm_ext_virt): New variable.

12
gas/config/tc-arm.c
View File

@ -14885,6 +14885,18 @@ do_neon_ldr_str (void)
{
int is_ldr = (inst.instruction & (1 << 20)) != 0;
/* Use of PC in vstr in ARM mode is deprecated in ARMv7.
And is UNPREDICTABLE in thumb mode. */
if (!is_ldr
&& inst.operands[1].reg == REG_PC
&& ARM_CPU_HAS_FEATURE (selected_cpu, arm_ext_v7))
{
if (!thumb_mode && warn_on_deprecated)
as_warn (_("Use of PC here is deprecated"));
else
inst.error = _("Use of PC here is UNPREDICTABLE");
}
if (inst.operands[0].issingle)
{
if (is_ldr)

10
gas/testsuite/ChangeLog
View File

@ -1,3 +1,13 @@
2010-09-27 Tejas Belagod <tejas.belagod@arm.com>
* gas/arm/vldr.s: New test for pc-relative VLDR disassembly comment.
* gas/arm/vldr.d: Likewise.
* gas/arm/vstr-bad.s: New test for PC-relative VSTR.
* gas/arm/vstr-thumb-bad.l: Likewise.
* gas/arm/vstr-thumb-bad.d: Likewise.
* gas/arm/vstr-arm-bad.l: Likewise.
* gas/arm/vstr-arm-bad.d: Likewise.
2010-09-23 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
* gas/arm/armv7-a+virt.d: New test.

15
gas/testsuite/gas/arm/vldr.d Normal file
View File

@ -0,0 +1,15 @@
# name: VFP VLDR
# as: -mfpu=vfp3 -mcpu=cortex-a8 -mthumb
# source: vldr.s
# objdump: -dr --prefix-addresses --show-raw-insn
.*: +file format .*arm.*
Disassembly of section .text:
0[0-9a-f]+ <[^>]+> bf00 nop
0[0-9a-f]+ <[^>]+> ed9f 0b03 vldr d0, \[pc, #12\] ; 00000010 <float>
0[0-9a-f]+ <[^>]+> ed9f 0b02 vldr d0, \[pc, #8\] ; 00000010 <float>
0[0-9a-f]+ <[^>]+> bf00 nop
0[0-9a-f]+ <[^>]+> bf00 nop
0[0-9a-f]+ <[^>]+> bf00 nop
...

10
gas/testsuite/gas/arm/vldr.s Normal file
View File

@ -0,0 +1,10 @@
.syntax unified
.text
nop
vldr d0, float
vldr d0, float
nop
nop
.align
float: .double 0.0

4
gas/testsuite/gas/arm/vstr-arm-bad.d Normal file
View File

@ -0,0 +1,4 @@
# name: VFP PC-relative VSTR arm mode
# as: -mfpu=vfp3 -mcpu=cortex-a8
# source: vstr-bad.s
# error-output: vstr-arm-bad.l

3
gas/testsuite/gas/arm/vstr-arm-bad.l Normal file
View File

@ -0,0 +1,3 @@
[^:]*: Assembler messages:
[^:]*:6: Warning: Use of PC here is deprecated
[^:]*:7: Warning: Use of PC here is deprecated

12
gas/testsuite/gas/arm/vstr-bad.s Normal file
View File

@ -0,0 +1,12 @@
.syntax unified
.text
nop
vstr d0, float
vstr d0, [pc, #4]
nop
nop
.align
float: .double 0.0

4
gas/testsuite/gas/arm/vstr-thumb-bad.d Normal file
View File

@ -0,0 +1,4 @@
# name: VFP PC-relative VSTR thumb mode
# as: -mfpu=vfp3 -mthumb -mcpu=cortex-a8
# source: vstr-bad.s
# error-output: vstr-thumb-bad.l

3
gas/testsuite/gas/arm/vstr-thumb-bad.l Normal file
View File

@ -0,0 +1,3 @@
[^:]*: Assembler messages:
[^:]*:6: Error: Use of PC here is UNPREDICTABLE -- `vstr d0,float'
[^:]*:7: Error: Use of PC here is UNPREDICTABLE -- `vstr d0,\[pc,#4\]'

5
opcodes/ChangeLog
View File

@ -1,3 +1,8 @@
2010-09-27 Tejas Belagod <tejas.belagod@arm.com>
* arm_dis.c (print_insn_coprocessor): Apply off-by-alignment
correction to unaligned PCs while printing comment.
2010-09-23 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
* arm-dis.c (arm_opcodes): Add Virtualiztion Extensions support.

6
opcodes/arm-dis.c
View File

@ -1910,8 +1910,12 @@ print_insn_coprocessor (bfd_vma pc,
if (rn == 15 && (PRE_BIT_SET || WRITEBACK_BIT_SET))
{
func (stream, "\t; ");
/* For unaligned PCs, apply off-by-alignment
correction. */
info->print_address_func (offset + pc
+ info->bytes_per_chunk * 2, info);
+ info->bytes_per_chunk * 2
- (pc & 3),
info);
}
}
break;