Decode Ada types in Python layer

GNAT emits encoded type names, but these aren't usually of interest to
users.  The Ada language code in gdb hides this oddity -- but the
Python layer does not.  This patch changes the Python code to use the
decoded Ada type name, when appropriate.

I looked at decoding Ada type names during construction, as that would
be cleaner.  However, the Ada support in gdb relies on the encodings
at various points, so this isn't really doable right now.

2021-06-25  Tom Tromey  <tromey@adacore.com>

	* python/py-type.c (typy_get_name): Decode an Ada type name.

gdb/testsuite/ChangeLog
2021-06-25  Tom Tromey  <tromey@adacore.com>

	* gdb.ada/py_range.exp: Add type name test cases.
This commit is contained in:
Tom Tromey
2021-06-25 08:01:15 -06:00
parent 8a3df5acae
commit 67470e9d8b
4 changed files with 22 additions and 0 deletions

View File

@ -1,3 +1,7 @@
2021-06-25 Tom Tromey <tromey@adacore.com>
* python/py-type.c (typy_get_name): Decode an Ada type name.
2021-06-25 Tom Tromey <tromey@adacore.com>
* ada-lang.c (ada_decode): Add wrap parameter.

View File

@ -27,6 +27,7 @@
#include "objfiles.h"
#include "language.h"
#include "typeprint.h"
#include "ada-lang.h"
struct type_object
{
@ -393,6 +394,14 @@ typy_get_name (PyObject *self, void *closure)
if (type->name () == NULL)
Py_RETURN_NONE;
/* Ada type names are encoded, but it is better for users to see the
decoded form. */
if (ADA_TYPE_P (type))
{
std::string name = ada_decode (type->name (), false);
if (!name.empty ())
return PyString_FromString (name.c_str ());
}
return PyString_FromString (type->name ());
}

View File

@ -1,3 +1,7 @@
2021-06-25 Tom Tromey <tromey@adacore.com>
* gdb.ada/py_range.exp: Add type name test cases.
2021-06-24 Tom de Vries <tdevries@suse.de>
* gdb.base/info-macros.exp: Add <EOL> after trailing whitespace in

View File

@ -40,3 +40,8 @@ gdb_test "python print(int(gdb.parse_and_eval('si')))" \
gdb_test "python print(int(gdb.parse_and_eval('ir')))" \
"974"
gdb_test "python print(gdb.parse_and_eval('si').type)" \
"foo\\.small_integer" "print type"
gdb_test "python print(gdb.parse_and_eval('si').type.name)" \
"foo\\.small_integer" "print type name"