espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-19 09:14:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use scoped_value_mark in more places

Browse Source 
I looked at all the spots using value_mark, and converted all the
straightforward ones to use scoped_value_mark instead.

Regression tested on x86-64 Fedora 34.
This commit is contained in:
Tom Tromey
2022-10-03 13:51:58 -06:00
parent ce6c3d253b
commit 65558ca5df
8 changed files with 36 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gdb/ada-lang.c
View File

@ -7858,7 +7858,6 @@ ada_template_to_fixed_record_type_1 (struct type *type,
CORE_ADDR address, struct value *dval0,
int keep_dynamic_fields)
{
struct value *mark = value_mark ();
struct value *dval;
struct type *rtype;
int nfields, bit_len;
@ -7867,6 +7866,8 @@ ada_template_to_fixed_record_type_1 (struct type *type,
int fld_bit_len;
int f;
scoped_value_mark mark;
/* Compute the number of fields in this record type that are going
to be processed: unless keep_dynamic_fields, this includes only
fields whose position and length are static will be processed. */
@ -8068,7 +8069,6 @@ ada_template_to_fixed_record_type_1 (struct type *type,
else
rtype->set_length (align_up (rtype->length (), type->length ()));
value_free_to_mark (mark);
return rtype;
}
@ -8169,7 +8169,6 @@ static struct type *
to_record_with_fixed_variant_part (struct type *type, const gdb_byte *valaddr,
CORE_ADDR address, struct value *dval0)
{
struct value *mark = value_mark ();
struct value *dval;
struct type *rtype;
struct type *branch_type;
@ -8179,6 +8178,7 @@ to_record_with_fixed_variant_part (struct type *type, const gdb_byte *valaddr,
if (variant_field == -1)
return type;
scoped_value_mark mark;
if (dval0 == NULL)
{
dval = value_from_contents_and_address (type, valaddr, address);
@ -8228,7 +8228,6 @@ to_record_with_fixed_variant_part (struct type *type, const gdb_byte *valaddr,
rtype->set_length (rtype->length ()
- type->field (variant_field).type ()->length ());
value_free_to_mark (mark);
return rtype;
}
@ -12311,11 +12310,8 @@ should_stop_exception (const struct bp_location *bl)
stop = true;
try
{
struct value *mark;
mark = value_mark ();
scoped_value_mark mark;
stop = value_true (evaluate_expression (ada_loc->excep_cond_expr.get ()));
value_free_to_mark (mark);
}
catch (const gdb_exception &ex)
{