espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-19 17:18:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential buffer overruns when creating DLLs.

Browse Source 
PR 29006
	* pe-dll.c (make_head): Use asprintf to allocate and populate a
	buffer containing the temporary name.
	(make_tail, make_one, make_singleton_name_thunk): Likewise.
	(make_import_fixup_mark, make_import_fixup_entry): Likewise.
	(make_runtime_pseudo_reloc): Likewise.
	(pe_create_runtime_relocator_reference): Likewise.
This commit is contained in:
Nick Clifton
2022-04-27 08:35:18 +01:00
parent 16538271c8
commit 639d467b08
2 changed files with 53 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ld/ChangeLog
View File

@ -1,3 +1,13 @@
2022-04-27 Nick Clifton <nickc@redhat.com>
PR 29006
* pe-dll.c (make_head): Use asprintf to allocate and populate a
buffer containing the temporary name.
(make_tail, make_one, make_singleton_name_thunk): Likewise.
(make_import_fixup_mark, make_import_fixup_entry): Likewise.
(make_runtime_pseudo_reloc): Likewise.
(pe_create_runtime_relocator_reference): Likewise.
2022-04-25 Nick Clifton <nickc@redhat.com> 2022-04-25 Nick Clifton <nickc@redhat.com>
PR 29072 PR 29072

58
ld/pe-dll.c
View File

@ -2084,8 +2084,12 @@ make_head (bfd *parent)
char *oname; char *oname;
bfd *abfd; bfd *abfd;
oname = xmalloc (20 + dll_symname_len); if (asprintf (&oname, "%s_d%06d.o", dll_symname, tmp_seq) < 4)
sprintf (oname, "%s_d%06d.o", dll_symname, tmp_seq); /* In theory we should return NULL here at let our caller decide what to
do. But currently the return value is not checked, just used, and
besides, this condition only happens when the system has run out of
memory. So just give up. */
exit (EXIT_FAILURE);
tmp_seq++; tmp_seq++;
abfd = bfd_create (oname, parent); abfd = bfd_create (oname, parent);
@ -2173,8 +2177,12 @@ make_tail (bfd *parent)
char *oname; char *oname;
bfd *abfd; bfd *abfd;
oname = xmalloc (20 + dll_symname_len); if (asprintf (&oname, "%s_d%06d.o", dll_symname, tmp_seq) < 4)
sprintf (oname, "%s_d%06d.o", dll_symname, tmp_seq); /* In theory we should return NULL here at let our caller decide what to
do. But currently the return value is not checked, just used, and
besides, this condition only happens when the system has run out of
memory. So just give up. */
exit (EXIT_FAILURE);
tmp_seq++; tmp_seq++;
abfd = bfd_create (oname, parent); abfd = bfd_create (oname, parent);
@ -2324,8 +2332,12 @@ make_one (def_file_export *exp, bfd *parent, bool include_jmp_stub)
} }
} }
oname = xmalloc (20 + dll_symname_len); if (asprintf (&oname, "%s_d%06d.o", dll_symname, tmp_seq) < 4)
sprintf (oname, "%s_d%06d.o", dll_symname, tmp_seq); /* In theory we should return NULL here at let our caller decide what to
do. But currently the return value is not checked, just used, and
besides, this condition only happens when the system has run out of
memory. So just give up. */
exit (EXIT_FAILURE);
tmp_seq++; tmp_seq++;
abfd = bfd_create (oname, parent); abfd = bfd_create (oname, parent);
@ -2510,8 +2522,12 @@ make_singleton_name_thunk (const char *import, bfd *parent)
char *oname; char *oname;
bfd *abfd; bfd *abfd;
oname = xmalloc (20 + dll_symname_len); if (asprintf (&oname, "%s_nmth%06d.o", dll_symname, tmp_seq) < 4)
sprintf (oname, "%s_nmth%06d.o", dll_symname, tmp_seq); /* In theory we should return NULL here at let our caller decide what to
do. But currently the return value is not checked, just used, and
besides, this condition only happens when the system has run out of
memory. So just give up. */
exit (EXIT_FAILURE);
tmp_seq++; tmp_seq++;
abfd = bfd_create (oname, parent); abfd = bfd_create (oname, parent);
@ -2551,7 +2567,7 @@ make_import_fixup_mark (arelent *rel, char *name)
struct bfd_symbol *sym = *rel->sym_ptr_ptr; struct bfd_symbol *sym = *rel->sym_ptr_ptr;
bfd *abfd = bfd_asymbol_bfd (sym); bfd *abfd = bfd_asymbol_bfd (sym);
struct bfd_link_hash_entry *bh; struct bfd_link_hash_entry *bh;
char *fixup_name, buf[26]; char *fixup_name, buf[256];
size_t prefix_len; size_t prefix_len;
/* "name" buffer has space before the symbol name for prefixes. */ /* "name" buffer has space before the symbol name for prefixes. */
@ -2586,8 +2602,12 @@ make_import_fixup_entry (const char *name,
char *oname; char *oname;
bfd *abfd; bfd *abfd;
oname = xmalloc (20 + dll_symname_len); if (asprintf (&oname, "%s_fu%06d.o", dll_symname, tmp_seq) < 4)
sprintf (oname, "%s_fu%06d.o", dll_symname, tmp_seq); /* In theory we should return NULL here at let our caller decide what to
do. But currently the return value is not checked, just used, and
besides, this condition only happens when the system has run out of
memory. So just give up. */
exit (EXIT_FAILURE);
tmp_seq++; tmp_seq++;
abfd = bfd_create (oname, parent); abfd = bfd_create (oname, parent);
@ -2640,8 +2660,12 @@ make_runtime_pseudo_reloc (const char *name ATTRIBUTE_UNUSED,
bfd *abfd; bfd *abfd;
bfd_size_type size; bfd_size_type size;
oname = xmalloc (20 + dll_symname_len); if (asprintf (&oname, "%s_rtr%06d.o", dll_symname, tmp_seq) < 4)
sprintf (oname, "%s_rtr%06d.o", dll_symname, tmp_seq); /* In theory we should return NULL here at let our caller decide what to
do. But currently the return value is not checked, just used, and
besides, this condition only happens when the system has run out of
memory. So just give up. */
exit (EXIT_FAILURE);
tmp_seq++; tmp_seq++;
abfd = bfd_create (oname, parent); abfd = bfd_create (oname, parent);
@ -2727,8 +2751,12 @@ pe_create_runtime_relocator_reference (bfd *parent)
char *oname; char *oname;
bfd *abfd; bfd *abfd;
oname = xmalloc (20 + dll_symname_len); if (asprintf (&oname, "%s_ertr%06d.o", dll_symname, tmp_seq) < 4)
sprintf (oname, "%s_ertr%06d.o", dll_symname, tmp_seq); /* In theory we should return NULL here at let our caller decide what to
do. But currently the return value is not checked, just used, and
besides, this condition only happens when the system has run out of
memory. So just give up. */
exit (EXIT_FAILURE);
tmp_seq++; tmp_seq++;
abfd = bfd_create (oname, parent); abfd = bfd_create (oname, parent);