espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-20 09:58:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Delete parse_flags/parse_flags_qcs

Browse Source 
Now that "thread/frame apply" have been converted to the gdb::option
framework, these functions are no longer used.

For a while, I thought about keeping the unit tests, by making a local
version of parse_flags_qcs in the unit tests file.  But all that would
really test that is used by GDB itself, is the validate_flags_qcs
function.  So in the end, I went through all the unit tests, and
converted any that wasn't already covered to gdb.base/options.exp
tests.  And those have all already been added in previous patches.

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
	* cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
	* unittests/cli-utils-selftests.c (test_parse_flags)
	(test_parse_flags_qcs): Delete.
	(test_cli_utils): Don't call deleted functions.
This commit is contained in:
Pedro Alves
2019-06-13 00:06:54 +01:00
parent 6665660a41
commit 6206060d9b
4 changed files with 8 additions and 219 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
gdb/cli/cli-utils.h
View File

@ -220,15 +220,6 @@ check_for_argument (char **str, const char *arg)
return check_for_argument (str, arg, strlen (arg));
}
/* A helper function that looks for a set of flags at the start of a
string. The possible flags are given as a null terminated string.
A flag in STR must either be at the end of the string,
or be followed by whitespace.
Returns 0 if no valid flag is found at the start of STR.
Otherwise updates *STR, and returns N (which is > 0),
such that FLAGS [N - 1] is the valid found flag. */
extern int parse_flags (const char **str, const char *flags);
/* qcs_flags struct groups the -q, -c, and -s flags parsed by "thread
apply" and "frame apply" commands */
@ -239,27 +230,6 @@ struct qcs_flags
int silent = false;
};
/* A helper function that uses parse_flags to handle the flags qcs :
A flag -q sets FLAGS->QUIET to true.
A flag -c sets FLAGS->CONT to true.
A flag -s sets FLAGS->SILENT to true.
The caller is responsible to initialize *FLAGS to false before the (first)
call to parse_flags_qcs.
parse_flags_qcs can then be called iteratively to search for more
valid flags, as part of a 'main parsing loop' searching for -q/-c/-s
flags together with other flags and options.
Returns true and updates *STR and one of FLAGS->QUIET, FLAGS->CONT,
FLAGS->SILENT if it finds a valid flag.
Returns false if no valid flag is found at the beginning of STR.
Throws an error if a flag is found such that both FLAGS->CONT and
FLAGS->SILENT are true. */
extern bool parse_flags_qcs (const char *which_command, const char **str,
qcs_flags *flags);
/* Validate FLAGS. Throws an error if both FLAGS->CONT and
FLAGS->SILENT are true. WHICH_COMMAND is included in the error
message. */