espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-18 16:53:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

PR25236, common sym versioning

Browse Source 
In cases where a relocatable object file has a common symbol, no other
file has a definition, and there is a matching common symbol found in
a shared library then ld will output a definition using the largest of
size and alignment for the commons.  This patch fixes a bug in ld that
ignored common symbols when assigning versions, resulting in such
symbols being given VER_NDX_LOCAL versions.

	PR 25236
	* elflink.c (_bfd_elf_link_assign_sym_version): Assign versions
	for ELF_COMMON_DEF_P symbols.
	(elf_link_output_extsym, _bfd_elf_add_default_symbol): Adjust to
	suit.
This commit is contained in:
Alan Modra
2019-12-06 11:21:45 +10:30
parent 9231c9c2d4
commit 5fa370e437
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
bfd/ChangeLog
View File

@ -1,3 +1,11 @@
2019-12-07 Alan Modra <amodra@gmail.com>
PR 25236
* elflink.c (_bfd_elf_link_assign_sym_version): Assign versions
for ELF_COMMON_DEF_P symbols.
(elf_link_output_extsym, _bfd_elf_add_default_symbol): Adjust to
suit.
2019-12-05 Sandra Loosemore <sandra@codesourcery.com> 2019-12-05 Sandra Loosemore <sandra@codesourcery.com>
Only give FDE encoding warnings if --eh-frame-hdr was specified. Only give FDE encoding warnings if --eh-frame-hdr was specified.

6
bfd/elflink.c
View File

@ -1904,7 +1904,7 @@ _bfd_elf_add_default_symbol (bfd *abfd,
if (skip) if (skip)
goto nondefault; goto nondefault;
if (hi->def_regular) if (hi->def_regular || ELF_COMMON_DEF_P (hi))
{ {
/* If the undecorated symbol will have a version added by a /* If the undecorated symbol will have a version added by a
script different to H, then don't indirect to/from the script different to H, then don't indirect to/from the
@ -2367,7 +2367,7 @@ _bfd_elf_link_assign_sym_version (struct elf_link_hash_entry *h, void *data)
/* We only need version numbers for symbols defined in regular /* We only need version numbers for symbols defined in regular
objects. */ objects. */
if (!h->def_regular) if (!h->def_regular && !ELF_COMMON_DEF_P (h))
{ {
/* Hide symbols defined in discarded input sections. */ /* Hide symbols defined in discarded input sections. */
if ((h->root.type == bfd_link_hash_defined if ((h->root.type == bfd_link_hash_defined
@ -10246,7 +10246,7 @@ elf_link_output_extsym (struct bfd_hash_entry *bh, void *data)
Elf_Internal_Versym iversym; Elf_Internal_Versym iversym;
Elf_External_Versym *eversym; Elf_External_Versym *eversym;
if (!h->def_regular) if (!h->def_regular && !ELF_COMMON_DEF_P (h))
{ {
if (h->verinfo.verdef == NULL if (h->verinfo.verdef == NULL
|| (elf_dyn_lib_class (h->verinfo.verdef->vd_bfd) || (elf_dyn_lib_class (h->verinfo.verdef->vd_bfd)