espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-28 23:39:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove the_windows_nat_target global

Browse Source 
I belatedly realized that the "the_windows_nat_target" global isn't
really necessary.  It's only used in one place, where 'this' would be
simpler and clearer.  This patch removes the global entirely.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
This commit is contained in:
Tom Tromey
2022-11-30 08:51:09 -07:00
parent 77d2113f27
commit 5f8363d924
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
gdb/windows-nat.c
View File

@ -387,10 +387,6 @@ private:
bool m_is_async = false; bool m_is_async = false;
}; };
/* This is a pointer and not a global specifically to avoid a C++
"static initializer fiasco" situation. */
static windows_nat_target *the_windows_nat_target;
static void static void
check (BOOL ok, const char *file, int line) check (BOOL ok, const char *file, int line)
{ {
@ -629,7 +625,7 @@ windows_nat_target::delete_thread (ptid_t ptid, DWORD exit_code,
target_pid_to_str (ptid).c_str (), target_pid_to_str (ptid).c_str (),
(unsigned) exit_code); (unsigned) exit_code);
::delete_thread (find_thread_ptid (the_windows_nat_target, ptid)); ::delete_thread (find_thread_ptid (this, ptid));
auto iter = std::find_if (windows_process.thread_list.begin (), auto iter = std::find_if (windows_process.thread_list.begin (),
windows_process.thread_list.end (), windows_process.thread_list.end (),
@ -3126,8 +3122,9 @@ _initialize_windows_nat ()
calling x86_set_debug_register_length function calling x86_set_debug_register_length function
in processor windows specific native file. */ in processor windows specific native file. */
the_windows_nat_target = new windows_nat_target; /* The target is not a global specifically to avoid a C++ "static
add_inf_child_target (the_windows_nat_target); initializer fiasco" situation. */
add_inf_child_target (new windows_nat_target);
#ifdef __CYGWIN__ #ifdef __CYGWIN__
cygwin_internal (CW_SET_DOS_FILE_WARNING, 0); cygwin_internal (CW_SET_DOS_FILE_WARNING, 0);