espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-20 04:09:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb: fix 'remote show FOO-packet' aliases

Browse Source 
The following behaviour was observed in GDB:

  (gdb) show remote X-packet
  Support for the `p' packet is auto-detected, currently unknown.

Note the message mentions the 'p' packet.  This is a regression since
this commit:

  commit 8579fd136a614985bd27f20539c7bb7c5a51287d
  Date:   Mon Nov 8 14:58:46 2021 +0000

      gdb/gdbsupport: make xstrprintf and xstrvprintf return a unique_ptr

Before this commit the behaviour was:

  (gdb) show remote X-packet
  Support for the `X' packet is auto-detected, currently unknown.

The problem was caused by a failed attempt to ensure that some
allocated strings were deleted when GDB exits.  The code in the above
commit attempted to make use of 'static' to solve this problem,
however, the solution was just wrong.

In this new commit I instead allocate a static vector into which all
the allocated strings are stored, this ensures the strings are
released when GDB exits (which makes output from tools like valgrind
cleaner), but each string within the vector can be unique, which fixes
the regression.
This commit is contained in:
Andrew Burgess
2022-04-21 11:16:18 +01:00
parent ffaebc199e
commit 5f21c7aae2
2 changed files with 11 additions and 4 deletions
gdb
remote.c
testsuite/gdb.base
remote.exp

10
gdb/remote.c

@ -1968,15 +1968,17 @@ add_packet_config_cmd (struct packet_config *config, const char *name,
/* set/show remote NAME-packet {auto,on,off} -- legacy. */ /* set/show remote NAME-packet {auto,on,off} -- legacy. */
if (legacy) if (legacy)
{ {
/* It's not clear who should take ownership of this string, so, for /* It's not clear who should take ownership of the LEGACY_NAME string
now, make it static, and give copies to each of the add_alias_cmd created below, so, for now, place the string into a static vector
calls below. */ which ensures the strings is released when GDB exits. */
static gdb::unique_xmalloc_ptr<char> legacy_name static std::vector<gdb::unique_xmalloc_ptr<char>> legacy_names;
gdb::unique_xmalloc_ptr<char> legacy_name
= xstrprintf ("%s-packet", name); = xstrprintf ("%s-packet", name);
add_alias_cmd (legacy_name.get (), cmds.set, class_obscure, 0, add_alias_cmd (legacy_name.get (), cmds.set, class_obscure, 0,
&remote_set_cmdlist); &remote_set_cmdlist);
add_alias_cmd (legacy_name.get (), cmds.show, class_obscure, 0, add_alias_cmd (legacy_name.get (), cmds.show, class_obscure, 0,
&remote_show_cmdlist); &remote_show_cmdlist);
legacy_names.emplace_back (std::move (legacy_name));
} }
} }

5
gdb/testsuite/gdb.base/remote.exp

@ -195,4 +195,9 @@ gdb_test_no_output "set remote hardware-breakpoint-limit -1"
gdb_test_no_output "set remote hardware-watchpoint-limit 2147483647" gdb_test_no_output "set remote hardware-watchpoint-limit 2147483647"
gdb_test_no_output "set remote hardware-breakpoint-limit 2147483647" gdb_test_no_output "set remote hardware-breakpoint-limit 2147483647"
# Check the X/P/p alias commands display the correct packet names.
foreach pkt {X P p} {
gdb_test "show remote ${pkt}-packet" "Support for the `${pkt}' packet is.*"
}
gdb_exit gdb_exit