espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-10-16 04:13:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb: add type::num_fields / type::set_num_fields

Browse Source 
Add the `num_fields` and `set_num_fields` methods on `struct type`, in
order to remove the `TYPE_NFIELDS` macro.  In this patch, the
`TYPE_NFIELDS` macro is changed to use `type::num_fields`, so all the
call sites that are used to set the number of fields are changed to use
`type::set_num_fields`.  The next patch will remove `TYPE_NFIELDS`
completely.

I think that in the future, we should consider making the interface of
`struct type` better.  For example, right now it's possible for the
number of fields property and the actual number of fields set to be out
of sync.  However, I want to keep the existing behavior in this patch,
just translate from macros to methods.

gdb/ChangeLog:

	* gdbtypes.h (struct type) <num_fields, set_num_fields>: New
	methods.
	(TYPE_NFIELDS): Use type::num_fields.  Change all call sites
	that modify the number of fields to use type::set_num_fields
	instead.

Change-Id: I5ad9de5be4097feaf942d111077434bf91d13dc5
This commit is contained in:
Simon Marchi
2020-05-22 16:55:14 -04:00
parent 9392ebb3bb
commit 5e33d5f4e1
14 changed files with 62 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/rust-lang.c
View File

@ -984,7 +984,7 @@ rust_composite_type (struct type *original,
result->set_code (TYPE_CODE_STRUCT);
result->set_name (name);
TYPE_NFIELDS (result) = nfields;
result->set_num_fields (nfields);
TYPE_FIELDS (result)
= (struct field *) TYPE_ZALLOC (result, nfields * sizeof (struct field));