espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-22 19:09:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

Unify new_symbol and new_symbol_full

Browse Source 
This patch unifies new_symbol with new_symbol_full, replacing a
wrapper function with a default parameter.

2018-01-17  Tom Tromey  <tom@tromey.com>

	* dwarf2read.c (dwarf2_compute_name): Update comment.
	(read_func_scope, read_variable): Update.
	(new_symbol): Remove.
	(new_symbol_full): Rename to new_symbol.
This commit is contained in:
Tom Tromey
2018-01-05 17:26:16 -07:00
parent ee7f689e15
commit 5e2db402c8
2 changed files with 16 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2018-01-17 Tom Tromey <tom@tromey.com>
* dwarf2read.c (dwarf2_compute_name): Update comment.
(read_func_scope, read_variable): Update.
(new_symbol): Remove.
(new_symbol_full): Rename to new_symbol.
2018-01-17 Mike Gulick <mgulick@mathworks.com> 2018-01-17 Mike Gulick <mgulick@mathworks.com>
PR gdb/16577 PR gdb/16577

29
gdb/dwarf2read.c
View File

@ -1884,10 +1884,7 @@ static struct compunit_symtab *dwarf2_start_symtab (struct dwarf2_cu *,
CORE_ADDR); CORE_ADDR);
static struct symbol *new_symbol (struct die_info *, struct type *, static struct symbol *new_symbol (struct die_info *, struct type *,
struct dwarf2_cu *); struct dwarf2_cu *, struct symbol * = NULL);
static struct symbol *new_symbol_full (struct die_info *, struct type *,
struct dwarf2_cu *, struct symbol *);
static void dwarf2_const_value (const struct attribute *, struct symbol *, static void dwarf2_const_value (const struct attribute *, struct symbol *,
struct dwarf2_cu *); struct dwarf2_cu *);
@ -10940,7 +10937,7 @@ dwarf2_compute_name (const char *name,
but otherwise compute it by typename_concat inside GDB. but otherwise compute it by typename_concat inside GDB.
FIXME: Actually this is not really true, or at least not always true. FIXME: Actually this is not really true, or at least not always true.
It's all very confusing. SYMBOL_SET_NAMES doesn't try to demangle It's all very confusing. SYMBOL_SET_NAMES doesn't try to demangle
Fortran names because there is no mangling standard. So new_symbol_full Fortran names because there is no mangling standard. So new_symbol
will set the demangled name to the result of dwarf2_full_name, and it is will set the demangled name to the result of dwarf2_full_name, and it is
the demangled name that GDB uses if it exists. */ the demangled name that GDB uses if it exists. */
if (cu->language == language_ada if (cu->language == language_ada
@ -11213,8 +11210,8 @@ dwarf2_physname (const char *name, struct die_info *die, struct dwarf2_cu *cu)
if (cu->language == language_go) if (cu->language == language_go)
{ {
/* This is a lie, but we already lie to the caller new_symbol_full. /* This is a lie, but we already lie to the caller new_symbol.
new_symbol_full assumes we return the mangled name. new_symbol assumes we return the mangled name.
This just undoes that lie until things are cleaned up. */ This just undoes that lie until things are cleaned up. */
} }
else else
@ -13880,8 +13877,8 @@ read_func_scope (struct die_info *die, struct dwarf2_cu *cu)
} }
newobj = push_context (0, lowpc); newobj = push_context (0, lowpc);
newobj->name = new_symbol_full (die, read_type_die (die, cu), cu, newobj->name = new_symbol (die, read_type_die (die, cu), cu,
(struct symbol *) templ_func); (struct symbol *) templ_func);
/* If there is a location expression for DW_AT_frame_base, record /* If there is a location expression for DW_AT_frame_base, record
it. */ it. */
@ -14436,7 +14433,7 @@ read_variable (struct die_info *die, struct dwarf2_cu *cu)
} }
} }
new_symbol_full (die, NULL, cu, storage); new_symbol (die, NULL, cu, storage);
} }
/* Call CALLBACK from DW_AT_ranges attribute value OFFSET /* Call CALLBACK from DW_AT_ranges attribute value OFFSET
@ -21381,8 +21378,8 @@ var_decode_location (struct attribute *attr, struct symbol *sym,
NULL, allocate a new symbol on the objfile's obstack. */ NULL, allocate a new symbol on the objfile's obstack. */
static struct symbol * static struct symbol *
new_symbol_full (struct die_info *die, struct type *type, struct dwarf2_cu *cu, new_symbol (struct die_info *die, struct type *type, struct dwarf2_cu *cu,
struct symbol *space) struct symbol *space)
{ {
struct dwarf2_per_objfile *dwarf2_per_objfile struct dwarf2_per_objfile *dwarf2_per_objfile
= cu->per_cu->dwarf2_per_objfile; = cu->per_cu->dwarf2_per_objfile;
@ -21764,14 +21761,6 @@ new_symbol_full (struct die_info *die, struct type *type, struct dwarf2_cu *cu,
return (sym); return (sym);
} }
/* A wrapper for new_symbol_full that always allocates a new symbol. */
static struct symbol *
new_symbol (struct die_info *die, struct type *type, struct dwarf2_cu *cu)
{
return new_symbol_full (die, type, cu, NULL);
}
/* Given an attr with a DW_FORM_dataN value in host byte order, /* Given an attr with a DW_FORM_dataN value in host byte order,
zero-extend it as appropriate for the symbol's type. The DWARF zero-extend it as appropriate for the symbol's type. The DWARF
standard (v4) is not entirely clear about the meaning of using standard (v4) is not entirely clear about the meaning of using