espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-06 14:49:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Make xml_escape_text return an std::string

Browse Source 
This is a simple replacement, it allows removing some manual free'ing in
the callers.

gdb/ChangeLog:

	* common/buffer.c (buffer_xml_printf): Adjust.
	* common/xml-utils.c (xml_escape_text): Change return type to
	std::string, update code accordingly.
	* common/xml-utils.h (xml_escape_text): Change return type to
	std::string.
	* rs6000-aix-tdep.c (rs6000_aix_shared_library_to_xml): Adjust.
	* windows-tdep.c (windows_xfer_shared_library): Adjust.
	* unittests/xml-utils-selftests.c (test_xml_escape_text):
	Adjust.

gdb/gdbserver/ChangeLog:

	* linux-low.c (linux_qxfer_libraries_svr4): Adjust to change of
	return type of xml_escape_text.
	* server.c (emit_dll_description): Likewise.
This commit is contained in:
Simon Marchi
2017-09-16 14:19:31 +02:00
parent c3d7b541fa
commit 5e1875543d
10 changed files with 43 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gdb/rs6000-aix-tdep.c
View File

@ -908,20 +908,16 @@ static void
rs6000_aix_shared_library_to_xml (struct ld_info *ldi,
struct obstack *obstack)
{
char *p;
obstack_grow_str (obstack, "<library name=\"");
p = xml_escape_text (ldi->filename);
obstack_grow_str (obstack, p);
xfree (p);
std::string p = xml_escape_text (ldi->filename);
obstack_grow_str (obstack, p.c_str ());
obstack_grow_str (obstack, "\"");
if (ldi->member_name[0] != '\0')
{
obstack_grow_str (obstack, " member=\"");
p = xml_escape_text (ldi->member_name);
obstack_grow_str (obstack, p);
xfree (p);
obstack_grow_str (obstack, p.c_str ());
obstack_grow_str (obstack, "\"");
}