espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-22 19:09:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb/testsuite/dap: use gdb_assert in gdb.dap/basic-dap.exp

Browse Source 
Use gdb_assert instead of manual pass/fail.

Change-Id: I71fbc4e37a0a1ef4783056c7424e932651fa397f
This commit is contained in:
Simon Marchi
2023-01-06 10:07:21 -05:00
parent 2b304f501f
commit 5dd4f3585d
1 changed files with 3 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
gdb/testsuite/gdb.dap/basic-dap.exp
View File

@ -75,12 +75,7 @@ set obj [dap_check_request_and_response "reset breakpoint by line number" \
[format {o source [o path [%s]] breakpoints [a [o line [i %d]]]} \
[list s $srcfile] $line]]
set new_line_bpno [dap_get_breakpoint_number $obj]
if {$new_line_bpno == $line_bpno} {
pass "re-setting kept same breakpoint number"
} else {
fail "re-setting kept same breakpoint number"
}
gdb_assert {$new_line_bpno == $line_bpno} "re-setting kept same breakpoint number"
# This uses "&address_breakpoint_here" as the address -- this is a
# hack because we know how this is implemented under the hood.
@ -131,21 +126,13 @@ dap_match_values "global value in main" [lindex $obj 0] \
set obj [dap_request_and_response "evaluate non-existing variable" \
evaluate {o expression [s nosuchvariable]}]
set d [namespace eval ton::2dict [lindex $obj 0]]
if {[dict get $d success] == "false"} {
pass "result of invalid request"
} else {
fail "result of invalid request"
}
gdb_assert { [dict get $d success] == "false" } "result of invalid request"
set obj [dap_check_request_and_response "disassemble one instruction" \
disassemble \
[format {o memoryReference [s %s] instructionCount [i 1]} \
$insn_pc]]
set d [namespace eval ton::2dict [lindex $obj 0]]
if {[dict exists $d body instructions]} {
pass "instructions in disassemble output"
} else {
fail "instructions in disassemble output"
}
gdb_assert { [dict exists $d body instructions] } "instructions in disassemble output"
dap_shutdown