espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-03 13:23:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add new internal problem for demangler warnings

Browse Source 
This commit adds a new category of internal problem for demangler
warnings.  Demangler warnings behave in much the same way as internal
warnings except that they do not create core files and no option to
change this is presented to the user.

gdb/
2014-06-19  Gary Benson  <gbenson@redhat.com>

	* utils.h (demangler_vwarning): New declaration.
	(demangler_warning): Likewise.
	* utils.c (struct internal_problem)
	<user_settable_should_quit>: New field.
	<user_settable_should_dump_core>: Likewise
	(internal_error_problem): Add values for above new fields.
	(internal_warning_problem): Likewise.
	(demangler_warning_problem): New static global.
	(demangler_vwarning): New function.
	(demangler_warning): Likewise.
	(add_internal_problem_command): Selectively add commands.
	(_initialize_utils): New internal problem command.
	* maint.c (maintenance_demangler_warning): New function.
	(_initialize_maint_cmds): New command.

gdb/doc/
2014-06-19  Gary Benson  <gbenson@redhat.com>

	* gdb.texinfo (Maintenance Commands): Document new
	"maint demangler-warning" command and new
	"maint set/show demangler-warning" option.
This commit is contained in:
Gary Benson
2014-06-19 09:10:44 +01:00
parent 45371d0cee
commit 57fcfb1b20
6 changed files with 132 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
gdb/ChangeLog
View File

@ -1,3 +1,20 @@
2014-06-19 Gary Benson <gbenson@redhat.com>
* utils.h (demangler_vwarning): New declaration.
(demangler_warning): Likewise.
* utils.c (struct internal_problem)
<user_settable_should_quit>: New field.
<user_settable_should_dump_core>: Likewise
(internal_error_problem): Add values for above new fields.
(internal_warning_problem): Likewise.
(demangler_warning_problem): New static global.
(demangler_vwarning): New function.
(demangler_warning): Likewise.
(add_internal_problem_command): Selectively add commands.
(_initialize_utils): New internal problem command.
* maint.c (maintenance_demangler_warning): New function.
(_initialize_maint_cmds): New command.
2014-06-18 Tom Tromey <tromey@redhat.com>
* f-valprint.c (info_common_command_for_block): Update.

6
gdb/doc/ChangeLog
View File

@ -1,3 +1,9 @@
2014-06-19 Gary Benson <gbenson@redhat.com>
* gdb.texinfo (Maintenance Commands): Document new
"maint demangler-warning" command and new
"maint set/show demangler-warning" option.
2014-06-09 Siva Chandra Reddy <sivachandra@google.com>
* python.texi (Xmethod API): Add space before the opening

25
gdb/doc/gdb.texinfo
View File

@ -33268,13 +33268,18 @@ with the @code{SIGQUIT} signal.
@kindex maint internal-error
@kindex maint internal-warning
@kindex maint demangler-warning
@cindex demangler crashes
@item maint internal-error @r{[}@var{message-text}@r{]}
@itemx maint internal-warning @r{[}@var{message-text}@r{]}
Cause @value{GDBN} to call the internal function @code{internal_error}
or @code{internal_warning} and hence behave as though an internal error
or internal warning has been detected. In addition to reporting the
internal problem, these functions give the user the opportunity to
either quit @value{GDBN} or create a core file of the current
@itemx maint demangler-warning @r{[}@var{message-text}@r{]}
Cause @value{GDBN} to call the internal function @code{internal_error},
@code{internal_warning} or @code{demangler_warning} and hence behave
as though an internal problam has been detected. In addition to
reporting the internal problem, these functions give the user the
opportunity to either quit @value{GDBN} or (for @code{internal_error}
and @code{internal_warning}) create a core file of the current
@value{GDBN} session.
These commands take an optional parameter @var{message-text} that is
@ -33294,15 +33299,20 @@ Create a core file? (y or n) @kbd{n}
@cindex @value{GDBN} internal error
@cindex internal errors, control of @value{GDBN} behavior
@cindex demangler crashes
@kindex maint set internal-error
@kindex maint show internal-error
@kindex maint set internal-warning
@kindex maint show internal-warning
@kindex maint set demangler-warning
@kindex maint show demangler-warning
@item maint set internal-error @var{action} [ask|yes|no]
@itemx maint show internal-error @var{action}
@itemx maint set internal-warning @var{action} [ask|yes|no]
@itemx maint show internal-warning @var{action}
@itemx maint set demangler-warning @var{action} [ask|yes|no]
@itemx maint show demangler-warning @var{action}
When @value{GDBN} reports an internal problem (error or warning) it
gives the user the opportunity to both quit @value{GDBN} and create a
core file of the current @value{GDBN} session. These commands let you
@ -33316,7 +33326,10 @@ quit. The default is to ask the user what to do.
@item corefile
You can specify that @value{GDBN} should always (yes) or never (no)
create a core file. The default is to ask the user what to do.
create a core file. The default is to ask the user what to do. Note
that there is no @code{corefile} option for @code{demangler-warning}:
demangler warnings always create a core file and this cannot be
disabled.
@end table
@kindex maint packet

15
gdb/maint.c
View File

@ -131,6 +131,15 @@ maintenance_internal_warning (char *args, int from_tty)
internal_warning (__FILE__, __LINE__, "%s", (args == NULL ? "" : args));
}
/* Stimulate the internal error mechanism that GDB uses when an
demangler problem is detected. Allows testing of the mechanism. */
static void
maintenance_demangler_warning (char *args, int from_tty)
{
demangler_warning (__FILE__, __LINE__, "%s", (args == NULL ? "" : args));
}
/* Someday we should allow demangling for things other than just
explicit strings. For example, we might want to be able to specify
the address of a string in either GDB's process space or the
@ -1055,6 +1064,12 @@ Give GDB an internal warning.\n\
Cause GDB to behave as if an internal warning was reported."),
&maintenancelist);
add_cmd ("demangler-warning", class_maintenance,
maintenance_demangler_warning, _("\
Give GDB a demangler warning.\n\
Cause GDB to behave as if a demangler warning was reported."),
&maintenancelist);
add_cmd ("demangle", class_maintenance, maintenance_demangle, _("\
Demangle a C++/ObjC mangled name.\n\
Call internal GDB demangler routine to demangle a C++ link name\n\

33
gdb/utils.c
View File

@ -659,7 +659,9 @@ static const char *const internal_problem_modes[] =
struct internal_problem
{
const char *name;
int user_settable_should_quit;
const char *should_quit;
int user_settable_should_dump_core;
const char *should_dump_core;
};
@ -794,7 +796,7 @@ internal_vproblem (struct internal_problem *problem,
}
static struct internal_problem internal_error_problem = {
"internal-error", internal_problem_ask, internal_problem_ask
"internal-error", 1, internal_problem_ask, 1, internal_problem_ask
};
void
@ -815,7 +817,7 @@ internal_error (const char *file, int line, const char *string, ...)
}
static struct internal_problem internal_warning_problem = {
"internal-warning", internal_problem_ask, internal_problem_ask
"internal-warning", 1, internal_problem_ask, 1, internal_problem_ask
};
void
@ -834,6 +836,26 @@ internal_warning (const char *file, int line, const char *string, ...)
va_end (ap);
}
static struct internal_problem demangler_warning_problem = {
"demangler-warning", 1, internal_problem_ask, 0, internal_problem_no
};
void
demangler_vwarning (const char *file, int line, const char *fmt, va_list ap)
{
internal_vproblem (&demangler_warning_problem, file, line, fmt, ap);
}
void
demangler_warning (const char *file, int line, const char *string, ...)
{
va_list ap;
va_start (ap, string);
demangler_vwarning (file, line, string, ap);
va_end (ap);
}
/* Dummy functions to keep add_prefix_cmd happy. */
static void
@ -894,6 +916,8 @@ add_internal_problem_command (struct internal_problem *problem)
(char *) NULL),
0/*allow-unknown*/, &maintenance_show_cmdlist);
if (problem->user_settable_should_quit)
{
set_doc = xstrprintf (_("Set whether GDB should quit "
"when an %s is detected"),
problem->name);
@ -913,7 +937,10 @@ add_internal_problem_command (struct internal_problem *problem)
xfree (set_doc);
xfree (show_doc);
}
if (problem->user_settable_should_dump_core)
{
set_doc = xstrprintf (_("Set whether GDB should create a core "
"file of GDB when %s is detected"),
problem->name);
@ -934,6 +961,7 @@ add_internal_problem_command (struct internal_problem *problem)
xfree (set_doc);
xfree (show_doc);
}
}
/* Return a newly allocated string, containing the PREFIX followed
by the system error message for errno (separated by a colon).
@ -3529,4 +3557,5 @@ _initialize_utils (void)
{
add_internal_problem_command (&internal_error_problem);
add_internal_problem_command (&internal_warning_problem);
add_internal_problem_command (&demangler_warning_problem);
}

8
gdb/utils.h
View File

@ -311,6 +311,14 @@ extern void internal_warning (const char *file, int line,
extern void warning (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
extern void vwarning (const char *, va_list args) ATTRIBUTE_PRINTF (1, 0);
extern void demangler_vwarning (const char *file, int line,
const char *, va_list ap)
ATTRIBUTE_PRINTF (3, 0);
extern void demangler_warning (const char *file, int line,
const char *, ...) ATTRIBUTE_PRINTF (3, 4);
/* Misc. utilities. */