target_ops: Use bool throughout

After the previous target_ops/C++ patches are all squashed and merged,
this one can go in separately.

This patch adjusts all the target methods to return bool instead of int
when they're returning a boolean.

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* target.h (target_ops)
	<stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
	stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
	stopped_by_watchpoint, have_continuable_watchpoint,
	stopped_data_address, watchpoint_addr_within_range,
	can_accel_watchpoint_condition, can_run, thread_alive,
	has_all_memory, has_memory, has_stack, has_registers,
	has_execution, can_async_p, is_async_p, supports_non_stop,
	always_non_stop_p, can_execute_reverse, supports_multi_process,
	supports_enable_disable_tracepoint,
	supports_disable_randomization, supports_string_tracing,
	supports_evaluation_of_breakpoint_conditions,
	can_run_breakpoint_commands, filesystem_is_local,
	can_download_tracepoint, get_trace_state_variable_value,
	set_trace_notes, get_tib_address, use_agent, can_use_agent,
	record_is_replaying, record_will_replay,
	augmented_libraries_svr4_read>: Adjust to return bool.
	* aarch64-linux-nat.c: All implementations adjusted.
	* aix-thread.c: All implementations adjusted.
	* arm-linux-nat.c: All implementations adjusted.
	* breakpoint.c: All implementations adjusted.
	* bsd-kvm.c: All implementations adjusted.
	* bsd-uthread.c: All implementations adjusted.
	* corelow.c: All implementations adjusted.
	* ctf.c: All implementations adjusted.
	* darwin-nat.c: All implementations adjusted.
	* darwin-nat.h: All implementations adjusted.
	* exec.c: All implementations adjusted.
	* fbsd-nat.c: All implementations adjusted.
	* fbsd-nat.h: All implementations adjusted.
	* gnu-nat.c: All implementations adjusted.
	* gnu-nat.h: All implementations adjusted.
	* go32-nat.c: All implementations adjusted.
	* ia64-linux-nat.c: All implementations adjusted.
	* inf-child.c: All implementations adjusted.
	* inf-child.h: All implementations adjusted.
	* inf-ptrace.c: All implementations adjusted.
	* inf-ptrace.h: All implementations adjusted.
	* linux-nat.c: All implementations adjusted.
	* linux-nat.h: All implementations adjusted.
	* mips-linux-nat.c: All implementations adjusted.
	* nto-procfs.c: All implementations adjusted.
	* ppc-linux-nat.c: All implementations adjusted.
	* procfs.c: All implementations adjusted.
	* ravenscar-thread.c: All implementations adjusted.
	* record-btrace.c: All implementations adjusted.
	* record-full.c: All implementations adjusted.
	* remote-sim.c: All implementations adjusted.
	* remote.c: All implementations adjusted.
	* s390-linux-nat.c: All implementations adjusted.
	* sol-thread.c: All implementations adjusted.
	* spu-multiarch.c: All implementations adjusted.
	* target-delegates.c: All implementations adjusted.
	* target.c: All implementations adjusted.
	* target.h: All implementations adjusted.
	* tracefile-tfile.c: All implementations adjusted.
	* tracefile.c: All implementations adjusted.
	* tracefile.h: All implementations adjusted.
	* windows-nat.c: All implementations adjusted.
	* x86-linux-nat.h: All implementations adjusted.
	* x86-nat.h: All implementations adjusted.
This commit is contained in:
Pedro Alves
2018-05-03 00:37:26 +01:00
parent ad6a4e2dd6
commit 57810aa7e8
47 changed files with 772 additions and 708 deletions

View File

@ -2474,7 +2474,7 @@ check_stopped_by_watchpoint (struct lwp_info *lp)
/* Returns true if the LWP had stopped for a watchpoint. */
int
bool
linux_nat_target::stopped_by_watchpoint ()
{
struct lwp_info *lp = find_lwp_pid (inferior_ptid);
@ -2484,7 +2484,7 @@ linux_nat_target::stopped_by_watchpoint ()
return lp->stop_reason == TARGET_STOPPED_BY_WATCHPOINT;
}
int
bool
linux_nat_target::stopped_data_address (CORE_ADDR *addr_p)
{
struct lwp_info *lp = find_lwp_pid (inferior_ptid);
@ -2835,7 +2835,7 @@ save_stop_reason (struct lwp_info *lp)
/* Returns true if the LWP had stopped for a software breakpoint. */
int
bool
linux_nat_target::stopped_by_sw_breakpoint ()
{
struct lwp_info *lp = find_lwp_pid (inferior_ptid);
@ -2847,7 +2847,7 @@ linux_nat_target::stopped_by_sw_breakpoint ()
/* Implement the supports_stopped_by_sw_breakpoint method. */
int
bool
linux_nat_target::supports_stopped_by_sw_breakpoint ()
{
return USE_SIGTRAP_SIGINFO;
@ -2856,7 +2856,7 @@ linux_nat_target::supports_stopped_by_sw_breakpoint ()
/* Returns true if the LWP had stopped for a hardware
breakpoint/watchpoint. */
int
bool
linux_nat_target::stopped_by_hw_breakpoint ()
{
struct lwp_info *lp = find_lwp_pid (inferior_ptid);
@ -2868,7 +2868,7 @@ linux_nat_target::stopped_by_hw_breakpoint ()
/* Implement the supports_stopped_by_hw_breakpoint method. */
int
bool
linux_nat_target::supports_stopped_by_hw_breakpoint ()
{
return USE_SIGTRAP_SIGINFO;
@ -3940,7 +3940,7 @@ linux_nat_target::xfer_partial (enum target_object object,
offset, len, xfered_len);
}
int
bool
linux_nat_target::thread_alive (ptid_t ptid)
{
/* As long as a PTID is in lwp list, consider it alive. */
@ -4322,7 +4322,7 @@ linux_nat_target::static_tracepoint_markers_by_strid (const char *strid)
/* target_is_async_p implementation. */
int
bool
linux_nat_target::is_async_p ()
{
return linux_is_async_p ();
@ -4330,7 +4330,7 @@ linux_nat_target::is_async_p ()
/* target_can_async_p implementation. */
int
bool
linux_nat_target::can_async_p ()
{
/* We're always async, unless the user explicitly prevented it with the
@ -4338,7 +4338,7 @@ linux_nat_target::can_async_p ()
return target_async_permitted;
}
int
bool
linux_nat_target::supports_non_stop ()
{
return 1;
@ -4346,7 +4346,7 @@ linux_nat_target::supports_non_stop ()
/* to_always_non_stop_p implementation. */
int
bool
linux_nat_target::always_non_stop_p ()
{
return 1;
@ -4357,13 +4357,13 @@ linux_nat_target::always_non_stop_p ()
int linux_multi_process = 1;
int
bool
linux_nat_target::supports_multi_process ()
{
return linux_multi_process;
}
int
bool
linux_nat_target::supports_disable_randomization ()
{
#ifdef HAVE_PERSONALITY
@ -4574,13 +4574,13 @@ linux_nat_target::core_of_thread (ptid_t ptid)
/* Implementation of to_filesystem_is_local. */
int
bool
linux_nat_target::filesystem_is_local ()
{
struct inferior *inf = current_inferior ();
if (inf->fake_pid_p || inf->pid == 0)
return 1;
return true;
return linux_ns_same (inf->pid, LINUX_NS_MNT);
}