mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-08-06 14:49:38 +08:00
gdb: Have allocate_target_description return a unique_ptr
Update allocate_target_description to return a target_desc_up, a specialisation of unique_ptr. This commit does not attempt to make use of the unique_ptr in the best possible way, in almost all cases we immediately release the pointer from within the unique_ptr and then continue as before. There are a few places where it was easy to handle the unique_ptr, and in these cases I've done that. Everything under gdb/features/* is auto-regenerated. There should be no user visible changes after this commit. gdb/ChangeLog: * arch/aarch32.c (aarch32_create_target_description): Release unique_ptr returned from allocate_target_description. * arch/aarch64.c (aarch64_create_target_description): Likewise. * arch/amd64.c (amd64_create_target_description): Likewise. * arch/arc.c (arc_create_target_description): Likewise. * arch/arm.c (arm_create_target_description): Likewise. * arch/i386.c (i386_create_target_description): Likewise. * arch/riscv.c (riscv_create_target_description): Update return type. Handle allocate_target_description returning a unique_ptr. (riscv_lookup_target_description): Update to handle unique_ptr. * arch/tic6x.c (tic6x_create_target_description): Release unique_ptr returned from allocate_target_description. * features/microblaze-with-stack-protect.c: Regenerate. * features/microblaze.c: Regenerate. * features/mips-dsp-linux.c: Regenerate. * features/mips-linux.c: Regenerate. * features/mips64-dsp-linux.c: Regenerate. * features/mips64-linux.c: Regenerate. * features/nds32.c: Regenerate. * features/nios2.c: Regenerate. * features/or1k.c: Regenerate. * features/rs6000/powerpc-32.c: Regenerate. * features/rs6000/powerpc-32l.c: Regenerate. * features/rs6000/powerpc-403.c: Regenerate. * features/rs6000/powerpc-403gc.c: Regenerate. * features/rs6000/powerpc-405.c: Regenerate. * features/rs6000/powerpc-505.c: Regenerate. * features/rs6000/powerpc-601.c: Regenerate. * features/rs6000/powerpc-602.c: Regenerate. * features/rs6000/powerpc-603.c: Regenerate. * features/rs6000/powerpc-604.c: Regenerate. * features/rs6000/powerpc-64.c: Regenerate. * features/rs6000/powerpc-64l.c: Regenerate. * features/rs6000/powerpc-7400.c: Regenerate. * features/rs6000/powerpc-750.c: Regenerate. * features/rs6000/powerpc-860.c: Regenerate. * features/rs6000/powerpc-altivec32.c: Regenerate. * features/rs6000/powerpc-altivec32l.c: Regenerate. * features/rs6000/powerpc-altivec64.c: Regenerate. * features/rs6000/powerpc-altivec64l.c: Regenerate. * features/rs6000/powerpc-e500.c: Regenerate. * features/rs6000/powerpc-e500l.c: Regenerate. * features/rs6000/powerpc-isa205-32l.c: Regenerate. * features/rs6000/powerpc-isa205-64l.c: Regenerate. * features/rs6000/powerpc-isa205-altivec32l.c: Regenerate. * features/rs6000/powerpc-isa205-altivec64l.c: Regenerate. * features/rs6000/powerpc-isa205-ppr-dscr-vsx32l.c: Regenerate. * features/rs6000/powerpc-isa205-ppr-dscr-vsx64l.c: Regenerate. * features/rs6000/powerpc-isa205-vsx32l.c: Regenerate. * features/rs6000/powerpc-isa205-vsx64l.c: Regenerate. * features/rs6000/powerpc-isa207-htm-vsx32l.c: Regenerate. * features/rs6000/powerpc-isa207-htm-vsx64l.c: Regenerate. * features/rs6000/powerpc-isa207-vsx32l.c: Regenerate. * features/rs6000/powerpc-isa207-vsx64l.c: Regenerate. * features/rs6000/powerpc-vsx32.c: Regenerate. * features/rs6000/powerpc-vsx32l.c: Regenerate. * features/rs6000/powerpc-vsx64.c: Regenerate. * features/rs6000/powerpc-vsx64l.c: Regenerate. * features/rs6000/rs6000.c: Regenerate. * features/rx.c: Regenerate. * features/s390-gs-linux64.c: Regenerate. * features/s390-linux32.c: Regenerate. * features/s390-linux32v1.c: Regenerate. * features/s390-linux32v2.c: Regenerate. * features/s390-linux64.c: Regenerate. * features/s390-linux64v1.c: Regenerate. * features/s390-linux64v2.c: Regenerate. * features/s390-te-linux64.c: Regenerate. * features/s390-tevx-linux64.c: Regenerate. * features/s390-vx-linux64.c: Regenerate. * features/s390x-gs-linux64.c: Regenerate. * features/s390x-linux64.c: Regenerate. * features/s390x-linux64v1.c: Regenerate. * features/s390x-linux64v2.c: Regenerate. * features/s390x-te-linux64.c: Regenerate. * features/s390x-tevx-linux64.c: Regenerate. * features/s390x-vx-linux64.c: Regenerate. * mips-tdep.c (_initialize_mips_tdep): Release unique_ptr returned from allocate_target_description. * target-descriptions.c (allocate_target_description): Update return type. (print_c_tdesc::visit_pre): Release unique_ptr returned from allocate_target_description. gdbserver/ChangeLog: * linux-low.cc (linux_process_target::handle_extended_wait): Release the unique_ptr returned from allocate_target_description. * linux-riscv-low.cc (riscv_target::low_arch_setup): Likewise. * linux-x86-low.cc (tdesc_amd64_linux_no_xml): Change type. (tdesc_i386_linux_no_xml): Change type. (x86_linux_read_description): Borrow pointer from unique_ptr object. (x86_target::get_ipa_tdesc_idx): Likewise. (initialize_low_arch): Likewise. * tdesc.cc (allocate_target_description): Update return type. gdbsupport/ChangeLog: * tdesc.h (allocate_target_description): Update return type.
This commit is contained in:
Andrew Burgess
@ -1,3 +1,16 @@
|
||||
2020-10-08 Andrew Burgess <andrew.burgess@embecosm.com>
|
||||
|
||||
* linux-low.cc (linux_process_target::handle_extended_wait):
|
||||
Release the unique_ptr returned from allocate_target_description.
|
||||
* linux-riscv-low.cc (riscv_target::low_arch_setup): Likewise.
|
||||
* linux-x86-low.cc (tdesc_amd64_linux_no_xml): Change type.
|
||||
(tdesc_i386_linux_no_xml): Change type.
|
||||
(x86_linux_read_description): Borrow pointer from unique_ptr
|
||||
object.
|
||||
(x86_target::get_ipa_tdesc_idx): Likewise.
|
||||
(initialize_low_arch): Likewise.
|
||||
* tdesc.cc (allocate_target_description): Update return type.
|
||||
|
||||
2020-10-07 Tom Tromey <tromey@adacore.com>
|
||||
|
||||
* server.cc (handle_search_memory): Remove dead code.
|
||||
|
||||
@ -497,7 +497,6 @@ linux_process_target::handle_extended_wait (lwp_info **orig_event_lwp,
|
||||
struct process_info *child_proc;
|
||||
struct lwp_info *child_lwp;
|
||||
struct thread_info *child_thr;
|
||||
struct target_desc *tdesc;
|
||||
|
||||
ptid = ptid_t (new_pid, new_pid, 0);
|
||||
|
||||
@ -553,9 +552,9 @@ linux_process_target::handle_extended_wait (lwp_info **orig_event_lwp,
|
||||
|
||||
clone_all_breakpoints (child_thr, event_thr);
|
||||
|
||||
tdesc = allocate_target_description ();
|
||||
copy_target_description (tdesc, parent_proc->tdesc);
|
||||
child_proc->tdesc = tdesc;
|
||||
target_desc_up tdesc = allocate_target_description ();
|
||||
copy_target_description (tdesc.get (), parent_proc->tdesc);
|
||||
child_proc->tdesc = tdesc.release ();
|
||||
|
||||
/* Clone arch-specific process data. */
|
||||
low_new_fork (parent_proc, child_proc);
|
||||
|
||||
@ -88,11 +88,11 @@ riscv_target::low_arch_setup ()
|
||||
|
||||
const riscv_gdbarch_features features
|
||||
= riscv_linux_read_features (lwpid_of (current_thread));
|
||||
target_desc *tdesc = riscv_create_target_description (features);
|
||||
target_desc_up tdesc = riscv_create_target_description (features);
|
||||
|
||||
if (!tdesc->expedite_regs)
|
||||
init_target_desc (tdesc, expedite_regs);
|
||||
current_process ()->tdesc = tdesc;
|
||||
init_target_desc (tdesc.get (), expedite_regs);
|
||||
current_process ()->tdesc = tdesc.release ();
|
||||
}
|
||||
|
||||
/* Collect GPRs from REGCACHE into BUF. */
|
||||
|
||||
@ -48,9 +48,9 @@
|
||||
#include "linux-x86-tdesc.h"
|
||||
|
||||
#ifdef __x86_64__
|
||||
static struct target_desc *tdesc_amd64_linux_no_xml;
|
||||
static target_desc_up tdesc_amd64_linux_no_xml;
|
||||
#endif
|
||||
static struct target_desc *tdesc_i386_linux_no_xml;
|
||||
static target_desc_up tdesc_i386_linux_no_xml;
|
||||
|
||||
|
||||
static unsigned char jump_insn[] = { 0xe9, 0, 0, 0, 0 };
|
||||
@ -899,10 +899,10 @@ x86_linux_read_description (void)
|
||||
/* Don't use XML. */
|
||||
#ifdef __x86_64__
|
||||
if (machine == EM_X86_64)
|
||||
return tdesc_amd64_linux_no_xml;
|
||||
return tdesc_amd64_linux_no_xml.get ();
|
||||
else
|
||||
#endif
|
||||
return tdesc_i386_linux_no_xml;
|
||||
return tdesc_i386_linux_no_xml.get ();
|
||||
}
|
||||
|
||||
if (have_ptrace_getregset == -1)
|
||||
@ -2955,7 +2955,7 @@ x86_target::get_ipa_tdesc_idx ()
|
||||
return amd64_get_ipa_tdesc_idx (tdesc);
|
||||
#endif
|
||||
|
||||
if (tdesc == tdesc_i386_linux_no_xml)
|
||||
if (tdesc == tdesc_i386_linux_no_xml.get ())
|
||||
return X86_TDESC_SSE;
|
||||
|
||||
return i386_get_ipa_tdesc_idx (tdesc);
|
||||
@ -2971,14 +2971,14 @@ initialize_low_arch (void)
|
||||
/* Initialize the Linux target descriptions. */
|
||||
#ifdef __x86_64__
|
||||
tdesc_amd64_linux_no_xml = allocate_target_description ();
|
||||
copy_target_description (tdesc_amd64_linux_no_xml,
|
||||
copy_target_description (tdesc_amd64_linux_no_xml.get (),
|
||||
amd64_linux_read_description (X86_XSTATE_SSE_MASK,
|
||||
false));
|
||||
tdesc_amd64_linux_no_xml->xmltarget = xmltarget_amd64_linux_no_xml;
|
||||
#endif
|
||||
|
||||
tdesc_i386_linux_no_xml = allocate_target_description ();
|
||||
copy_target_description (tdesc_i386_linux_no_xml,
|
||||
copy_target_description (tdesc_i386_linux_no_xml.get (),
|
||||
i386_linux_read_description (X86_XSTATE_SSE_MASK));
|
||||
tdesc_i386_linux_no_xml->xmltarget = xmltarget_i386_linux_no_xml;
|
||||
|
||||
|
||||
@ -95,10 +95,10 @@ init_target_desc (struct target_desc *tdesc,
|
||||
|
||||
/* See gdbsupport/tdesc.h. */
|
||||
|
||||
struct target_desc *
|
||||
target_desc_up
|
||||
allocate_target_description (void)
|
||||
{
|
||||
return new target_desc ();
|
||||
return target_desc_up (new target_desc ());
|
||||
}
|
||||
|
||||
/* See gdbsupport/tdesc.h. */
|
||||
|
||||
Reference in New Issue
Block a user