espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-17 07:53:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Ensure all DAP requests are keyword-only

Browse Source 
Python functions implementing DAP requests should not use positional
parameters -- it only makes sense to call them with keyword arguments.
This patch changes the few remaining cases to start with the special
"*" parameter, following this rule.
This commit is contained in:
Tom Tromey
2023-02-10 11:59:03 -07:00
parent 71bb560755
commit 5036bde964
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/python/lib/gdb/dap/breakpoint.py
View File

@ -1,4 +1,4 @@
# Copyright 2022 Free Software Foundation, Inc.
# Copyright 2022, 2023 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@ -85,7 +85,7 @@ def _set_breakpoints(kind, specs):
@request("setBreakpoints")
def set_breakpoint(source, *, breakpoints=[], **args):
def set_breakpoint(*, source, breakpoints=[], **args):
if "path" not in source:
result = []
else:
@ -108,7 +108,7 @@ def set_breakpoint(source, *, breakpoints=[], **args):
@request("setFunctionBreakpoints")
@capability("supportsFunctionBreakpoints")
def set_fn_breakpoint(breakpoints, **args):
def set_fn_breakpoint(*, breakpoints, **args):
specs = []
for bp in breakpoints:
specs.append(

4
gdb/python/lib/gdb/dap/evaluate.py
View File

@ -1,4 +1,4 @@
# Copyright 2022 Free Software Foundation, Inc.
# Copyright 2022, 2023 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@ -33,7 +33,7 @@ def _evaluate(expr, frame_id):
# FIXME return a structured response using pretty-printers / varobj
# FIXME supportsVariableType handling
@request("evaluate")
def eval_request(expression, *, frameId=None, **args):
def eval_request(*, expression, frameId=None, **args):
result = send_gdb_with_response(lambda: _evaluate(expression, frameId))
return {
"result": result,