espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-24 04:00:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

* elf32-hppa.c (elf32_hppa_relocate_section): Don't allow

Browse Source 
undefined millicode syms in shared libs.
	(hppa_build_one_stub): Turn BFD_ASSERTs into aborts.
	(elf32_hppa_check_relocs): Likewise.
	(elf32_hppa_adjust_dynamic_symbol): Likewise.
	(elf32_hppa_size_dynamic_sections): Likewise.
	(elf32_hppa_relocate_section): Likewise.
	(elf32_hppa_finish_dynamic_symbol): Likewise.
	(elf32_hppa_finish_dynamic_sections): Likewise.
This commit is contained in:
Alan Modra
2001-05-25 03:46:49 +00:00
parent ce34c3732a
commit 49e9d0d3b6
2 changed files with 45 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
bfd/ChangeLog
View File

@ -1,3 +1,15 @@
2001-05-25 Alan Modra <amodra@one.net.au>
* elf32-hppa.c (elf32_hppa_relocate_section): Don't allow
undefined millicode syms in shared libs.
(hppa_build_one_stub): Turn BFD_ASSERTs into aborts.
(elf32_hppa_check_relocs): Likewise.
(elf32_hppa_adjust_dynamic_symbol): Likewise.
(elf32_hppa_size_dynamic_sections): Likewise.
(elf32_hppa_relocate_section): Likewise.
(elf32_hppa_finish_dynamic_symbol): Likewise.
(elf32_hppa_finish_dynamic_sections): Likewise.
2001-05-24 Tom Rix <trix@redhat.com> 2001-05-24 Tom Rix <trix@redhat.com>
* Makefile.am coff-pmac bfd now defined in coff-rs6000.c * Makefile.am coff-pmac bfd now defined in coff-rs6000.c

54
bfd/elf32-hppa.c
View File

@ -938,7 +938,8 @@ hppa_build_one_stub (gen_entry, in_arg)
case hppa_stub_import: case hppa_stub_import:
case hppa_stub_import_shared: case hppa_stub_import_shared:
BFD_ASSERT (stub_entry->h->elf.plt.offset < (bfd_vma) -2); if (stub_entry->h->elf.plt.offset >= (bfd_vma) -2)
abort ();
sym_value = (stub_entry->h->elf.plt.offset sym_value = (stub_entry->h->elf.plt.offset
+ hplink->splt->output_offset + hplink->splt->output_offset
+ hplink->splt->output_section->vma + hplink->splt->output_section->vma
@ -998,8 +999,9 @@ hppa_build_one_stub (gen_entry, in_arg)
dynobj = hplink->root.dynobj; dynobj = hplink->root.dynobj;
eh = (struct elf32_hppa_link_hash_entry *) stub_entry->h; eh = (struct elf32_hppa_link_hash_entry *) stub_entry->h;
BFD_ASSERT (eh->elf.root.type == bfd_link_hash_defined if (eh->elf.root.type != bfd_link_hash_defined
|| eh->elf.root.type == bfd_link_hash_defweak); && eh->elf.root.type != bfd_link_hash_defweak)
abort ();
value = (eh->elf.root.u.def.value value = (eh->elf.root.u.def.value
+ eh->elf.root.u.def.section->output_offset + eh->elf.root.u.def.section->output_offset
@ -1289,7 +1291,8 @@ elf32_hppa_check_relocs (abfd, info, sec, relocs)
case R_PARISC_PLABEL21L: case R_PARISC_PLABEL21L:
case R_PARISC_PLABEL32: case R_PARISC_PLABEL32:
/* If the addend is non-zero, we break badly. */ /* If the addend is non-zero, we break badly. */
BFD_ASSERT (rel->r_addend == 0); if (rel->r_addend != 0)
abort ();
/* If we are creating a shared library, then we need to /* If we are creating a shared library, then we need to
create a PLT entry for all PLABELs, because PLABELs with create a PLT entry for all PLABELs, because PLABELs with
@ -1968,8 +1971,9 @@ elf32_hppa_adjust_dynamic_symbol (info, h)
real definition first, and we can just use the same value. */ real definition first, and we can just use the same value. */
if (h->weakdef != NULL) if (h->weakdef != NULL)
{ {
BFD_ASSERT (h->weakdef->root.type == bfd_link_hash_defined if (h->weakdef->root.type != bfd_link_hash_defined
|| h->weakdef->root.type == bfd_link_hash_defweak); && h->weakdef->root.type != bfd_link_hash_defweak)
abort ();
h->root.u.def.section = h->weakdef->root.u.def.section; h->root.u.def.section = h->weakdef->root.u.def.section;
h->root.u.def.value = h->weakdef->root.u.def.value; h->root.u.def.value = h->weakdef->root.u.def.value;
return true; return true;
@ -2173,7 +2177,8 @@ elf32_hppa_size_dynamic_sections (output_bfd, info)
hplink = hppa_link_hash_table (info); hplink = hppa_link_hash_table (info);
dynobj = hplink->root.dynobj; dynobj = hplink->root.dynobj;
BFD_ASSERT (dynobj != NULL); if (dynobj == NULL)
abort ();
if (hplink->root.dynamic_sections_created) if (hplink->root.dynamic_sections_created)
{ {
@ -2183,7 +2188,8 @@ elf32_hppa_size_dynamic_sections (output_bfd, info)
if (! info->shared) if (! info->shared)
{ {
s = bfd_get_section_by_name (dynobj, ".interp"); s = bfd_get_section_by_name (dynobj, ".interp");
BFD_ASSERT (s != NULL); if (s == NULL)
abort ();
s->_raw_size = sizeof ELF_DYNAMIC_INTERPRETER; s->_raw_size = sizeof ELF_DYNAMIC_INTERPRETER;
s->contents = (unsigned char *) ELF_DYNAMIC_INTERPRETER; s->contents = (unsigned char *) ELF_DYNAMIC_INTERPRETER;
} }
@ -3590,7 +3596,8 @@ elf32_hppa_relocate_section (output_bfd, info, input_bfd, input_section,
else if (h->elf.root.type == bfd_link_hash_undefweak) else if (h->elf.root.type == bfd_link_hash_undefweak)
; ;
else if (info->shared && !info->no_undefined else if (info->shared && !info->no_undefined
&& ELF_ST_VISIBILITY (h->elf.other) == STV_DEFAULT) && ELF_ST_VISIBILITY (h->elf.other) == STV_DEFAULT
&& h->elf.type != STT_PARISC_MILLI)
{ {
if (info->symbolic) if (info->symbolic)
if (!((*info->callbacks->undefined_symbol) if (!((*info->callbacks->undefined_symbol)
@ -3623,7 +3630,8 @@ elf32_hppa_relocate_section (output_bfd, info, input_bfd, input_section,
bfd_vma off; bfd_vma off;
off = h->elf.got.offset; off = h->elf.got.offset;
BFD_ASSERT (off != (bfd_vma) -1); if (off == (bfd_vma) -1)
abort ();
if (! hplink->root.dynamic_sections_created if (! hplink->root.dynamic_sections_created
|| (info->shared || (info->shared
@ -3660,10 +3668,9 @@ elf32_hppa_relocate_section (output_bfd, info, input_bfd, input_section,
/* Local symbol case. */ /* Local symbol case. */
bfd_vma off; bfd_vma off;
BFD_ASSERT (local_got_offsets != NULL if (local_got_offsets == NULL
&& local_got_offsets[r_symndx] != (bfd_vma) -1); || (off = local_got_offsets[r_symndx]) == (bfd_vma) -1)
abort ();
off = local_got_offsets[r_symndx];
/* The offset must always be a multiple of 4. We use /* The offset must always be a multiple of 4. We use
the least significant bit to record whether we have the least significant bit to record whether we have
@ -3773,7 +3780,8 @@ elf32_hppa_relocate_section (output_bfd, info, input_bfd, input_section,
} }
} }
BFD_ASSERT (off < (bfd_vma) -2); if (off >= (bfd_vma) -2)
abort ();
/* PLABELs contain function pointers. Relocation is to /* PLABELs contain function pointers. Relocation is to
the entry for the function in the .plt. The magic +2 the entry for the function in the .plt. The magic +2
@ -3840,7 +3848,8 @@ elf32_hppa_relocate_section (output_bfd, info, input_bfd, input_section,
if (name == NULL) if (name == NULL)
return false; return false;
sreloc = bfd_get_section_by_name (dynobj, name); sreloc = bfd_get_section_by_name (dynobj, name);
BFD_ASSERT (sreloc != NULL); if (sreloc == NULL)
abort ();
} }
outrel.r_offset = rel->r_offset; outrel.r_offset = rel->r_offset;
@ -4112,7 +4121,8 @@ elf32_hppa_finish_dynamic_symbol (output_bfd, info, h, sym)
} }
else else
{ {
BFD_ASSERT((h->got.offset & 1) == 0); if ((h->got.offset & 1) != 0)
abort ();
bfd_put_32 (output_bfd, (bfd_vma) 0, bfd_put_32 (output_bfd, (bfd_vma) 0,
hplink->sgot->contents + h->got.offset); hplink->sgot->contents + h->got.offset);
rel.r_info = ELF32_R_INFO (h->dynindx, R_PARISC_DIR32); rel.r_info = ELF32_R_INFO (h->dynindx, R_PARISC_DIR32);
@ -4133,9 +4143,10 @@ elf32_hppa_finish_dynamic_symbol (output_bfd, info, h, sym)
/* This symbol needs a copy reloc. Set it up. */ /* This symbol needs a copy reloc. Set it up. */
BFD_ASSERT (h->dynindx != -1 if (! (h->dynindx != -1
&& (h->root.type == bfd_link_hash_defined && (h->root.type == bfd_link_hash_defined
|| h->root.type == bfd_link_hash_defweak)); || h->root.type == bfd_link_hash_defweak)))
abort ();
s = hplink->srelbss; s = hplink->srelbss;
@ -4181,7 +4192,8 @@ elf32_hppa_finish_dynamic_sections (output_bfd, info)
{ {
Elf32_External_Dyn *dyncon, *dynconend; Elf32_External_Dyn *dyncon, *dynconend;
BFD_ASSERT (sdyn != NULL); if (sdyn == NULL)
abort ();
dyncon = (Elf32_External_Dyn *) sdyn->contents; dyncon = (Elf32_External_Dyn *) sdyn->contents;
dynconend = (Elf32_External_Dyn *) (sdyn->contents + sdyn->_raw_size); dynconend = (Elf32_External_Dyn *) (sdyn->contents + sdyn->_raw_size);