[gdb/record] Support recording of getrandom

Add missing support for recording of linux syscall getrandom.

Tested on x86_64-linux with native and target board unix/-m32.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=22081
This commit is contained in:
Tom de Vries
2022-07-12 15:15:19 +02:00
parent 3f6227c2f4
commit 43f074cde4
10 changed files with 116 additions and 1 deletions

View File

@ -1159,6 +1159,7 @@ enum aarch64_syscall {
aarch64_sys_finit_module = 273,
aarch64_sys_sched_setattr = 274,
aarch64_sys_sched_getattr = 275,
aarch64_sys_getrandom = 278
};
/* aarch64_canonicalize_syscall maps syscall ids from the native AArch64
@ -1441,6 +1442,7 @@ aarch64_canonicalize_syscall (enum aarch64_syscall syscall_number)
UNSUPPORTED_SYSCALL_MAP (finit_module);
UNSUPPORTED_SYSCALL_MAP (sched_setattr);
UNSUPPORTED_SYSCALL_MAP (sched_getattr);
SYSCALL_MAP (getrandom);
default:
return gdb_sys_no_syscall;
}

View File

@ -463,6 +463,9 @@ amd64_canonicalize_syscall (enum amd64_syscall syscall_number)
case amd64_sys_pipe2:
return gdb_sys_pipe2;
case amd64_sys_getrandom:
return gdb_sys_getrandom;
case amd64_sys_select:
case amd64_x32_sys_select:
return gdb_sys_select;

View File

@ -320,7 +320,8 @@ enum amd64_syscall {
amd64_sys_sync_file_range = 277,
amd64_sys_vmsplice = 278,
amd64_sys_move_pages = 279,
amd64_sys_pipe2 = 293
amd64_sys_pipe2 = 293,
amd64_sys_getrandom = 318
};
/* Enum that defines the syscall identifiers for x32 linux.

View File

@ -1610,6 +1610,7 @@ arm_canonicalize_syscall (int syscall)
case 378: return gdb_sys_kcmp;
case 379: return gdb_sys_finit_module;
*/
case 384: return gdb_sys_getrandom;
case 983041: /* ARM_breakpoint */ return gdb_sys_no_syscall;
case 983042: /* ARM_cacheflush */ return gdb_sys_no_syscall;
case 983043: /* ARM_usr26 */ return gdb_sys_no_syscall;

View File

@ -356,6 +356,12 @@ record_linux_system_call (enum gdb_syscall syscall,
return -1;
break;
case gdb_sys_getrandom:
regcache_raw_read_unsigned (regcache, tdep->arg2, &tmpulongest);
if (record_mem_at_reg (regcache, tdep->arg1, tmpulongest))
return -1;
break;
case gdb_sys_times:
if (record_mem_at_reg (regcache, tdep->arg1, tdep->size_tms))
return -1;

View File

@ -510,6 +510,7 @@ enum gdb_syscall {
gdb_sys_dup3 = 330,
gdb_sys_pipe2 = 331,
gdb_sys_inotify_init1 = 332,
gdb_sys_getrandom = 355,
gdb_sys_statx = 383,
gdb_sys_socket = 500,
gdb_sys_connect = 501,

View File

@ -1406,6 +1406,8 @@ ppc_canonicalize_syscall (int syscall, int wordsize)
result = gdb_sys_recvfrom;
else if (syscall == 342)
result = gdb_sys_recvmsg;
else if (syscall == 359)
result = gdb_sys_getrandom;
return (enum gdb_syscall) result;
}

View File

@ -787,6 +787,8 @@ s390_canonicalize_syscall (int syscall, enum s390_abi_kind abi)
/* ioprio_set .. epoll_pwait */
else if (syscall >= 282 && syscall <= 312)
ret = syscall + 7;
else if (syscall == 349)
ret = gdb_sys_getrandom;
else
ret = gdb_sys_no_syscall;

View File

@ -0,0 +1,41 @@
/* This testcase is part of GDB, the GNU debugger.
Copyright 2022 Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <sys/random.h>
void
marker1 (void)
{
}
void
marker2 (void)
{
}
unsigned char buf[6];
int
main (void)
{
buf[0] = 0xff;
buf[5] = 0xff;
marker1 ();
volatile ssize_t r = getrandom (&buf[1], 4, 0);
marker2 ();
return 0;
}

View File

@ -0,0 +1,56 @@
# Copyright 2022 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# This file is part of the gdb testsuite.
#
# This test tests getrandom syscall for reverse execution.
#
if ![supports_reverse] {
return
}
standard_testfile
if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
return -1
}
runto_main
if [supports_process_record] {
# Activate process record/replay
gdb_test_no_output "record" "turn on process record"
}
gdb_test "break marker2" \
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
"set breakpoint at marker2"
gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
gdb_test "break marker1" \
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
"set breakpoint at marker1"
gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
gdb_test "print (unsigned)buf\[0\]" ".* = 255" "check buf\[0\]"
gdb_test "print (unsigned)buf\[1\]" ".* = 0" "check buf\[1\]"
gdb_test "print (unsigned)buf\[2\]" ".* = 0" "check buf\[2\]"
gdb_test "print (unsigned)buf\[3\]" ".* = 0" "check buf\[3\]"
gdb_test "print (unsigned)buf\[4\]" ".* = 0" "check buf\[4\]"
gdb_test "print (unsigned)buf\[5\]" ".* = 255" "check buf\[5\]"