espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-09-28 18:03:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb/m68hc11: Use default gdbarch methods where possible

Browse Source 
Make use of the default gdbarch methods for gdbarch_unwind_pc, and
gdbarch_unwind_sp where possible.

I have not tested this change but, by inspecting the code, I believe
the default methods are equivalent to the code being deleted.

gdb/ChangeLog:

	* m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
	(m68hc11_unwind_sp): Delete.
	(m68hc11_gdbarch_init): Don't register deleted functions with
	gdbarch.
This commit is contained in:
Andrew Burgess
2019-01-10 18:33:50 +00:00
parent 5e79b7bb69
commit 43cf3eded2
2 changed files with 7 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/ChangeLog
View File

@ -1,3 +1,10 @@
2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
* m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
(m68hc11_unwind_sp): Delete.
(m68hc11_gdbarch_init): Don't register deleted functions with
gdbarch.
2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com> 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
* m32r-tdep.c (m32r_unwind_sp): Delete. * m32r-tdep.c (m32r_unwind_sp): Delete.

24
gdb/m68hc11-tdep.c
View File

@ -757,16 +757,6 @@ m68hc11_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc)
return pc; return pc;
} }
static CORE_ADDR
m68hc11_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame)
{
ULONGEST pc;
pc = frame_unwind_register_unsigned (next_frame,
gdbarch_pc_regnum (gdbarch));
return pc;
}
/* Put here the code to store, into fi->saved_regs, the addresses of /* Put here the code to store, into fi->saved_regs, the addresses of
the saved registers of frame described by FRAME_INFO. This the saved registers of frame described by FRAME_INFO. This
includes special registers such as pc and fp saved in special ways includes special registers such as pc and fp saved in special ways
@ -974,14 +964,6 @@ static const struct frame_base m68hc11_frame_base = {
m68hc11_frame_args_address m68hc11_frame_args_address
}; };
static CORE_ADDR
m68hc11_unwind_sp (struct gdbarch *gdbarch, struct frame_info *next_frame)
{
ULONGEST sp;
sp = frame_unwind_register_unsigned (next_frame, HARD_SP_REGNUM);
return sp;
}
/* Assuming THIS_FRAME is a dummy, return the frame ID of that dummy /* Assuming THIS_FRAME is a dummy, return the frame ID of that dummy
frame. The frame ID's base needs to match the TOS value saved by frame. The frame ID's base needs to match the TOS value saved by
save_dummy_frame_tos(), and the PC match the dummy frame's breakpoint. */ save_dummy_frame_tos(), and the PC match the dummy frame's breakpoint. */
@ -1487,9 +1469,6 @@ m68hc11_gdbarch_init (struct gdbarch_info info,
/* Characters are unsigned. */ /* Characters are unsigned. */
set_gdbarch_char_signed (gdbarch, 0); set_gdbarch_char_signed (gdbarch, 0);
set_gdbarch_unwind_pc (gdbarch, m68hc11_unwind_pc);
set_gdbarch_unwind_sp (gdbarch, m68hc11_unwind_sp);
/* Set register info. */ /* Set register info. */
set_gdbarch_fp0_regnum (gdbarch, -1); set_gdbarch_fp0_regnum (gdbarch, -1);
@ -1524,9 +1503,6 @@ m68hc11_gdbarch_init (struct gdbarch_info info,
PUSH_DUMMY_CALL, and saved by generic_save_dummy_frame_tos. */ PUSH_DUMMY_CALL, and saved by generic_save_dummy_frame_tos. */
set_gdbarch_dummy_id (gdbarch, m68hc11_dummy_id); set_gdbarch_dummy_id (gdbarch, m68hc11_dummy_id);
/* Return the unwound PC value. */
set_gdbarch_unwind_pc (gdbarch, m68hc11_unwind_pc);
/* Minsymbol frobbing. */ /* Minsymbol frobbing. */
set_gdbarch_elf_make_msymbol_special (gdbarch, set_gdbarch_elf_make_msymbol_special (gdbarch,
m68hc11_elf_make_msymbol_special); m68hc11_elf_make_msymbol_special);