Rename to allow_hw_watchpoint_access_tests

This changes skip_hw_watchpoint_access_tests to invert the sense, and
renames it to allow_hw_watchpoint_access_tests.
This commit is contained in:
Tom Tromey
2023-01-08 10:55:43 -07:00
parent b63724b8c2
commit 435d58376a
8 changed files with 12 additions and 12 deletions

View File

@ -184,7 +184,7 @@ foreach_with_prefix pie { "nopie" "pie" } {
test_break $always_inserted "watch" test_break $always_inserted "watch"
} }
if {![skip_hw_watchpoint_access_tests] if {[allow_hw_watchpoint_access_tests]
&& ![skip_hw_watchpoint_multi_tests]} { && ![skip_hw_watchpoint_multi_tests]} {
test_break $always_inserted "rwatch" test_break $always_inserted "rwatch"
test_break $always_inserted "awatch" test_break $always_inserted "awatch"

View File

@ -18,7 +18,7 @@
# followed by a catchpoint hit. # followed by a catchpoint hit.
# This test uses "awatch". # This test uses "awatch".
require !skip_hw_watchpoint_access_tests require allow_hw_watchpoint_access_tests
standard_testfile standard_testfile

View File

@ -24,7 +24,7 @@
standard_testfile .c standard_testfile .c
require !skip_hw_watchpoint_access_tests require allow_hw_watchpoint_access_tests
if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } {
return -1 return -1

View File

@ -23,7 +23,7 @@
# so the test is only meaningful on a system with hardware watchpoints. # so the test is only meaningful on a system with hardware watchpoints.
# More specifically, the implementation of this test uses access # More specifically, the implementation of this test uses access
# watchpoints, so skip it when those are not available. # watchpoints, so skip it when those are not available.
require !skip_hw_watchpoint_access_tests require allow_hw_watchpoint_access_tests
standard_testfile .c standard_testfile .c

View File

@ -13,7 +13,7 @@
# You should have received a copy of the GNU General Public License # You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>. # along with this program. If not, see <http://www.gnu.org/licenses/>.
require !skip_hw_watchpoint_access_tests require allow_hw_watchpoint_access_tests
set test watchpoint-hw-hit-once set test watchpoint-hw-hit-once
set srcfile ${test}.c set srcfile ${test}.c

View File

@ -22,7 +22,7 @@ require !use_gdb_stub
# Do not use simple hardware watchpoints ("watch") as its false hit may be # Do not use simple hardware watchpoints ("watch") as its false hit may be
# unnoticed by GDB if it reads it still has the same value. # unnoticed by GDB if it reads it still has the same value.
require !skip_hw_watchpoint_access_tests require allow_hw_watchpoint_access_tests
if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { if { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
untested "failed to compile" untested "failed to compile"

View File

@ -25,7 +25,7 @@
# could be assigned during continuation of a thread with pending SIGTRAP to the # could be assigned during continuation of a thread with pending SIGTRAP to the
# different/new watchpoint, just based on the watchpoint/debug register number. # different/new watchpoint, just based on the watchpoint/debug register number.
require !skip_hw_watchpoint_access_tests !skip_hw_watchpoint_multi_tests require allow_hw_watchpoint_access_tests !skip_hw_watchpoint_multi_tests
if {![istarget *-*-linux*]} { if {![istarget *-*-linux*]} {
return 0 return 0
} }

View File

@ -4081,19 +4081,19 @@ proc skip_hw_watchpoint_multi_tests {} {
return 0 return 0
} }
# Return a 1 if we should skip tests that require read/access watchpoints # Return a 1 if we should run tests that require read/access watchpoints
proc skip_hw_watchpoint_access_tests {} { proc allow_hw_watchpoint_access_tests {} {
if { [skip_hw_watchpoint_tests] } { if { [skip_hw_watchpoint_tests] } {
return 1 return 0
} }
# These targets support just write watchpoints # These targets support just write watchpoints
if { [istarget "s390*-*-*"] } { if { [istarget "s390*-*-*"] } {
return 1 return 0
} }
return 0 return 1
} }
# Return 1 if we should skip tests that require the runtime unwinder # Return 1 if we should skip tests that require the runtime unwinder