mirror of
https://github.com/espressif/binutils-gdb.git
synced 2025-06-20 09:58:19 +08:00
Eliminate the two-level data structures behind location_specs
Currently, there's the location_spec hierarchy, and then some location_spec subclasses have their own struct type holding all their data fields. I.e., there is this: location_spec explicit_location_spec linespec_location_spec address_location_spec probe_location_spec and then these separate types: explicit_location linespec_location where: explicit_location_spec has-a explicit_location linespec_location_spec has-a linespec_location This patch eliminates explicit_location and linespec_location, inlining their members in the corresponding location_spec type. The location_spec subclasses were the ones currently defined in location.c, so they are moved to the header. Since the definitions of the classes are now visible, we no longer need location_spec_deleter. Some constructors that are used for cloning location_specs, like: explicit explicit_location_spec (const struct explicit_location *loc) ... were converted to proper copy ctors. In the process, initialize_explicit_location is eliminated, and some functions that returned the "data type behind a locspec", like get_linespec_location are converted to downcast functions, like as_linespec_location_spec. Change-Id: Ia31ccef9382b25a52b00fa878c8df9b8cf2a6c5a
This commit is contained in:
@ -123,7 +123,7 @@ parse_probes (const location_spec *locspec,
|
||||
const char *arg_start, *cs;
|
||||
|
||||
gdb_assert (location_spec_type (locspec) == PROBE_LOCATION_SPEC);
|
||||
arg_start = get_probe_location_spec_string (locspec);
|
||||
arg_start = locspec->to_string ();
|
||||
|
||||
cs = arg_start;
|
||||
const static_probe_ops *spops = probe_linespec_to_static_ops (&cs);
|
||||
|
Reference in New Issue
Block a user