espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-30 17:31:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb.reverse/time-reverse.exp: test both time syscall and C time function

Browse Source 
Instead of only testing this on systems that have a SYS_time syscall,
test it everywhere using the time(2) C function, and in addition, run
the tests again using the SYS_time syscall.

The C variant ensures that if some platform uses some syscall we are
not aware of yet, we'll still exercise it, and likely fail, at which
point we should teach GDB about the syscall.

The explicit syscall variant is useful on platforms where the C
function does not call a syscall at all by default, e.g., on some
systems the C time function wraps an implementation provided by the
vDSO.

Approved-By: Tom de Vries <tdevries@suse.de>
Change-Id: Id4b755d76577d02c46b8acbfa249d9c31b587633
This commit is contained in:
Pedro Alves
2023-02-22 15:40:58 +00:00
parent ba25141c1e
commit 4097906672
2 changed files with 61 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/testsuite/gdb.reverse/time-reverse.c
View File

@ -20,6 +20,12 @@
#include <sys/syscall.h>
#include <unistd.h>
#ifdef USE_SYSCALL
# define my_time(TLOC) syscall (SYS_time, TLOC)
#else
# define my_time(TLOC) time (TLOC)
#endif
void
marker1 (void)
{
@ -36,7 +42,7 @@ int
main (void)
{
marker1 ();
syscall (SYS_time, &time_global);
my_time (&time_global);
marker2 ();
return 0;
}

79
gdb/testsuite/gdb.reverse/time-reverse.exp
View File

@ -23,33 +23,62 @@ require supports_reverse
standard_testfile
require {expr [have_syscall time]}
# MODE is either "syscall" for testing the time syscall explicitly, or
# "c" for testing the C time(2) function.
proc test {mode} {
set options {debug}
if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
return -1
if {$mode == "syscall"} {
lappend options additional_flags=-DUSE_SYSCALL
} elseif {$mode != "c"} {
error "unrecognized mode: $mode"
}
if { [prepare_for_testing "failed to prepare" $::testfile-$mode $::srcfile $options] } {
return
}
runto_main
if [supports_process_record] {
# Activate process record/replay
gdb_test_no_output "record" "turn on process record"
}
gdb_test "break marker2" \
"Breakpoint $::decimal at $::hex: file .*$::srcfile, line $::decimal.*" \
"set breakpoint at marker2"
gdb_continue_to_breakpoint "marker2" ".*$::srcfile:.*"
gdb_test "break marker1" \
"Breakpoint $::decimal at $::hex: file .*$::srcfile, line $::decimal.*" \
"set breakpoint at marker1"
gdb_test "reverse-continue" ".*$::srcfile:$::decimal.*" "reverse to marker1"
# If the variable was recorded properly, the old contents (-1)
# will be remembered. If not, new contents (current time) will be
# used, and the test will fail.
gdb_test "print time_global" ".* = -1" "check time record"
}
runto_main
# Test both using the syscall explicitly, and using the time(2) C
# function.
#
# The C variant ensures that if some platform uses some syscall we are
# not aware of yet, we'll still exercise it (and likely fail).
#
# The explicit syscall variant is useful on platforms where the C
# function does not call a syscall at all by default, e.g., on some
# systems the C time function wraps an implementation provided by the
# vDSO.
if [supports_process_record] {
# Activate process record/replay
gdb_test_no_output "record" "turn on process record"
foreach_with_prefix mode {syscall c} {
if {$mode == "syscall" && ![have_syscall time]} {
continue
}
test $mode
}
gdb_test "break marker2" \
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
"set breakpoint at marker2"
gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
gdb_test "break marker1" \
"Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
"set breakpoint at marker1"
gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
# If the variable was recorded properly on syscall, the old contents (-1)
# will be remembered. If not, new contents (current time) will be used,
# and the test will fail.
gdb_test "print time_global" ".* = -1" "check time record"