espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-08-06 14:49:38 +08:00
Code Issues Packages Projects Releases Wiki Activity

Eliminate target_ops::to_xclose

Browse Source 
In the multi-target branch, I found no need for the target_close vs
target_xclose distinction.  Heap-allocated targets simply delete
themselves in their target_close implementation, while
singleton/static targets don't.

The target_ops C++ification patches will add more commentary around
target_ops's destructor, but there's no destructor yet...

gdb/ChangeLog:
2018-05-02  Pedro Alves  <palves@redhat.com>

	* bfd-target.c (target_bfd_xclose): Rename to ...
	(target_bfd_close): ... this.
	(target_bfd_reopen): Adjust.
	* target.c (target_close): Remove references to to_xclose.
	* target.h (target_ops::to_xclose): Delete.
	(target_ops::to_close): Update comments.
This commit is contained in:
Pedro Alves
2018-05-03 00:37:09 +01:00
parent 6798487f5b
commit 3fffc0701a
4 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/bfd-target.c
View File

@ -68,7 +68,7 @@ target_bfd_get_section_table (struct target_ops *ops)
}
static void
target_bfd_xclose (struct target_ops *t)
target_bfd_close (struct target_ops *t)
{
struct target_bfd_data *data = (struct target_bfd_data *) t->to_data;
@ -95,7 +95,7 @@ target_bfd_reopen (struct bfd *abfd)
t->to_doc = _("You should never see this");
t->to_get_section_table = target_bfd_get_section_table;
t->to_xfer_partial = target_bfd_xfer_partial;
t->to_xclose = target_bfd_xclose;
t->to_close = target_bfd_close;
t->to_data = data;
t->to_magic = OPS_MAGIC;