espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-20 01:50:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove some null checks

Browse Source 
When not parsing for completion, parse_expression ensures that the
resulting expression has operations.  This patch removes a couple of
unnecessary checks for this situation.

gdb/ChangeLog
2021-03-08  Tom Tromey  <tom@tromey.com>

	* printcmd.c (set_command): Remove null check.
	* value.c (init_if_undefined_command): Remove null check.
This commit is contained in:
Tom Tromey
2021-03-08 07:27:57 -07:00
parent 9c79936b3d
commit 3dd93bf837
3 changed files with 20 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2021-03-08 Tom Tromey <tom@tromey.com>
* printcmd.c (set_command): Remove null check.
* value.c (init_if_undefined_command): Remove null check.
2021-03-08 Tom Tromey <tom@tromey.com> 2021-03-08 Tom Tromey <tom@tromey.com>
* parse.c (parser_state::push_symbol, parser_state::push_dollar): * parse.c (parser_state::push_symbol, parser_state::push_dollar):

1
gdb/printcmd.c
View File

@ -1375,7 +1375,6 @@ set_command (const char *exp, int from_tty)
{ {
expression_up expr = parse_expression (exp); expression_up expr = parse_expression (exp);
if (expr->op != nullptr)
switch (expr->op->opcode ()) switch (expr->op->opcode ())
{ {
case UNOP_PREINCREMENT: case UNOP_PREINCREMENT:

2
gdb/value.c
View File

@ -2015,7 +2015,7 @@ init_if_undefined_command (const char* args, int from_tty)
/* Validate the expression. /* Validate the expression.
Was the expression an assignment? Was the expression an assignment?
Or even an expression at all? */ Or even an expression at all? */
if (expr->op == nullptr || expr->first_opcode () != BINOP_ASSIGN) if (expr->first_opcode () != BINOP_ASSIGN)
error (_("Init-if-undefined requires an assignment expression.")); error (_("Init-if-undefined requires an assignment expression."));
/* Extract the variable from the parsed expression. */ /* Extract the variable from the parsed expression. */