gdb.base/setshow.exp: split in procs

Split in multiple procs, one per topic, and start with a fresh GDB in
each.  I find it easier to work on a test with multiple smaller
independent test procedures.  For example, it's possible to comment all
but one when working on one.  It's also easier to add things without
having to think about the impact on existing tests, and vice-versa.

Change-Id: I19691eed8f9bcb975b2eeff7577cac66251bcbe2
This commit is contained in:
Simon Marchi
2021-07-06 13:52:17 -04:00
parent ffb6ba773e
commit 3b3c74341e

View File

@ -15,6 +15,10 @@
# This file was written by Michael Snyder (msnyder@cygnus.com)
# Test gdb set and show commands. The goal here is to verify that parameters
# are set and shown correctly, not test whether setting the parameter has the
# desired effect.
standard_testfile .c
@ -23,37 +27,27 @@ if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile} executable {debug}]
return -1
}
proc_with_prefix test_setshow_annotate {} {
# Start with a fresh gdb
clean_restart $::binfile
clean_restart ${binfile}
# make sure $pc is sane, in case we're talking to a board.
if ![runto_main] then {
fail "can't run to main"
return 0
return
}
#
# Test gdb set and show commands.
# Add tests here for show and set that don't fit neatly elsewhere.
# FIXME: many rudimentary tests for set and show commands have been
# added below, but most do nothing more than check that a
# variable has been set successfully, ie. they do not test
# whether setting the variable has had the desired effect.
#
#test default annotation_level is 0
gdb_test "show annotate" "Annotation_level is 0..*" "default annotation_level is zero"
#test set annotate 2
# Here we need to fiddle with prompts.
save_vars { gdb_prompt } {
set old_gdb_prompt $gdb_prompt
set gdb_prompt "\r\n\032\032pre-prompt\r\n$gdb_prompt \r\n\032\032prompt\r\n"
save_vars { ::gdb_prompt } {
set old_gdb_prompt $::gdb_prompt
set ::gdb_prompt "\r\n\032\032pre-prompt\r\n$::gdb_prompt \r\n\032\032prompt\r\n"
gdb_test_multiple "set annotate 2" "set annotate 2" {
-re "\r\n$gdb_prompt$" {
-re "\r\n$::gdb_prompt$" {
pass "set annotate 2"
}
}
@ -82,6 +76,15 @@ gdb_test_no_output "set annotate 0" "set annotate 0"
gdb_test "show annotate" "Annotation_level is 0..*" "show annotate (0)"
#test annotation_level 0
gdb_test "info line 1" "Line 1 of .* is at address .* but contains no code.*" "annotation_level 0"
}
proc_with_prefix test_setshow_args {} {
clean_restart $::binfile
if ![runto_main] then {
fail "can't run to main"
return
}
gdb_test "show args" "Argument list to give program being debugged when it is started is \"\"\."
gdb_test "p \$_gdb_setting_str(\"args\")" " = \"\""
@ -89,37 +92,48 @@ gdb_test "p \$_gdb_setting_str(\"args\")" " = \"\""
gdb_test_no_output "set args ~"
gdb_test "show args" "Argument list to give program being debugged when it is started is \"~\"..*" \
"show args ~"
#test set args
gdb_test_no_output "set args foo bar blup baz bubble" "set args"
#test show args
gdb_test "show args" "Argument list to give program being debugged when it is started is \"foo bar blup baz bubble\"..*"
gdb_test "p \$_gdb_setting(\"args\")" " = \"foo bar blup baz bubble\"" \
"_gdb_setting args"
# Don't test if we can't pass args or if we're using a stub.
if { !$use_gdb_stub && ![target_info exists noargs] } {
if { !$::use_gdb_stub && ![target_info exists noargs] } {
#test passing args
gdb_test "cont" "Continuing.*" "continuing"
delete_breakpoints
gdb_test "run" "Starting program:.*foo bar blup baz bubble.*" "passing args"
}
}
proc_with_prefix test_setshow_check {} {
clean_restart
#test set check range on
# Note: the below might produce a warning, so match anything.
gdb_test "set check range on" ""
gdb_test "p \$_gdb_setting(\"check range\")" " = \"on\"" \
"_gdb_setting check range on"
#test show check range on
gdb_test "show check range" "Range checking is \"on\"\..*" "show check range (on)"
#test set check range off with trailing space
gdb_test_no_output "set check range off " "set check range off"
#test show check range off
gdb_test "show check range" "Range checking is \"off\"\..*" "show check range (off)"
gdb_test "p \$_gdb_setting(\"check range\")" " = \"off\"" \
"_gdb_setting check range off"
#test set check range auto
gdb_test_no_output "set check range auto" "set check range auto"
#test show check range auto
gdb_test "show check range" "Range checking is \"auto; currently .*" "show check range (auto)"
gdb_test "p \$_gdb_setting(\"check range\")" " = \"auto\"" \
@ -146,7 +160,9 @@ gdb_test "p \$_gdb_setting(\"check type\")" " = 0" \
# Test show check type off
gdb_test "show check type" "Strict type checking is off\..*" \
"show check type (off)"
}
proc_with_prefix test_setshow_breakpoint_pending {} {
#test set breakpoint pending
#test set breakpoint pending on
@ -176,8 +192,10 @@ gdb_test "p \$_gdb_setting_str(\"breakpoint pending\")" " = \"auto\"" \
"_gdb_setting_str breakpoint pending auto"
gdb_test "p \$_gdb_setting(\"breakpoint pending\")" " = -1" \
"_gdb_setting breakpoint pending -1"
}
proc_with_prefix test_setshow_complaints {} {
clean_restart
#test set complaints 100
gdb_test_no_output "set complaints 100" "set complaints 100"
@ -187,6 +205,11 @@ gdb_test "show complaints" "Max number of complaints about incorrect symbols is
gdb_test_no_output "set complaints 0" "set complaints 0"
#test show complaints 0
gdb_test "show complaints" "Max number of complaints about incorrect symbols is 0..*" "show complaints (0)"
}
proc_with_prefix test_setshow_confirm {} {
clean_restart
#test set confirm off
gdb_test_no_output "set confirm off" "set confirm off"
#test show confirm off
@ -195,27 +218,48 @@ gdb_test "show confirm" "Whether to confirm potentially dangerous operations is
gdb_test_no_output "set confirm on" "set confirm on"
#test show confirm on
gdb_test "show confirm" "Whether to confirm potentially dangerous operations is on..*" "show confirm (on)"
}
proc_with_prefix test_setshow_editing {} {
clean_restart
#test set editing off
gdb_test_no_output "set editing off" "set editing off"
#test show editing off
gdb_test "show editing" "Editing of command lines as they are typed is off..*" "show editing (off)"
#test set editing on
#gdb_test_no_output "set editing on" "set editing on"
#test show editing on
#gdb_test "show editing" "Editing of command lines as they are typed is on..*" "show editing (on)"
}
proc_with_prefix test_setshow_environment {} {
clean_restart
#test set environment FOOBARBAZ
gdb_test_no_output "set environment FOOBARBAZ = grbxgrbxgrbx" \
"set environment FOOBARBAZ"
#test show environment FOOBARBAZ
gdb_test "show environment FOOBARBAZ" "FOOBARBAZ = grbxgrbxgrbx.*"
}
proc_with_prefix test_setshow_height {} {
clean_restart
#test set height 100
gdb_test_no_output "set height 100" "set height 100"
#test show height 100
gdb_test "show height" "Number of lines gdb thinks are in a page is 100..*"
gdb_test "p \$_gdb_setting_str(\"height\")" " = \"100\"" \
"_gdb_setting_str height 100"
gdb_test "p \$_gdb_setting(\"height\")" " = 100" \
"_gdb_setting height 100"
# Back to infinite height to avoid pagers. While at it, check that
# literal "unlimited" works just as well as 0.
gdb_test_no_output "set height unlimited"
@ -223,22 +267,31 @@ gdb_test "p \$_gdb_setting_str(\"height\")" " = \"unlimited\"" \
"_gdb_setting_str height unlimited"
gdb_test "p \$_gdb_setting(\"height\")" " = 0" \
"_gdb_setting height unlimited"
}
proc_with_prefix test_setshow_history {} {
clean_restart
#test set history expansion on
gdb_test_no_output "set history expansion on" "set history expansion on"
#test show history expansion on
gdb_test "show history expansion on" "History expansion on command input is on.*" "show history expansion"
#get home directory path
set HOME ""
set test "show environment HOME"
gdb_test_multiple $test $test {
-re "\nHOME = (\[^\r\n\]*)\[\r\n\]+$gdb_prompt $" {
-re "\nHOME = (\[^\r\n\]*)\[\r\n\]+$::gdb_prompt $" {
set HOME $expect_out(1,string)
pass $test
}
}
#test set history filename ~/foobar.baz
gdb_test_no_output "set history filename ~/foobar.baz" \
"set history filename ~/foobar.baz"
#test show history filename ~/foobar.baz
gdb_test "show history filename" \
"The filename in which to record the command history is \"[string_to_regexp $HOME]/foobar.baz\"..*" \
@ -249,53 +302,85 @@ gdb_test "p \$_gdb_setting(\"history filename\")" \
gdb_test "p \$_gdb_setting_str(\"history filename\")" \
" = \"[string_to_regexp $HOME]/foobar.baz\"..*" \
"_gdb_setting_str history filename"
#get current working directory
set PWD ""
set test "show working directory"
gdb_test_multiple "pwd" $test {
-re "\nWorking directory (\[^\r\n\]*)\\.\[\r\n\]+$gdb_prompt $" {
-re "\nWorking directory (\[^\r\n\]*)\\.\[\r\n\]+$::gdb_prompt $" {
set PWD $expect_out(1,string)
pass $test
}
}
#test set history filename foobar.baz
gdb_test_no_output "set history filename foobar.baz" \
"set history filename foobar.baz"
#test show history filename foobar.baz
gdb_test "show history filename" \
"The filename in which to record the command history is \"[string_to_regexp $PWD]/foobar.baz\"..*" \
"show history filename (current_directory/foobar.baz)"
#test set history save on
gdb_test_no_output "set history save on" "set history save on"
#test show history save on
gdb_test "show history save" "Saving of the history record on exit is on..*" "show history save (on)"
#history saving should stay disabled
gdb_test_no_output "set history save off" "set history save off"
#test set history size 100
gdb_test_no_output "set history size 100" "set history size 100"
#test show history size 100
gdb_test "show history size" "The size of the command history is 100..*" "show history size (100)"
}
proc_with_prefix test_setshow_language {} {
clean_restart
#test set language asm
gdb_test_no_output "set language asm"
#test show language asm
gdb_test "show language" "The current source language is \"asm\"..*" "show language (asm)"
#test set language rust, with a trailing space
gdb_test_no_output "set language rust " "set language rust"
#test show language rust
gdb_test "show language" "The current source language is \"rust\"..*" "show language (rust)"
#test completion for set language.
gdb_test "complete set language min" "set language minimal" \
"complete set language minimal"
#test set language auto
gdb_test_no_output "set language auto" "set language auto"
#test show language
gdb_test "show language" "The current source language is \"auto.*\"..*" "show language (auto)"
}
proc_with_prefix test_setshow_listsize {} {
clean_restart
#test set listsize 100
gdb_test_no_output "set listsize 100" "set listsize 100"
#test show listsize 100
gdb_test "show listsize" "Number of source lines gdb will list by default is 100..*" "show listsize (100)"
}
proc_with_prefix test_setshow_prompt {} {
clean_restart
if [board_info target exists gdb_prompt] {
return
}
if ![board_info target exists gdb_prompt] {
#test set prompt (FooBarBaz)
set newprompt "\\(FooBarBaz\\)"
@ -306,7 +391,6 @@ if ![board_info target exists gdb_prompt] {
}
#test show prompt (FooBarBaz)
gdb_test_multiple "show prompt" "show prompt FooBarBaz" {
-re "Gdb's prompt is \"$newprompt \"..* $" {
pass "show prompt FooBarBaz"
@ -314,44 +398,80 @@ if ![board_info target exists gdb_prompt] {
}
#test set prompt (gdb)
gdb_test_multiple "set prompt (gdb) " "set prompt gdb" {
-re "\[\r\n\]$gdb_prompt $" {
-re "\[\r\n\]$::gdb_prompt $" {
pass "set prompt gdb"
}
}
}
proc_with_prefix test_setshow_radix {} {
clean_restart
#test set radix 11
gdb_test "set radix 11" "Unsupported output radix ``decimal 11''; output radix unchanged..*"
#test set radix 16
gdb_test "set radix 16" "Input and output radices now set to decimal 16, hex 10, octal 20..*"
#test show radix 16
gdb_test "show radix" "Input and output radices set to decimal 16, hex 10, octal 20..*" "show radix (16)"
#test set radix 10
gdb_test "set radix" "Input and output radices now set to decimal 10, hex a, octal 12..*" "set radix 10"
#test show radix 10
gdb_test "show radix" "Input and output radices set to decimal 10, hex a, octal 12..*" "show radix (10)"
}
proc_with_prefix test_setshow_width {} {
clean_restart
#test set width 90
gdb_test_no_output "set width 90" "set width 90"
#test show width 90
gdb_test "show width" "Number of characters gdb thinks are in a line is 90..*" "show width (90)"
}
proc_with_prefix test_setshow_write {} {
clean_restart
#test set write on
# This is only supported on targets which use exec.o.
gdb_test_no_output "set write on" "set write on"
#test show write on
# This is only supported on targets which use exec.o.
gdb_test "show write" "Writing into executable and core files is on..*" "show write (on)"
}
proc_with_prefix test_show_user {} {
clean_restart
#test show user
gdb_test_no_output "show user" "show user"
}
proc_with_prefix test_setshow_verbose {} {
clean_restart
#test set verbose on
gdb_test_no_output "set verbose on" "set verbose on"
#test show verbose on
gdb_test "show verbose" "Verbose printing of informational messages is on..*" "show verbose (on)"
#test set verbose off
gdb_test_no_output "set verbose off" "set verbose off"
#test show verbose off
gdb_test "show verbose" "Verbosity is off..*" "show verbose (off)"
}
proc_with_prefix test_argument_preceded_by_space {} {
clean_restart
#test argument must be preceded by space
foreach x {"history file" "solib-search-path" "data-directory"} {
foreach y {"/home/" "~/home" "=home"} {
@ -359,3 +479,24 @@ foreach x {"history file" "solib-search-path" "data-directory"} {
"$x is not set to $y"
}
}
}
test_setshow_annotate
test_setshow_args
test_setshow_check
test_setshow_breakpoint_pending
test_setshow_complaints
test_setshow_confirm
test_setshow_editing
test_setshow_environment
test_setshow_height
test_setshow_history
test_setshow_language
test_setshow_listsize
test_setshow_prompt
test_setshow_radix
test_setshow_width
test_setshow_write
test_show_user
test_setshow_verbose
test_argument_preceded_by_space