From 3a56ed8668f57bbec6b769a862131d769d2fceb7 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Thu, 3 Oct 2019 16:22:09 +0200 Subject: [PATCH] [gdb/testsuite] Fix list-missing-source.exp with gcc 4.8 With gcc 4.8.1, we see this FAIL: ... (gdb) PASS: gdb.base/list-missing-source.exp: list info source^M Current source file is outputs/gdb.base/list-missing-source/main.c^M Source language is c.^M Producer is GNU C 4.8.5 -mtune=generic -march=x86-64 -g -fno-stack-protector.^M Compiled with DWARF 2 debugging format.^M Does not include preprocessor macro info.^M (gdb) FAIL: gdb.base/list-missing-source.exp: info source ... The problem is that a "Compilation directory is " line is expected, but this is missing due to the fact the the compilation unit for main.c doesn't contain a DW_AT_comp_dir in the DW_TAG_compile_unit DIE. Fix this by allowing the "Compilation directory" line to be missing. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2019-10-03 Tom de Vries PR testsuite/25059 * gdb.base/list-missing-source.exp: Allowing the "Compilation directory" line to be missing. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.base/list-missing-source.exp | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 0675e856c84..acc930a92f2 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2019-10-03 Tom de Vries + + PR testsuite/25059 + * gdb.base/list-missing-source.exp: Allowing the "Compilation + directory" line to be missing. + 2019-10-03 Tom de Vries PR testsuite/25059 diff --git a/gdb/testsuite/gdb.base/list-missing-source.exp b/gdb/testsuite/gdb.base/list-missing-source.exp index 703603e7cb2..497ccab1f70 100644 --- a/gdb/testsuite/gdb.base/list-missing-source.exp +++ b/gdb/testsuite/gdb.base/list-missing-source.exp @@ -54,8 +54,8 @@ gdb_test "list" "1\[ \t\]+in\[ \t\]+$srcfile" gdb_test "info source" \ [multi_line \ "info source" \ - "Current source file is $srcfile" \ - "Compilation directory is \[^\n\r\]+" \ + "Current source file is $srcfile\(" \ + "Compilation directory is \[^\n\r\]+)?" \ "Source language is c." \ "Producer is \[^\n\r\]+" \ "Compiled with DWARF $decimal debugging format." \