espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-28 23:39:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix PR remote/20398: File-IO write always outputs "Quit"

Browse Source 
Commit bb7c96deb1a1 ("gdb/remote-fileio.c: Eliminate custom SIGINT
signal handler") regressed the File-IO support.

Failed output:

  (gdb) target remote :8888
  Remote debugging using :8888
  0x00008098 in _start ()
  (gdb) c
  Continuing.
  Quit
  Quit
  Quit
  Quit
  Quit
  Quit
  Quit
  Quit
  Quit
  Quit
  Quit
  [Inferior 1 (Remote target) exited normally]

Expected output:

  (gdb) target remote :8888
  Remote debugging using :8888
  0x00008098 in _start ()
  (gdb) c
  Continuing.
  i: 0
  i: 1
  i: 2
  i: 3
  i: 4
  i: 5
  i: 6
  i: 7
  i: 8
  i: 9
  [Inferior 1 (Remote target) exited normally]

The problem that the new File-IO quit handler forgets to check the
quit flag before calling throwing a quit.

gdb/ChangeLog:
2016-08-05  Pedro Alves  <palves@redhat.com>

	PR remote/20398
	* remote-fileio.c (remote_fileio_quit_handler): Check the quit
	flag before calling quit.
This commit is contained in:
Pedro Alves
2016-08-05 19:54:11 +01:00
parent 69ffd7f270
commit 3906a8fc77
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2016-08-05 Pedro Alves <palves@redhat.com>
PR remote/20398
* remote-fileio.c (remote_fileio_quit_handler): Check the quit
flag before calling quit.
2016-08-05 Pedro Alves <palves@redhat.com> 2016-08-05 Pedro Alves <palves@redhat.com>
* NEWS: Mention that GDB and GDBserver build with a C++ compiler * NEWS: Mention that GDB and GDBserver build with a C++ compiler

3
gdb/remote-fileio.c
View File

@ -308,7 +308,8 @@ static quit_handler_ftype *remote_fileio_o_quit_handler;
static void static void
remote_fileio_quit_handler (void) remote_fileio_quit_handler (void)
{ {
quit (); if (check_quit_flag ())
quit ();
} }
static void static void