espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-22 19:09:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

gdb: use gdb_assert not internal_error

Browse Source 
Spotted a couple of places in findvar.c where we use:

  if ( ! CONDITION )
    internal_error ("...");

this commit changes these to be:

  gdb_assert ( CONDITION );

which I think is better.

Unless we happen to hit the internal_error calls (which was bad) there
should be no user visible changes after this commit.
This commit is contained in:
Andrew Burgess
2022-12-12 14:09:40 +00:00
parent c896441822
commit 38665d717a
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gdb/findvar.c
View File

@ -152,10 +152,7 @@ extract_long_unsigned_integer (const gdb_byte *addr, int orig_len,
CORE_ADDR CORE_ADDR
extract_typed_address (const gdb_byte *buf, struct type *type) extract_typed_address (const gdb_byte *buf, struct type *type)
{ {
if (!type->is_pointer_or_reference ()) gdb_assert (type->is_pointer_or_reference ());
internal_error (_("extract_typed_address: "
"type is not a pointer or reference"));
return gdbarch_pointer_to_address (type->arch (), type, buf); return gdbarch_pointer_to_address (type->arch (), type, buf);
} }
@ -204,10 +201,7 @@ template void store_integer (gdb_byte *addr, int len,
void void
store_typed_address (gdb_byte *buf, struct type *type, CORE_ADDR addr) store_typed_address (gdb_byte *buf, struct type *type, CORE_ADDR addr)
{ {
if (!type->is_pointer_or_reference ()) gdb_assert (type->is_pointer_or_reference ());
internal_error (_("store_typed_address: "
"type is not a pointer or reference"));
gdbarch_address_to_pointer (type->arch (), type, buf, addr); gdbarch_address_to_pointer (type->arch (), type, buf, addr);
} }