espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-23 19:50:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change void_context_p to bool

Browse Source 
This patch changes void_context_p to bool, as a prerequisite to the
change to post_parser that I submitted here:

https://sourceware.org/pipermail/gdb-patches/2020-December/174080.html

Tested by rebuilding.

Note that nothing in-tree passes true here.  I don't know why this is,
but there is a use of this internally in AdaCore's tree.  I will try
to submit that patch, if it is needed.  (And if not, I will come back
around and remove this.)

gdb/ChangeLog
2020-12-16  Tom Tromey  <tom@tromey.com>

	* parse.c (parse_exp_1, parse_expression_for_completion): Update.
	(parse_exp_in_context): Change void_context_p to bool.
	* language.h (struct language_defn) <post_parser>: Change
	void_context_p to bool.
	* ada-lang.c (class ada_language) <post_parser>: Update.
This commit is contained in:
Tom Tromey
2020-12-16 15:12:55 -07:00
parent 93df4a1d07
commit 35c1ab606d
4 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,11 @@
2020-12-16 Tom Tromey <tom@tromey.com>
* parse.c (parse_exp_1, parse_expression_for_completion): Update.
(parse_exp_in_context): Change void_context_p to bool.
* language.h (struct language_defn) <post_parser>: Change
void_context_p to bool.
* ada-lang.c (class ada_language) <post_parser>: Update.
2020-12-16 Tom Tromey <tom@tromey.com> 2020-12-16 Tom Tromey <tom@tromey.com>
Tom Tromey <tromey@redhat.com> Tom Tromey <tromey@redhat.com>
Tom de Vries <tdevries@suse.de> Tom de Vries <tdevries@suse.de>

2
gdb/ada-lang.c
View File

@ -14124,7 +14124,7 @@ public:
A null CONTEXT_TYPE indicates that a non-void return type is A null CONTEXT_TYPE indicates that a non-void return type is
preferred. May change (expand) *EXP. */ preferred. May change (expand) *EXP. */
void post_parser (expression_up *expp, int void_context_p, int completing, void post_parser (expression_up *expp, bool void_context_p, int completing,
innermost_block_tracker *tracker) const override innermost_block_tracker *tracker) const override
{ {
struct type *context_type = NULL; struct type *context_type = NULL;

2
gdb/language.h
View File

@ -527,7 +527,7 @@ struct language_defn
non-zero, then the expression has been parsed for completion, not non-zero, then the expression has been parsed for completion, not
evaluation. */ evaluation. */
virtual void post_parser (expression_up *expp, int void_context_p, virtual void post_parser (expression_up *expp, bool void_context_p,
int completing, int completing,
innermost_block_tracker *tracker) const innermost_block_tracker *tracker) const
{ {

8
gdb/parse.c
View File

@ -88,7 +88,7 @@ static int prefixify_subexp (struct expression *, struct expression *, int,
static expression_up parse_exp_in_context (const char **, CORE_ADDR, static expression_up parse_exp_in_context (const char **, CORE_ADDR,
const struct block *, int, const struct block *, int,
int, int *, bool, int *,
innermost_block_tracker *, innermost_block_tracker *,
expr_completion_state *); expr_completion_state *);
@ -1028,7 +1028,7 @@ expression_up
parse_exp_1 (const char **stringptr, CORE_ADDR pc, const struct block *block, parse_exp_1 (const char **stringptr, CORE_ADDR pc, const struct block *block,
int comma, innermost_block_tracker *tracker) int comma, innermost_block_tracker *tracker)
{ {
return parse_exp_in_context (stringptr, pc, block, comma, 0, NULL, return parse_exp_in_context (stringptr, pc, block, comma, false, NULL,
tracker, nullptr); tracker, nullptr);
} }
@ -1042,7 +1042,7 @@ parse_exp_1 (const char **stringptr, CORE_ADDR pc, const struct block *block,
static expression_up static expression_up
parse_exp_in_context (const char **stringptr, CORE_ADDR pc, parse_exp_in_context (const char **stringptr, CORE_ADDR pc,
const struct block *block, const struct block *block,
int comma, int void_context_p, int *out_subexp, int comma, bool void_context_p, int *out_subexp,
innermost_block_tracker *tracker, innermost_block_tracker *tracker,
expr_completion_state *cstate) expr_completion_state *cstate)
{ {
@ -1205,7 +1205,7 @@ parse_expression_for_completion (const char *string,
try try
{ {
exp = parse_exp_in_context (&string, 0, 0, 0, 0, &subexp, exp = parse_exp_in_context (&string, 0, 0, 0, false, &subexp,
nullptr, &cstate); nullptr, &cstate);
} }
catch (const gdb_exception_error &except) catch (const gdb_exception_error &except)