espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-06-26 13:56:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

* elflink.c (_bfd_elf_fix_symbol_flags): Remove unnecessary

Browse Source 
check on dynobj.  Remove bed shadow.
This commit is contained in:
Alan Modra
2007-07-26 13:45:59 +00:00
parent e62071b60e
commit 33774f084b
2 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
bfd/ChangeLog
View File

@ -1,5 +1,8 @@
2007-07-26 Alan Modra <amodra@bigpond.net.au> 2007-07-26 Alan Modra <amodra@bigpond.net.au>
* elflink.c (_bfd_elf_fix_symbol_flags): Remove unnecessary
check on dynobj. Remove bed shadow.
* srec.c (srec_get_section_contents): Return immediately on * srec.c (srec_get_section_contents): Return immediately on
count zero. Check that offset and count are within section. count zero. Check that offset and count are within section.
* libbfd.c (_bfd_generic_get_section_contents): Check that * libbfd.c (_bfd_generic_get_section_contents): Check that

9
bfd/elflink.c
View File

@ -2368,7 +2368,7 @@ bfd_boolean
_bfd_elf_fix_symbol_flags (struct elf_link_hash_entry *h, _bfd_elf_fix_symbol_flags (struct elf_link_hash_entry *h,
struct elf_info_failed *eif) struct elf_info_failed *eif)
{ {
const struct elf_backend_data *bed = NULL; const struct elf_backend_data *bed;
/* If this symbol was mentioned in a non-ELF file, try to set /* If this symbol was mentioned in a non-ELF file, try to set
DEF_REGULAR and REF_REGULAR correctly. This is the only way to DEF_REGULAR and REF_REGULAR correctly. This is the only way to
@ -2429,13 +2429,10 @@ _bfd_elf_fix_symbol_flags (struct elf_link_hash_entry *h,
} }
/* Backend specific symbol fixup. */ /* Backend specific symbol fixup. */
if (elf_hash_table (eif->info)->dynobj)
{
bed = get_elf_backend_data (elf_hash_table (eif->info)->dynobj); bed = get_elf_backend_data (elf_hash_table (eif->info)->dynobj);
if (bed->elf_backend_fixup_symbol if (bed->elf_backend_fixup_symbol
&& !(*bed->elf_backend_fixup_symbol) (eif->info, h)) && !(*bed->elf_backend_fixup_symbol) (eif->info, h))
return FALSE; return FALSE;
}
/* If this is a final link, and the symbol was defined as a common /* If this is a final link, and the symbol was defined as a common
symbol in a regular object file, and there was no definition in symbol in a regular object file, and there was no definition in
@ -2473,11 +2470,7 @@ _bfd_elf_fix_symbol_flags (struct elf_link_hash_entry *h,
hide it from the dynamic linker. */ hide it from the dynamic linker. */
if (ELF_ST_VISIBILITY (h->other) != STV_DEFAULT if (ELF_ST_VISIBILITY (h->other) != STV_DEFAULT
&& h->root.type == bfd_link_hash_undefweak) && h->root.type == bfd_link_hash_undefweak)
{
const struct elf_backend_data *bed;
bed = get_elf_backend_data (elf_hash_table (eif->info)->dynobj);
(*bed->elf_backend_hide_symbol) (eif->info, h, TRUE); (*bed->elf_backend_hide_symbol) (eif->info, h, TRUE);
}
/* If this is a weak defined symbol in a dynamic object, and we know /* If this is a weak defined symbol in a dynamic object, and we know
the real definition in the dynamic object, copy interesting flags the real definition in the dynamic object, copy interesting flags