espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-07-01 09:49:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change tui_get_register to return void

Browse Source 
tui_get_register returns a tui_status, but nothing checks this, so it
can return void instead.

gdb/ChangeLog
2019-07-17  Tom Tromey  <tom@tromey.com>

	* tui/tui-regs.c (tui_get_register): Return void.
This commit is contained in:
Tom Tromey
2019-07-01 00:51:20 -06:00
parent 8e3cfd09e8
commit 2cdfa11333
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2019-07-17 Tom Tromey <tom@tromey.com>
* tui/tui-regs.c (tui_get_register): Return void.
2019-07-17 Tom Tromey <tom@tromey.com> 2019-07-17 Tom Tromey <tom@tromey.com>
* tui/tui-wingeneral.c (tui_gen_win_info::make_visible): * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):

13
gdb/tui/tui-regs.c
View File

@ -54,9 +54,9 @@ static void tui_show_register_group (tui_data_window *win_info,
struct frame_info *frame, struct frame_info *frame,
int refresh_values_only); int refresh_values_only);
static enum tui_status tui_get_register (struct frame_info *frame, static void tui_get_register (struct frame_info *frame,
struct tui_data_item_window *data, struct tui_data_item_window *data,
int regnum, bool *changedp); int regnum, bool *changedp);
@ -646,13 +646,11 @@ tui_register_format (struct frame_info *frame, int regnum)
/* Get the register value from the given frame and format it for the /* Get the register value from the given frame and format it for the
display. When changep is set, check if the new register value has display. When changep is set, check if the new register value has
changed with respect to the previous call. */ changed with respect to the previous call. */
static enum tui_status static void
tui_get_register (struct frame_info *frame, tui_get_register (struct frame_info *frame,
struct tui_data_item_window *data, struct tui_data_item_window *data,
int regnum, bool *changedp) int regnum, bool *changedp)
{ {
enum tui_status ret = TUI_FAILURE;
if (changedp) if (changedp)
*changedp = false; *changedp = false;
if (target_has_registers) if (target_has_registers)
@ -666,8 +664,5 @@ tui_get_register (struct frame_info *frame,
*changedp = true; *changedp = true;
xfree (prev_content); xfree (prev_content);
ret = TUI_SUCCESS;
} }
return ret;
} }