espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-05-27 21:46:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove more uses of explicit reference counting in Python

Browse Source 
This changes some more place in the Python code to use gdbpy_ref
rather than explicit reference counting.  While doing this I found a
latent bug in typy_fields_items -- it was not checking for errors in
one spot.  I also changed valpy_dealloc to use Py_XDECREF rather than
an explicit "if".

gdb/ChangeLog
2019-01-03  Tom Tromey  <tom@tromey.com>

	* python/py-value.c (valpy_dealloc): Use Py_XDECREF.
	* python/py-type.c (typy_fields_items): Use gdbpy_ref.
	* python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
	(pspy_set_frame_filters, pspy_set_frame_unwinders)
	(pspy_set_type_printers): Likewise.
	* python/py-function.c (fnpy_init): Use gdbpy_ref.
	* python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
	* python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
	(objfpy_set_frame_filters, objfpy_set_frame_unwinders)
	(objfpy_set_type_printers): Likewise.
This commit is contained in:
Tom Tromey
2018-12-27 11:53:20 -07:00
parent 5c329e6ab4
commit 2a3c71d68d
7 changed files with 39 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gdb/python/py-value.c
View File

@ -90,17 +90,8 @@ valpy_dealloc (PyObject *obj)
value_decref (self->value);
if (self->address)
/* Use braces to appease gcc warning. *sigh* */
{
Py_DECREF (self->address);
}
if (self->type)
{
Py_DECREF (self->type);
}
Py_XDECREF (self->address);
Py_XDECREF (self->type);
Py_XDECREF (self->dynamic_type);
Py_TYPE (self)->tp_free (self);