test suite update - gdb.base/[efg]

Convert files gdb.base/[efg]*.exp to use standard_output_file et al.

	* ena-dis-br.exp, enum_cond.exp, enumval.exp, environ.exp,
	eu-strip-infcall.exp, eval-skip.exp, exe-lock.exp,
	expand-psymtabs.exp, exprs.exp, fileio.exp, find.exp,
	fixsection.exp, foll-exec.exp, foll-fork.exp,
	fortran-sym-case.exp, frame-args.exp, freebpcmd.exp, fullname.exp,
	funcargs.exp, gcore-buffer-overflow.exp, gcore.exp, gdb1090.exp,
	gdb11530.exp, gdb11531.exp, gdb1250.exp, gdb1555.exp, gdb1821.exp,
	gdbindex-stabs.exp, gdbvars.exp, gnu-ifunc.exp, gnu_vector.exp:
	Use standard_testfile, standard_output_file, prepare_for_testing,
	clean_restart.

gdb/testsuite/ChangeLog

@@ -1,3 +1,16 @@
+2013-06-27  Tom Tromey  <tromey@redhat.com>
+
+	* ena-dis-br.exp, enum_cond.exp, enumval.exp, environ.exp,
+	eu-strip-infcall.exp, eval-skip.exp, exe-lock.exp,
+	expand-psymtabs.exp, exprs.exp, fileio.exp, find.exp,
+	fixsection.exp, foll-exec.exp, foll-fork.exp,
+	fortran-sym-case.exp, frame-args.exp, freebpcmd.exp, fullname.exp,
+	funcargs.exp, gcore-buffer-overflow.exp, gcore.exp, gdb1090.exp,
+	gdb11530.exp, gdb11531.exp, gdb1250.exp, gdb1555.exp, gdb1821.exp,
+	gdbindex-stabs.exp, gdbvars.exp, gnu-ifunc.exp, gnu_vector.exp:
+	Use standard_testfile, standard_output_file, prepare_for_testing,
+	clean_restart.
+
 2013-06-27  Tom Tromey  <tromey@redhat.com>
 
 	* call-ar-st.exp, call-rt-st.exp, call-sc.exp,

gdb/testsuite/gdb.base/ena-dis-br.exp

@@ -19,42 +19,24 @@
 # test running programs
 #
 
-set testfile "break"
+standard_testfile break.c break1.c
-set srcfile ${testfile}.c
-set srcfile1 ${testfile}1.c
-set binfile ${objdir}/${subdir}/${testfile}
 
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}0.o" object {debug nowarnings}] != "" } {
+if {[prepare_for_testing ${testfile}.exp ${testfile} \
-     untested ena-dis-br.exp
+	 [list $srcfile $srcfile2] {debug nowarnings}]} {
-     return -1
+    return -1
 }
 
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile1}" "${binfile}1.o" object {debug nowarnings}] != "" } {
-     untested ena-dis-br.exp
-     return -1
-}
-
-if  { [gdb_compile "${binfile}0.o ${binfile}1.o" "${binfile}" executable {debug nowarnings}] != "" } {
-     untested ena-dis-br.exp
-     return -1
-}
-
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
-
 set bp_location1 [gdb_get_line_number "set breakpoint 1 here"]
 set bp_location7 [gdb_get_line_number "set breakpoint 7 here"]
-set bp_location8 [gdb_get_line_number "set breakpoint 8 here" $srcfile1]
+set bp_location8 [gdb_get_line_number "set breakpoint 8 here" $srcfile2]
-set bp_location9 [gdb_get_line_number "set breakpoint 9 here" $srcfile1]
+set bp_location9 [gdb_get_line_number "set breakpoint 9 here" $srcfile2]
 set bp_location11 [gdb_get_line_number "set breakpoint 11 here"]
-set bp_location13 [gdb_get_line_number "set breakpoint 13 here" $srcfile1]
+set bp_location13 [gdb_get_line_number "set breakpoint 13 here" $srcfile2]
-set bp_location14 [gdb_get_line_number "set breakpoint 14 here" $srcfile1]
+set bp_location14 [gdb_get_line_number "set breakpoint 14 here" $srcfile2]
-set bp_location15 [gdb_get_line_number "set breakpoint 15 here" $srcfile1]
+set bp_location15 [gdb_get_line_number "set breakpoint 15 here" $srcfile2]
-set bp_location16 [gdb_get_line_number "set breakpoint 16 here" $srcfile1]
+set bp_location16 [gdb_get_line_number "set breakpoint 16 here" $srcfile2]
-set bp_location17 [gdb_get_line_number "set breakpoint 17 here" $srcfile1]
+set bp_location17 [gdb_get_line_number "set breakpoint 17 here" $srcfile2]
-set bp_location18 [gdb_get_line_number "set breakpoint 18 here" $srcfile1]
+set bp_location18 [gdb_get_line_number "set breakpoint 18 here" $srcfile2]
 
 if ![runto_main] then { fail "enable/disable break tests suppressed" }
 

gdb/testsuite/gdb.base/enum_cond.exp

@@ -17,9 +17,7 @@
 # gdb can correctly print arrays with indexes for each element of the
 # array.
 
-set testfile "enum_cond"
+standard_testfile .c
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
 set opts [list debug additional_flags=-fshort-enums]
 if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable $opts] != "" } {

gdb/testsuite/gdb.base/enumval.exp

@@ -15,11 +15,10 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-set testfile "enumval"
+standard_testfile
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
-if { [prepare_for_testing enumval.exp "enumval" "" {debug}] } {
+if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
+    untested $testfile.exp
     return -1
 }
 

gdb/testsuite/gdb.base/environ.exp

@@ -24,31 +24,14 @@ if ![istarget "hppa*-*-hpux*"] then {
   return
 }
 
-set testfile "break"
+standard_testfile break.c break1.c
-set srcfile ${testfile}.c
-set srcfile1 ${testfile}1.c
-set binfile ${objdir}/${subdir}/${testfile}
 
-if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}0.o" object {debug nowarnings}] != "" } {
+if {[prepare_for_testing $testfile.exp $testfile \
-    untested environ.exp
+	 [list $srcfile $srcfile2] {debug nowarnings}]} {
+    untested $testfile.exp
     return -1
 }
 
-if { [gdb_compile "${srcdir}/${subdir}/${srcfile1}" "${binfile}1.o" object {debug nowarnings}] != "" } {
-    untested environ.exp
-    return -1
-}
-
-if { [gdb_compile "${binfile}0.o ${binfile}1.o" "${binfile}" executable {debug nowarnings}] != "" } {
-    untested environ.exp
-    return -1
-}
-
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
-
 if ![runto_main] then { fail "environment command tests suppressed" }
 
 # (No, this is not really related to the environment commands.  But it's

gdb/testsuite/gdb.base/eu-strip-infcall.exp

@@ -13,8 +13,7 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-set testfile eu-strip-infcall
+standard_testfile
-set binfile ${objdir}/${subdir}/${testfile}
 
 if {[build_executable ${testfile}.exp $testfile] == -1} {
     return -1

gdb/testsuite/gdb.base/eval-skip.exp

@@ -32,9 +32,7 @@
 # haven't tried to compile one, or the compilation failed for some reason.
 # In either case, just notify the user and skip the tests in this file.
 
-set testfile "int-type"
+standard_testfile int-type.c
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug nowarnings}] != "" } {
      untested eval-skip.exp
@@ -45,10 +43,7 @@ if [get_compiler_info] {
     return -1
 }
 
-gdb_exit
+clean_restart ${binfile}
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
 
 
 if ![runto_main] then {

gdb/testsuite/gdb.base/exe-lock.exp

@@ -17,21 +17,17 @@
 # a filesystem lock on the executable file once the executable
 # is no longer running.
 
-set testfile "arrayidx"
+standard_testfile arrayidx.c
-set srcfile ${testfile}.c
 # $EXEEXT suffix is needed here, because otherwise, Windows targets
 # don't find the $binfile for 'file delete $binfile'.
-set binfile ${objdir}/${subdir}/${testfile}$EXEEXT
+append binfile $EXEEXT
 
 if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
     untested "Couldn't compile ${srcfile}"
     return -1
 }
 
-gdb_exit
+clean_restart ${binfile}
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
 
 # Sanity-check: Verify that the executable exists. This is just to
 # make sure that, when we verify later that the file does not exist,

gdb/testsuite/gdb.base/expand-psymtabs.exp

@@ -29,37 +29,20 @@
 # reading in effect, GDB can set breakpoints by line number
 # successfully in either compilation unit.  
 
-set testfile expand-psymtabs
+standard_testfile
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
-set binfile_1 ${objdir}/${subdir}/${testfile}_1.o
-set binfile_2 ${objdir}/${subdir}/${testfile}_2.o
 
 # What compiler are we using?
 if [get_compiler_info] {
     return -1
 }
 
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_1}" object {debug additional_flags=-DFIRST} ] != "" } {
+# We intentionally compile the source file in twice.
-     untested expand-psymtabs.exp
+if {[prepare_for_testing_full $testfile.exp \
-     return -1
+	 [list $testfile debug $srcfile {debug additional_flags=-DFIRST} \
+	      $srcfile debug]]} {
+    return -1
 }
 
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile_2}" object {debug}] != "" } {
-     untested expand-psymtabs.exp
-     return -1
-}
-
-if  { [gdb_compile "${binfile_1} ${binfile_2}" "${binfile}" executable {debug}] != "" } {
-     untested expand-psymtabs.exp
-     return -1
-}
-
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
-
 set foo_bp [gdb_get_line_number "Break here"]
 gdb_test "break $foo_bp" "Breakpoint.*" "Expand psymtabs"
 

gdb/testsuite/gdb.base/exprs.exp

@@ -19,9 +19,8 @@
 # test running programs
 #
 
-set testfile "exprs"
+standard_testfile .c
-set srcfile ${testfile}.c
+
-set binfile ${objdir}/${subdir}/${testfile}
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
      untested exprs.exp
      return -1
@@ -31,10 +30,7 @@ if [get_compiler_info] {
     return -1
 }
 
-gdb_exit
+clean_restart ${binfile}
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
 
 #
 # set it up at a breakpoint so we can play with the variable values

gdb/testsuite/gdb.base/fileio.exp

@@ -21,9 +21,7 @@ if [target_info exists gdb,nofileio] {
 }
 
 
-set testfile "fileio"
+standard_testfile
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
     untested fileio.exp

gdb/testsuite/gdb.base/find.exp

@@ -15,19 +15,14 @@
 
 # This tests the find command.
 
-set testfile "find"
+standard_testfile .c
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug nowarnings}] != "" } {
     untested find.exp
     return -1
 }
 
-gdb_exit
+clean_restart ${binfile}
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
 
 gdb_test "break $srcfile:stop_here" \
     "Breakpoint.*at.* file .*$srcfile, line.*" \

gdb/testsuite/gdb.base/fixsection.exp

@@ -18,13 +18,11 @@ if {[skip_shlib_tests]} {
     return 0
 }
 
-set testfile "fixsection"
+standard_testfile .c
-set srcfile ${srcdir}/${subdir}/${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
 set libfile "fixsectshr"
 set libsrc ${srcdir}/${subdir}/${libfile}.c
-set lib_sl ${objdir}/${subdir}/${libfile}.sl
+set lib_sl [standard_output_file ${libfile}.sl]
 
 set lib_opts [list debug nowarnings]
 set exec_opts [list debug nowarnings shlib=$lib_sl]
@@ -34,7 +32,8 @@ if [get_compiler_info] {
 }
 
 if { [gdb_compile_shlib $libsrc $lib_sl $lib_opts] != ""
-     || [gdb_compile $srcfile $binfile executable $exec_opts] != ""} {
+     || [gdb_compile $srcdir/$subdir/$srcfile $binfile \
+	     executable $exec_opts] != ""} {
     untested "Could not compile either $libsrc or $srcfile."
     return -1
 }

gdb/testsuite/gdb.base/foll-exec.exp

@@ -23,12 +23,11 @@ if {![istarget "hppa*-hp-hpux*"] && ![istarget "*-linux*"]} then {
     continue
 }
 
-set testfile "foll-exec"
+standard_testfile foll-exec.c
+
 set testfile2 "execd-prog"
-set srcfile ${testfile}.c
 set srcfile2 ${testfile2}.c
-set binfile ${objdir}/${subdir}/${testfile}
+set binfile2 [standard_output_file ${testfile2}]
-set binfile2 ${objdir}/${subdir}/${testfile2}
 
 # build the first test case
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile2}" "${binfile2}" executable {debug}] != "" } {

gdb/testsuite/gdb.base/foll-fork.exp

@@ -24,14 +24,11 @@ if {![istarget "hppa*-hp-hpux*"] && ![istarget "*-linux*"]} then {
     continue
 }
 
-global srcfile
+standard_testfile
-set testfile "foll-fork"
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
+if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
-     untested foll-fork.exp
+    untested $testfile.exp
-     return -1
+    return -1
 }
 
 proc check_fork_catchpoints {} {
@@ -331,13 +328,6 @@ By default, the debugger will follow the parent process..*" \
     if [runto_main] then { tcatch_fork_parent_follow }
 }
 
-# Start with a fresh gdb
-
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
-
 # The "Detaching..." and "Attaching..." messages may be hidden by
 # default.
 gdb_test_no_output "set verbose"

gdb/testsuite/gdb.base/fortran-sym-case.exp

@@ -13,7 +13,8 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-set testfile fortran-sym-case
+standard_testfile .c
+
 if { [prepare_for_testing ${testfile}.exp ${testfile}] } {
     return -1
 }

gdb/testsuite/gdb.base/frame-args.exp

@@ -13,18 +13,13 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-set testfile "frame-args"
+standard_testfile .c
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
     untested "Couldn't compile ${srcfile}"
     return -1
 }
 
-gdb_exit
+clean_restart ${binfile}
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
 
 if ![runto break_me] then {
   perror "Couldn't run ${testfile}"

gdb/testsuite/gdb.base/freebpcmd.exp

@@ -44,20 +44,12 @@
 # suggestions for improving this.
 
 
-set testfile "freebpcmd"
+standard_testfile
-set srcfile ${testfile}.c
+if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
-set binfile ${objdir}/${subdir}/${testfile}
+    untested $testfile.exp
-
+    return -1
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
-     untested freebpcmd.exp
-     return -1
 }
 
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
-
 gdb_test "break ${srcfile}:[gdb_get_line_number "euphonium"]" ".*" \
     "set breakpoint"
 

gdb/testsuite/gdb.base/fullname.exp

@@ -16,9 +16,7 @@
 # This file tests setting breakpoints according to the full path of a
 # source file.
 
-set testfile "fullname"
+standard_testfile
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
 # We rely on being able to copy things around.
 
@@ -30,13 +28,13 @@ if { [is_remote host] } {
 # Create a temporary file in the build directory.  Use a different
 # filename in case ${srcdir} == ${objdir}.
 if { [catch {file copy -force ${srcdir}/${subdir}/${srcfile} \
-			      ${objdir}/${subdir}/tmp-${srcfile}}] != 0 } {
+			      [standard_output_file tmp-${srcfile}]}] != 0 } {
     error "Could not create temporary file"
     return -1
 }
 
 # Build the test executable using an absolute path.
-if  { [gdb_compile "${objdir}/${subdir}/tmp-${srcfile}" "${binfile}" executable {debug}] != "" } {
+if  { [gdb_compile [standard_output_file tmp-${srcfile}] "${binfile}" executable {debug}] != "" } {
     return -1
 }
 
@@ -55,7 +53,7 @@ gdb_start
 gdb_load ${binfile}
 
 set msg "set breakpoint by full path before loading symbols - built absolute"
-if { [gdb_breakpoint ${objdir}/${subdir}/tmp-${srcfile}:${line} {no-message}] != 0 } {
+if { [gdb_breakpoint [standard_output_file tmp-${srcfile}]:${line} {no-message}] != 0 } {
     pass $msg
 } else {
     fail $msg
@@ -65,7 +63,7 @@ gdb_test "break main" \
 	 "Breakpoint.*at.*line.*" "set breakpoint at main - built absolute"
 
 set msg "set breakpoint by full path after loading symbols - built absolute"
-if { [gdb_breakpoint ${objdir}/${subdir}/tmp-${srcfile}:${line} {no-message}] != 0 } {
+if { [gdb_breakpoint [standard_output_file tmp-${srcfile}]:${line} {no-message}] != 0 } {
     pass $msg
 } else {
     fail $msg
@@ -81,7 +79,7 @@ gdb_start
 gdb_load ${binfile}
 
 set msg "set breakpoint by full path before loading symbols - built relative"
-if { [gdb_breakpoint ${objdir}/${subdir}/tmp-${srcfile}:${line} {no-message}] != 0 } {
+if { [gdb_breakpoint [standard_output_file tmp-${srcfile}]:${line} {no-message}] != 0 } {
     pass $msg
 } else {
     fail $msg
@@ -91,7 +89,7 @@ gdb_test "break main" \
 	 "Breakpoint.*at.*line.*" "set breakpoint at main - built relative"
 
 set msg "set breakpoint by full path after loading symbols - built relative"
-if { [gdb_breakpoint ${objdir}/${subdir}/tmp-${srcfile}:${line} {no-message}] != 0 } {
+if { [gdb_breakpoint [standard_output_file tmp-${srcfile}]:${line} {no-message}] != 0 } {
     pass $msg
 } else {
     fail $msg
@@ -102,7 +100,8 @@ if { [gdb_breakpoint ${objdir}/${subdir}/tmp-${srcfile}:${line} {no-message}] !=
 
 set save_pwd [pwd]
 cd ${subdir}
-if  { [gdb_compile "tmp-${srcfile}" "${testfile}" executable {debug}] != "" } {
+if  { [gdb_compile [standard_output_file tmp-${srcfile}] "${testfile}" \
+	   executable {debug}] != "" } {
     cd $save_pwd
     return -1
 }
@@ -113,7 +112,7 @@ gdb_start
 gdb_load ${binfile}
 
 set msg "set breakpoint by full path before loading symbols - built other"
-if { [gdb_breakpoint ${objdir}/${subdir}/tmp-${srcfile}:${line} {no-message}] != 0 } {
+if { [gdb_breakpoint [standard_output_file tmp-${srcfile}]:${line} {no-message}] != 0 } {
     pass $msg
 } else {
     fail $msg
@@ -123,7 +122,7 @@ gdb_test "break main" \
 	 "Breakpoint.*at.*line.*" "set breakpoint at main - built other"
 
 set msg "set breakpoint by full path after loading symbols - built other"
-if { [gdb_breakpoint ${objdir}/${subdir}/tmp-${srcfile}:${line} {no-message}] != 0 } {
+if { [gdb_breakpoint [standard_output_file tmp-${srcfile}]:${line} {no-message}] != 0 } {
     pass $msg
 } else {
     fail $msg

gdb/testsuite/gdb.base/funcargs.exp

@@ -16,26 +16,24 @@
 # This file was written by Fred Fish. (fnf@cygnus.com)
 
 
-set testfile "funcargs"
+standard_testfile
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
 set compile_flags {debug nowarnings quiet}
 if [support_complex_tests] {
     lappend compile_flags "additional_flags=-DTEST_COMPLEX"
 }
 
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable $compile_flags] != "" } {
-     untested funcargs.exp
-     return -1
-}
-
 # Create and source the file that provides information about the compiler
 # used to compile the test case.
 if [get_compiler_info] {
     return -1
 }
 
+if {[prepare_for_testing $testfile.exp $testfile $srcfile $compile_flags]} {
+    untested $testfile.exp
+    return -1
+}
+
 #
 # Locate actual args; integral types.
 #
@@ -1159,13 +1157,6 @@ proc test_stepping_over_trampolines { } {
     gdb_stop_suppressing_tests
 }
 
-# Start with a fresh gdb.
-
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
-
 set prev_timeout $timeout
 if [istarget "mips*tx39-*"] {
     set timeout 300

gdb/testsuite/gdb.base/gcore-buffer-overflow.exp

@@ -16,12 +16,11 @@
 # Test GDB's internal buffers safety for the GCORE command.
 
 
-set testfile "gcore-buffer-overflow"
+standard_testfile .c
-set srcfile  ${testfile}.c
 # The ${binfile} basename needs to exceed 80 characters (`sizeof (psargs)')
 # plus some additional data to overwrite the stack frame.
 set pattern  01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
-set binfile  ${objdir}/${subdir}/${testfile}-${pattern}
+append binfile -${pattern}
 
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
      untested ${testfile}.exp
@@ -30,10 +29,7 @@ if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {deb
 
 # Start with a fresh gdb.
 
-gdb_exit
+clean_restart ${binfile}
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
 
 # Does this gdb support gcore?
 gdb_test_multiple "help gcore" "help gcore" {
@@ -55,4 +51,4 @@ if { ! [ runto_main ] } then {
     return -1
 }
 
-gdb_gcore_cmd "${objdir}/${subdir}/gcore-buffer-overflow.test" "save a corefile"
+gdb_gcore_cmd [standard_testfile gcore-buffer-overflow.test] "save a corefile"

gdb/testsuite/gdb.base/gcore.exp

@@ -17,22 +17,13 @@
 # This is a test for the gdb command "generate-core-file".
 
 
-set testfile "gcore"
+standard_testfile
-set srcfile  ${testfile}.c
-set binfile  ${objdir}/${subdir}/${testfile}
 
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
+if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
-     untested gcore.exp
+    untested $testfile.exp
-     return -1
+    return -1
 }
 
-# Start with a fresh gdb.
-
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
-
 # Does this gdb support gcore?
 gdb_test_multiple "help gcore" "help gcore" {
     -re "Undefined command: .gcore.*$gdb_prompt $" {
@@ -86,7 +77,7 @@ set pre_corefile_local_array \
 set pre_corefile_extern_array \
 	[capture_command_output "print extern_array" "$print_prefix"]
 
-set corefile "${objdir}/${subdir}/gcore.test"
+set corefile [standard_output_file gcore.test]
 set core_supported [gdb_gcore_cmd "$corefile" "save a corefile"]
 if {!$core_supported} {
   return -1

gdb/testsuite/gdb.base/gdb1090.exp

@@ -22,20 +22,13 @@
 # test running programs
 #
 
-set testfile "gdb1090"
+standard_testfile
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
+if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
-     untested gdb1090.exp
+    untested $testfile.exp
-     return -1
+    return -1
 }
 
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
-
 if ![runto_main] then {
     fail "Can't run to main"
     return 1

gdb/testsuite/gdb.base/gdb11530.exp

@@ -18,8 +18,7 @@
 # Test GDB bug report 11530.
 # This is a problem related unnamed unions.
 
-set testfile "gdb11530"
+standard_testfile
-set binfile ${testfile}${EXEEXT}
 
 # Unnamed union is a GNU extension, thus we restrict the test
 # to gcc compiler.

gdb/testsuite/gdb.base/gdb11531.exp

@@ -20,7 +20,7 @@
 # It affects Solaris native targets.
 
 
-set testfile "gdb11531"
+standard_testfile
 
 if { [prepare_for_testing $testfile.exp $testfile $testfile.c {debug}] } {
     return -1

gdb/testsuite/gdb.base/gdb1250.exp

@@ -22,19 +22,14 @@
 # test running programs
 #
 
-set testfile "gdb1250"
+standard_testfile .c
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
      untested gdb1250.exp
      return -1
 }
 
-gdb_exit
+clean_restart ${binfile}
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
 
 if ![runto abort {allow-pending}] then {
     continue

gdb/testsuite/gdb.base/gdb1555.exp

@@ -21,13 +21,11 @@ if {[skip_shlib_tests]} {
     return 0
 }
 
-set testfile gdb1555-main
+standard_testfile gdb1555-main.c gdb1555.c
-set libfile gdb1555
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
+set libfile gdb1555
 set libsrc "${srcdir}/${subdir}/${libfile}.c"
-set libobj "${objdir}/${subdir}/${libfile}.so"
+set libobj [standard_output_file ${libfile}.so]
 set execsrc "${srcdir}/${subdir}/${srcfile}"
 
 remote_exec build "rm -f ${binfile}"
@@ -43,10 +41,7 @@ if { [gdb_compile_shlib $libsrc $libobj {debug}] != ""
     return -1
 }
 
-gdb_exit
+clean_restart ${binfile}
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
 gdb_load_shlibs $libobj
 
 if ![runto_main] then {

gdb/testsuite/gdb.base/gdb1821.exp

@@ -22,18 +22,13 @@
 # test running programs
 #
 
-set testfile "gdb1821"
+standard_testfile
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
+if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
-     return -1
+    untested $testfile.exp
+    return -1
 }
 
-gdb_exit
-gdb_start
-gdb_load ${binfile}
-
 if ![runto_main] then {
     perror "couldn't run to breakpoint"
     continue

gdb/testsuite/gdb.base/gdbindex-stabs.exp

@@ -15,13 +15,11 @@
 
 # This problem is reproducible only when using `gdb/cc-with-index.sh'.
 
-set testfile gdbindex-stabs
+standard_testfile gdbindex-stabs.c
-set executable ${testfile}
-set binfile ${objdir}/${subdir}/${executable}
 set srcfile_stabs ${testfile}.c
 set srcfile_dwarf ${testfile}-dwarf.c
-set objfile_stabs ${testfile}.o
+set objfile_stabs [standard_output_file ${testfile}.o]
-set objfile_dwarf ${testfile}-dwarf.o
+set objfile_dwarf [standard_output_file ${testfile}-dwarf.o]
 
 if {[gdb_compile "${srcdir}/${subdir}/${srcfile_stabs}" ${objfile_stabs} object {additional_flags=-gstabs}] != ""
     || [gdb_compile "${srcdir}/${subdir}/${srcfile_dwarf}" ${objfile_dwarf} object {additional_flags=-gdwarf-2}] != ""
@@ -30,7 +28,7 @@ if {[gdb_compile "${srcdir}/${subdir}/${srcfile_stabs}" ${objfile_stabs} object
      return -1
 }
 
-clean_restart ${executable}
+clean_restart ${binfile}
 
 # FAIL was: No line number known for stabs_function.
 gdb_test "list stabs_function" " marker-here .*"

gdb/testsuite/gdb.base/gdbvars.exp

@@ -16,12 +16,10 @@
 # This file was written by Fred Fish. (fnf@cygnus.com)
 
 
-set testfile "gdbvars"
+standard_testfile
-set srcfile  ${testfile}.c
-set binfile  ${objdir}/${subdir}/${testfile}
 
-if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
+if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
-    untested gdbvars.exp
+    untested $testfile.exp
     return -1
 }
 
@@ -112,13 +110,6 @@ proc test_with_program {} {
 	"Print contents of new convenience variable of program variable"
 }
 
-# Start with a fresh gdb.
-
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load ${binfile}
-
 gdb_test_no_output "set print sevenbit-strings"
 
 test_value_history

gdb/testsuite/gdb.base/gnu-ifunc.exp

@@ -17,18 +17,16 @@ if {[skip_shlib_tests]} {
     return 0
 }
 
-set testfile "gnu-ifunc"
+standard_testfile .c
 set executable ${testfile}
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${executable}
 set staticexecutable ${executable}-static
-set staticbinfile ${objdir}/${subdir}/${staticexecutable}
+set staticbinfile [standard_output_file ${staticexecutable}]
 
 set libfile "${testfile}-lib"
 set libsrc ${libfile}.c
-set lib_so ${objdir}/${subdir}/${libfile}.so
+set lib_so [standard_output_file ${libfile}.so]
 # $lib_o must not have {debug}, it would override the STT_GNU_IFUNC ELF markers.
-set lib_o ${objdir}/${subdir}/${libfile}.o
+set lib_o [standard_output_file ${libfile}.o]
 
 # We need DWARF for the "final" function as we "step" into the function and GDB
 # would step-over the "final" function if there would be no line number debug

gdb/testsuite/gdb.base/gnu_vector.exp

@@ -18,9 +18,7 @@
 # Tests GDBs support for GNU vectors.
 # http://gcc.gnu.org/onlinedocs/gcc/Vector-Extensions.html
 
-set testfile "gnu_vector"
+standard_testfile .c
-set srcfile ${testfile}.c
-set binfile ${objdir}/${subdir}/${testfile}
 
 if [get_compiler_info] {
     return -1