espressif/binutils-gdb
1
0
Fork 0
mirror of https://github.com/espressif/binutils-gdb.git synced 2025-12-18 08:49:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Re: binary outsymbols

Browse Source 
The "of course to free outsymbols" turned out to be wrong.  outsymbols
belongs to objcopy which frees them, so commit 6ca01b0bdd introduced
a double free.

	* srec.c (srec_write_symbols): Don't free outsymbols.
	* tekhex.c (tekhex_write_object_contents): Likewise.
This commit is contained in:
Alan Modra
2025-01-18 10:55:22 +10:30
parent 5d6142b571
commit 26dd9cb647
2 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bfd/srec.c
View File

@@ -1114,13 +1114,9 @@ srec_write_symbols (bfd *abfd)
goto fail; goto fail;
} }
free (abfd->outsymbols);
abfd->outsymbols = NULL;
return true; return true;
fail: fail:
free (abfd->outsymbols);
abfd->outsymbols = NULL;
return false; return false;
} }

4
bfd/tekhex.c
View File

@@ -886,13 +886,9 @@ tekhex_write_object_contents (bfd *abfd)
/* And the terminator. */ /* And the terminator. */
if (bfd_write ("%0781010\n", 9, abfd) != 9) if (bfd_write ("%0781010\n", 9, abfd) != 9)
goto fail; goto fail;
free (abfd->outsymbols);
abfd->outsymbols = NULL;
return true; return true;
fail: fail:
free (abfd->outsymbols);
abfd->outsymbols = NULL;
return false; return false;
} }